Display size and count of blink dom objects in memory-infra. The blink contains two type of object:the dom objects have explicitly specified names via using NameProvider, and the cpp internal objects have hide names 'InternalNode'. Now we must enable CPPGC_SUPPORTS_OBJECT_NAMES macro to show the name and size of all blink objects in memory-infra. I think it is better that display dom objects count and size without enabling CPPGC_SUPPORTS_OBJECT_NAMES macro in release version. It will provide great convenience to help us debug the memory issues of the blink object. [v8/v8 : main]
Omer Katz (Gerrit)
Omer Katz added 1 comment![]( "Open in Gerrit")
Names are intentionally omitted in production builds (unless explicitly enabled) to avoid increasing the binary size.
Always having the names available would indeed be convenient for debugging, but it's not currently an option.
You could try using "Chrome for Testing" instead (see https://developer.chrome.com/blog/chrome-for-testing/), which I believe should have the names enabled.
Related details
- Michael Lippautz
- 鹏强王
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
鹏强王 (Gerrit)
鹏强王 added 1 comment![]( "Open in Gerrit")
Names are intentionally omitted in production builds (unless explicitly enabled) to avoid increasing the binary size.
Always having the names available would indeed be convenient for debugging, but it's not currently an option.
You could try using "Chrome for Testing" instead (see https://developer.chrome.com/blog/chrome-for-testing/), which I believe should have the names enabled.
I approve of your opinion that name omitted in production builds to avoid increasing the binary size. But some blink objects has explicitly specified names inherited NameProvider, we can obtain these blink objects name using NameProvide::GetHumanReadableName, the Human-readable name of these object is used to show in devtools heap snapshot. it doesn't increase the binary size. I think it is necessary that show these blink object in memory-infra.
Related details
- Michael Lippautz
- Omer Katz
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Michael Lippautz added 3 comments![]( "Open in Gerrit")
This is not exposting the names but merely providing stats that squash all types under "InternalType", right?
Display size and count of blink dom objects in memory-infra.Please add a title to your CL and format it accordingly.
"""
Title
Description...
Bug:
"""
* Statistics for object allocated on the page. The dom objects name wasWe generally don't refer to terms like DOM from V8 as that concept doesn't exist here on the API.
If we go through with this change, this would need to saysomething along the lnes of
"Statistics for object allocated on the page. Note that objects without names are coerced to a single type."
Related details
- Omer Katz
- 鹏强王
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
鹏强王 (Gerrit)
鹏强王 added 1 comment![]( "Open in Gerrit")
This is not exposting the names but merely providing stats that squash all types under "InternalType", right?
If an object inherit from class NameProvider and override NameInHeapSnapshot function, it will display name returned by this function, just like in devtool heap snapshot, and other object will squash all types under "InternalType".
Related details
- Michael Lippautz
- Omer Katz
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |