[tools] Better run_perf.py variants testing with test_flags [v8/v8 : main]

0 views
Skip to first unread message

Camillo Bruni (Gerrit)

unread,
Apr 15, 2026, 6:52:09 AM (5 days ago) Apr 15
to Michael Achenbach, Hannes Payer, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, leszek...@chromium.org, was...@google.com, jgrube...@chromium.org, victorgo...@chromium.org, v8-ppc...@googlegroups.com, oilpan-r...@chromium.org, marja...@chromium.org, v8-mip...@googlegroups.com, dmercadi...@chromium.org, cbruni...@chromium.org, pthier...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Achenbach

Camillo Bruni voted and added 1 comment

Votes added by Camillo Bruni

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Camillo Bruni . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Achenbach
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I216ee7cf7ada10cf3b7d0ec44d8f46c938675027
Gerrit-Change-Number: 7735142
Gerrit-PatchSet: 9
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Achenbach <mache...@chromium.org>
Gerrit-Comment-Date: Wed, 15 Apr 2026 10:52:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Achenbach (Gerrit)

unread,
Apr 15, 2026, 12:35:32 PM (5 days ago) Apr 15
to Camillo Bruni, Hannes Payer, android-bu...@system.gserviceaccount.com, v8-s...@luci-project-accounts.iam.gserviceaccount.com, leszek...@chromium.org, was...@google.com, jgrube...@chromium.org, victorgo...@chromium.org, v8-ppc...@googlegroups.com, oilpan-r...@chromium.org, marja...@chromium.org, v8-mip...@googlegroups.com, dmercadi...@chromium.org, cbruni...@chromium.org, pthier...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Camillo Bruni

Michael Achenbach voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I216ee7cf7ada10cf3b7d0ec44d8f46c938675027
Gerrit-Change-Number: 7735142
Gerrit-PatchSet: 9
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
Gerrit-Comment-Date: Wed, 15 Apr 2026 16:35:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Apr 15, 2026, 12:39:16 PM (5 days ago) Apr 15
to Camillo Bruni, Michael Achenbach, Hannes Payer, android-bu...@system.gserviceaccount.com, leszek...@chromium.org, was...@google.com, jgrube...@chromium.org, victorgo...@chromium.org, v8-ppc...@googlegroups.com, oilpan-r...@chromium.org, marja...@chromium.org, v8-mip...@googlegroups.com, dmercadi...@chromium.org, cbruni...@chromium.org, pthier...@chromium.org, devtools-...@chromium.org, mlippau...@chromium.org, verwaes...@chromium.org, v8-risc...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[tools] Better run_perf.py variants testing with test_flags
Change-Id: I216ee7cf7ada10cf3b7d0ec44d8f46c938675027
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Auto-Submit: Camillo Bruni <cbr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106514}
Files:
  • M tools/unittests/run_perf_test.py
Change size: M
Delta: 1 file changed, 80 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Achenbach
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I216ee7cf7ada10cf3b7d0ec44d8f46c938675027
Gerrit-Change-Number: 7735142
Gerrit-PatchSet: 10
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Michael Achenbach <mache...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages