[profiler] Add postfix to C++ objects in DevTools heap snapshot [v8/v8 : main]
0 views
Skip to first unread message
Andreas Haas (Gerrit)
Nov 14, 2025, 4:51:27 AMNov 14
to Igor Sheludko, V8 LUCI CQ, AyeAye, oilpan-r...@chromium.org, devtools-...@chromium.org
Attention needed from Igor Sheludko
Andreas Haas added 1 comment![]( "Open in Gerrit")
Commit Message
Line 7, Patchset 3:
[profiler] Add postfix to C++ objects in Devtools heap snapshotIgor Sheludko . resolved
Andreas HaasNit: `Tools`
Done
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Nov 14, 2025, 6:10:59 AMNov 14
to Dominik Inführ, Igor Sheludko, V8 LUCI CQ, AyeAye, oilpan-r...@chromium.org, devtools-...@chromium.org
Attention needed from Dominik Inführ and Igor Sheludko
Andreas Haas added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Andreas Haas . resolved
Dominik, can you do an owner review please?
Related details
Attention is currently required from:
- Dominik Inführ
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Nov 14, 2025, 6:13:44 AMNov 14
to Andreas Haas, Dominik Inführ, V8 LUCI CQ, AyeAye, oilpan-r...@chromium.org, devtools-...@chromium.org
Attention needed from Andreas Haas and Dominik Inführ
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Andreas Haas
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Nov 14, 2025, 7:14:01 AMNov 14
to Andreas Haas, Igor Sheludko, V8 LUCI CQ, AyeAye, oilpan-r...@chromium.org, devtools-...@chromium.org
Attention needed from Andreas Haas
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
1 comment
Patchset-level comments
Dominik Inführ . resolved
Thanks, LGTM
Related details
Attention is currently required from:
- Andreas Haas
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Nov 14, 2025, 7:20:46 AMNov 14
to Dominik Inführ, Igor Sheludko, V8 LUCI CQ, AyeAye, oilpan-r...@chromium.org, devtools-...@chromium.org
Andreas Haas voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Nov 14, 2025, 7:22:37 AMNov 14
to Andreas Haas, Dominik Inführ, Igor Sheludko, AyeAye, oilpan-r...@chromium.org, devtools-...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[profiler] Add postfix to C++ objects in DevTools heap snapshot
In a Chrome DevTools heap snapshot, both JavaScript and C++ objects are
shown. In some instances, both a JavaScript object and a C++ object can
even have the same name, e.g. "Window" objects. With this CL, the
postfix "C++" is added to C++ objects so that they can be distinguished
from JavaScript objects.
Bug: 454073115
Change-Id: I777419e4b4e30a9cbb53544a4b21f343445e2f85
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Commit-Queue: Andreas Haas <ah...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103723}
Files:
- M src/profiler/heap-snapshot-generator.cc
- M test/cctest/test-heap-profiler.cc
- M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Change size: M
Delta: 3 files changed, 104 insertions(+), 82 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Igor Sheludko, +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
R. I.
Nov 14, 2025, 7:33:39 AMNov 14
to devtools...@chromium.org, Andreas Haas, Dominik Inführ, Igor Sheludko, AyeAye, oilpan-r...@chromium.org, devtools-...@chromium.org
I developed this tools Gerrit API-to-Go my tools is pack give me your requirements then I will tic tack toe in a minute I always making j.son turn to it's normal operation I can fix all of your queries emailed me stop manipulating my phone LUCI I check my account you intervene as an app but you getting all my information I'm RAYMUND DE VERA ICO raymun...@gmail.com Gerrit API-to-Go developer
To unsubscribe from this group and stop receiving emails from it, send an email to devtools-revie...@chromium.org.
Manos Koukoutos (Gerrit)
Nov 14, 2025, 8:15:56 AMNov 14
to Andreas Haas, V8 LUCI CQ, Dominik Inführ, Igor Sheludko, AyeAye, oilpan-r...@chromium.org, devtools-...@chromium.org
Manos Koukoutos has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages