Reland "Pass heap snapshot source locations through blink::WebNode (and subclasses), autofill::FormRef, and autofill::FieldRef." [chromium/src : main]
0 views
Skip to first unread message
David Baron (Gerrit)
Dec 15, 2025, 9:36:07 AM (13 days ago) Dec 15
to David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, browser-comp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Daniel Cheng
David Baron added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
David Baron . resolved
https://chromium-review.googlesource.com/c/chromium/src/+/7254577/1..3 is the diff for the reland
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Dec 15, 2025, 11:58:17 AM (13 days ago) Dec 15
to David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, browser-comp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from David Baron
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
1 comment
Patchset-level comments
Daniel Cheng . unresolved
LGTM but please explain the build fix for the reland in the CL description too
Related details
Attention is currently required from:
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Dec 16, 2025, 9:32:23 PM (12 days ago) Dec 16
to David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, browser-comp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Christoph Schwering
David Baron voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Christoph Schwering
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Dec 16, 2025, 9:32:56 PM (12 days ago) Dec 16
to David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, browser-comp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from Christoph Schwering
David Baron added 1 comment![]( "Open in Gerrit")
Patchset-level comments
LGTM but please explain the build fix for the reland in the CL description too
David Baron
Done
Related details
Attention is currently required from:
- Christoph Schwering
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christoph Schwering (Gerrit)
Dec 16, 2025, 10:11:21 PM (12 days ago) Dec 16
to David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, browser-comp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Attention needed from David Baron
Christoph Schwering voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Dec 17, 2025, 10:39:58 AM (11 days ago) Dec 17
to David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, browser-comp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
David Baron voted![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Dec 17, 2025, 12:06:36 PM (11 days ago) Dec 17
to David Baron, Chromium LUCI CQ, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, browser-comp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
David Baron voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 17, 2025, 2:25:18 PM (11 days ago) Dec 17
to David Baron, Daniel Cheng, AyeAye, Michael Lippautz, chromium...@chromium.org, Kentaro Hara, browser-comp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "Pass heap snapshot source locations through blink::WebNode (and subclasses), autofill::FormRef, and autofill::FieldRef."
This is a reland of commit 4156d6460349a7c1520136ff2be479065ad7c7cd
with the addition of an additional public_deps item in
third_party/blink/renderer/platform/BUILD.gn to expose the header
that VERBOSE_PERSISTENT has moved to.
Original change's description:
> Pass heap snapshot source locations through blink::WebNode (and subclasses), autofill::FormRef, and autofill::FieldRef.
>
> Bug: 342247579
> Change-Id: Ieb2a490455048063184fb0c79a539093b5d26b2b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7224596
> Reviewed-by: Daniel Cheng <dch...@chromium.org>
> Reviewed-by: Christoph Schwering <schw...@google.com>
> Commit-Queue: David Baron <dba...@chromium.org>
> Reviewed-by: Dominic Farolino <d...@chromium.org>
> Owners-Override: Daniel Cheng <dch...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1557625}
Bug: 342247579
Change-Id: I4964675db7109b7a77de0c155879c57778634f69
Cq-Include-Trybots: luci.chromium.try:android-arm-compile-dbg
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Christoph Schwering <schw...@google.com>
Commit-Queue: David Baron <dba...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1560075}
Files:
- M components/autofill/content/renderer/autofill_agent.cc
- M components/autofill/content/renderer/form_tracker.cc
- M components/autofill/content/renderer/form_tracker.h
- M third_party/blink/public/BUILD.gn
- M third_party/blink/public/web/web_document.h
- M third_party/blink/public/web/web_element.h
- M third_party/blink/public/web/web_form_control_element.h
- M third_party/blink/public/web/web_form_element.h
- M third_party/blink/public/web/web_input_element.h
- M third_party/blink/public/web/web_label_element.h
- M third_party/blink/public/web/web_meta_element.h
- M third_party/blink/public/web/web_node.h
- M third_party/blink/public/web/web_option_element.h
- M third_party/blink/public/web/web_select_element.h
- M third_party/blink/renderer/core/exported/web_node.cc
- M third_party/blink/renderer/platform/BUILD.gn
- M third_party/blink/renderer/platform/heap/BUILD.gn
- M third_party/blink/renderer/platform/heap/cross_thread_handle_internal.h
- M third_party/blink/renderer/platform/heap/persistent.h
- M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
Change size: M
Delta: 20 files changed, 70 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng, +1 by Christoph Schwering
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages