[M140] heap: Fix inconsistencies in HeapObserverList [chromium/src : refs/branch-heads/7339]

0 views

Skip to first unread message

Rubber Stamper (Gerrit)

unread,

Aug 20, 2025, 5:01:17 PMAug 20

to Chrome Cherry Picker, Michael Lippautz, Kentaro Hara, AyeAye, oilpan-rev...@chromium.org, kouhe...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org

Rubber Stamper voted

Bot-Commit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Lint

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Aug 20, 2025, 6:27:19 PMAug 20

to Chrome Cherry Picker, Michael Lippautz, Rubber Stamper, Kentaro Hara, AyeAye, oilpan-rev...@chromium.org, kouhe...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[M140] heap: Fix inconsistencies in HeapObserverList

Original change's description:
> heap: Fix inconsistencies in HeapObserverList
> 
> The observer list is both weak (implicitly managed) and allows for
> removing observers. If observers are removed while at the same time
> multiple other observers die, and the removal call triggers GC, this may
> lead to CHECK() failures where the index retrieved on `RemoveObserver`
> is too large for the `observers_` array.
> 
> Bug: 438569732, 438916130
> Change-Id: I6731ad38e96f01a47258bc8f8f5a0b1b41e736a3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6859882
> Commit-Queue: Michael Lippautz <mlip...@chromium.org>
> Reviewed-by: Anton Bikineev <biki...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1503316}