Matthias Liedtke (Gerrit)

unread,

May 8, 2026, 9:14:46 AMMay 8

to SLSA Policy Verification Service, Jakob Kummerow, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, dmercadi...@chromium.org, hongcha...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Jakob Kummerow

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

Commit-Queue

+1

1 comment

File third_party/inspector_protocol/crdtp/protocol_core.h

Line 152, Patchset 1: if (tokenizer->TokenTag() == cbor::CBORTokenTag::ENVELOPE) {

Jakob Kummerow . resolved

Might have to undo the changes in this file, since it's third-party and copied in.

Matthias Liedtke

Done. If you +1 it again, I guess I'll use owners-override to land this. Or is there a good way without requesting 20 reviewers?

Open in Gerrit

Related details

Attention is currently required from:

Jakob Kummerow

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Darius Mercadier (Gerrit)

unread,

May 8, 2026, 9:19:09 AMMay 8

to Matthias Liedtke, v8-s...@luci-project-accounts.iam.gserviceaccount.com, SLSA Policy Verification Service, Jakob Kummerow, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, dmercadi...@chromium.org, hongcha...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Jakob Kummerow and Matthias Liedtke

Darius Mercadier added 1 comment

File third_party/inspector_protocol/crdtp/protocol_core.h

Line 152, Patchset 1: if (tokenizer->TokenTag() == cbor::CBORTokenTag::ENVELOPE) {

Jakob Kummerow . resolved

Might have to undo the changes in this file, since it's third-party and copied in.

Matthias Liedtke

Done. If you +1 it again, I guess I'll use owners-override to land this. Or is there a good way without requesting 20 reviewers?

Darius Mercadier

Asking an Eng reviewer would be the official way to do this, rather than using your owner-override power ;)

Open in Gerrit

Related details

Attention is currently required from:

Jakob Kummerow
Matthias Liedtke

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Matthias Liedtke (Gerrit)

unread,

May 8, 2026, 9:24:15 AMMay 8

to Leszek Swirski, Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, SLSA Policy Verification Service, Jakob Kummerow, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, dmercadi...@chromium.org, hongcha...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Jakob Kummerow and Leszek Swirski

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Matthias Liedtke . unresolved

@les...@chromium.org: Can you do the eng review? As discussed, this only touches multiline compound statements.

This is a fully automated change using `clang-tidy`'s readability-around-statements check with the config `CheckOptions: {readability-braces-around-statements.ShortStatementLines: 1}`.
(Obviously it would be great if clang-tidy could become part of the CQ but I don't think I have any time to look into that right now.)

Open in Gerrit

Related details

Attention is currently required from:

Jakob Kummerow
Leszek Swirski

Submit Requirements:

Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Leszek Swirski (Gerrit)

unread,

May 8, 2026, 9:42:33 AMMay 8

to Matthias Liedtke, Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, SLSA Policy Verification Service, Jakob Kummerow, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, dmercadi...@chromium.org, hongcha...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Jakob Kummerow and Matthias Liedtke

Leszek Swirski voted and added 1 comment

Votes added by Leszek Swirski

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Matthias Liedtke . resolved

@les...@chromium.org: Can you do the eng review? As discussed, this only touches multiline compound statements.
This is a fully automated change using `clang-tidy`'s readability-around-statements check with the config `CheckOptions: {readability-braces-around-statements.ShortStatementLines: 1}`.
(Obviously it would be great if clang-tidy could become part of the CQ but I don't think I have any time to look into that right now.)

Leszek Swirski

Looks great, thanks. Can you make sure to have a followup which adds this to https://source.chromium.org/chromium/chromium/src/+/main:v8/.git-blame-ignore-revs ?

Open in Gerrit

Related details

Attention is currently required from:

Jakob Kummerow
Matthias Liedtke

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Matthias Liedtke (Gerrit)

unread,

May 8, 2026, 10:37:03 AMMay 8

to Leszek Swirski, Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, SLSA Policy Verification Service, Jakob Kummerow, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, dmercadi...@chromium.org, hongcha...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

Attention needed from Jakob Kummerow

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Matthias Liedtke . resolved

@les...@chromium.org: Can you do the eng review? As discussed, this only touches multiline compound statements.
This is a fully automated change using `clang-tidy`'s readability-around-statements check with the config `CheckOptions: {readability-braces-around-statements.ShortStatementLines: 1}`.
(Obviously it would be great if clang-tidy could become part of the CQ but I don't think I have any time to look into that right now.)

Leszek Swirski

Looks great, thanks. Can you make sure to have a followup which adds this to https://source.chromium.org/chromium/chromium/src/+/main:v8/.git-blame-ignore-revs ?

Matthias Liedtke

Thanks, I would've forgotten.

Open in Gerrit

Related details

Attention is currently required from:

Jakob Kummerow

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

May 8, 2026, 10:40:29 AMMay 8

to Matthias Liedtke, Leszek Swirski, Darius Mercadier, SLSA Policy Verification Service, Jakob Kummerow, Hannes Payer, cbruni...@chromium.org, devtools-...@chromium.org, dmercadi...@chromium.org, hongcha...@chromium.org, jgrube...@chromium.org, leszek...@chromium.org, marja...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, rtoy+...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org, was...@google.com

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[cleanup] Apply readability-braces-around-statements

Change-Id: Icb5b0ab02689c969ec2a14be7abf1759f1954e45

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7827654

SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Reviewed-by: Leszek Swirski <les...@chromium.org>

Commit-Queue: Matthias Liedtke <mlie...@chromium.org>

Auto-Submit: Matthias Liedtke <mlie...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#107187}

Files:

M include/cppgc/internal/name-trait.h
M include/cppgc/internal/pointer-policies.h
M include/cppgc/internal/write-barrier.h
M src/api/api-natives.cc
M src/api/api.cc
M src/api/api.h
M src/asmjs/asm-js.cc
M src/ast/ast-value-factory.cc
M src/ast/ast.h
M src/ast/prettyprinter.cc
M src/ast/scopes.cc
M src/base/debug/stack_trace_posix.cc
M src/base/ieee754.cc
M src/base/numbers/strtod.cc
M src/base/platform/platform-linux.cc
M src/base/platform/platform-posix.cc
M src/base/virtual-address-space.cc
M src/builtins/accessors.cc
M src/builtins/builtins-array.cc
M src/builtins/builtins-sharedarraybuffer.cc
M src/codegen/compiler.cc
M src/codegen/x64/assembler-x64.cc
M src/compiler/backend/code-generator.cc
M src/compiler/backend/instruction-selector.cc
M src/compiler/backend/move-optimizer.cc
M src/compiler/backend/register-allocator.cc
M src/compiler/backend/simd-shuffle.cc
M src/compiler/backend/x64/code-generator-x64.cc
M src/compiler/backend/x64/instruction-selector-x64.cc
M src/compiler/bytecode-analysis.cc
M src/compiler/frame-states.cc
M src/compiler/js-native-context-specialization.cc
M src/compiler/js-typed-lowering.cc
M src/compiler/linear-scheduler.cc
M src/compiler/load-elimination.cc
M src/compiler/machine-operator-reducer.cc
M src/compiler/node-matchers.h
M src/compiler/persistent-map.h
M src/compiler/revectorizer.cc
M src/compiler/simplified-lowering.cc
M src/compiler/simplified-operator-reducer.cc
M src/compiler/turbofan-graph-visualizer.cc
M src/compiler/turboshaft/copying-phase.h
M src/compiler/turboshaft/dead-code-elimination-reducer.h
M src/compiler/turboshaft/operations.cc
M src/compiler/turboshaft/store-store-elimination-reducer-inl.h
M src/compiler/turboshaft/typer.h
M src/compiler/turboshaft/types.cc
M src/compiler/turboshaft/types.h
M src/d8/d8.cc
M src/date/dateparser-inl.h
M src/date/dateparser.cc
M src/debug/debug-interface.cc
M src/debug/debug-scopes.cc
M src/debug/debug.cc
M src/debug/liveedit.cc
M src/deoptimizer/deoptimizer.cc
M src/diagnostics/gdb-jit.cc
M src/diagnostics/objects-debug.cc
M src/diagnostics/objects-printer.cc
M src/execution/frames.cc
M src/execution/isolate.cc
M src/handles/local-handles-inl.h
M src/handles/persistent-handles.cc
M src/handles/traced-handles.cc
M src/heap/array-buffer-sweeper.cc
M src/heap/base/basic-slot-set.h
M src/heap/base/incremental-marking-schedule.cc
M src/heap/base/stack.h
M src/heap/base/worklist.h
M src/heap/concurrent-marking.cc
M src/heap/cppgc-js/cpp-heap.cc
M src/heap/cppgc-js/cpp-snapshot.cc
M src/heap/cppgc/caged-heap-local-data.cc
M src/heap/cppgc/compactor.cc
M src/heap/cppgc/concurrent-marker.cc
M src/heap/cppgc/free-list.cc
M src/heap/cppgc/heap-page.cc
M src/heap/cppgc/marker.cc
M src/heap/cppgc/marking-state.cc
M src/heap/cppgc/marking-state.h
M src/heap/cppgc/marking-verifier.cc
M src/heap/cppgc/marking-visitor.cc
M src/heap/cppgc/stats-collector.cc
M src/heap/cppgc/stats-collector.h
M src/heap/cppgc/sweeper.cc
M src/heap/cppgc/write-barrier.cc
M src/heap/gc-callbacks.h
M src/heap/gc-tracer.cc
M src/heap/heap.cc
M src/heap/list.h
M src/heap/local-heap.cc
M src/heap/main-allocator-inl.h
M src/heap/main-allocator.cc
M src/heap/mark-compact.cc
M src/heap/mark-sweep-utilities.cc
M src/heap/marking-visitor-inl.h
M src/heap/memory-allocator.cc
M src/heap/minor-mark-sweep.cc
M src/heap/mutable-page.h
M src/heap/pretenuring-handler.cc
M src/heap/safepoint.h
M src/heap/setup-heap-internal.cc
M src/heap/sweeper.cc
M src/ic/ic.cc
M src/inspector/injected-script.cc
M src/inspector/inspected-context.cc
M src/inspector/remote-object-id.cc
M src/inspector/search-util.cc
M src/inspector/string-util.cc
M src/inspector/v8-console-agent-impl.cc
M src/inspector/v8-console-message.cc
M src/inspector/v8-console.cc
M src/inspector/v8-debugger-agent-impl.cc
M src/inspector/v8-debugger-script.cc
M src/inspector/v8-debugger.cc
M src/inspector/v8-heap-profiler-agent-impl.cc
M src/inspector/v8-inspector-impl.cc
M src/inspector/v8-inspector-session-impl.cc
M src/inspector/v8-profiler-agent-impl.cc
M src/inspector/v8-regex.cc
M src/inspector/v8-runtime-agent-impl.cc
M src/inspector/v8-stack-trace-impl.cc
M src/inspector/v8-string-conversions.cc
M src/inspector/value-mirror.cc
M src/interpreter/bytecode-array-builder.cc
M src/json/json-stringifier.cc
M src/libplatform/tracing/trace-object.cc
M src/logging/counters.h
M src/logging/log.cc
M src/logging/metrics.h
M src/maglev/maglev-graph-builder.cc
M src/maglev/maglev-ir.h
M src/maglev/maglev-node-type.cc
M src/maglev/maglev-post-hoc-optimizations-processors.h
M src/maglev/maglev-regalloc.cc
M src/objects/backing-store.cc
M src/objects/bytecode-array-inl.h
M src/objects/code.cc
M src/objects/compilation-cache-table-inl.h
M src/objects/elements.cc
M src/objects/feedback-vector-inl.h
M src/objects/feedback-vector.cc
M src/objects/intl-objects.cc
M src/objects/js-data-object-builder.cc
M src/objects/js-date-time-format.cc
M src/objects/js-duration-format.cc
M src/objects/js-objects.cc
M src/objects/js-temporal-objects.cc
M src/objects/keys.cc
M src/objects/lookup.cc
M src/objects/map.cc
M src/objects/objects.cc
M src/objects/property-descriptor.cc
M src/objects/script.cc
M src/objects/shared-function-info.cc
M src/objects/source-text-module.cc
M src/objects/string-inl.h
M src/objects/string-table.cc
M src/objects/transitions-inl.h
M src/objects/transitions.cc
M src/objects/value-serializer.cc
M src/parsing/parser-base.h
M src/parsing/parser.cc
M src/parsing/preparser.cc
M src/parsing/scanner-inl.h
M src/parsing/scanner.cc
M src/profiler/cpu-profiler.cc
M src/profiler/heap-profiler.cc
M src/profiler/heap-snapshot-generator.cc
M src/profiler/output-stream-writer.h
M src/profiler/profile-generator.cc
M src/profiler/sampling-heap-profiler.cc
M src/profiler/tick-sample.cc
M src/regexp/regexp-ast.cc
M src/regexp/regexp-compiler.cc
M src/regexp/regexp-parser.cc
M src/regexp/regexp.cc
M src/runtime/runtime-debug.cc
M src/runtime/runtime-literals.cc
M src/runtime/runtime-symbol.cc
M src/runtime/runtime-test-wasm.cc
M src/runtime/runtime-test.cc
M src/sandbox/external-pointer-table.cc
M src/sandbox/sandbox.cc
M src/snapshot/snapshot.cc
M src/snapshot/sort-builtins.cc
M src/strings/string-stream.cc
M src/torque/ast.h
M src/torque/cpp-builder.cc
M src/torque/declarable.h
M src/torque/declaration-visitor.cc
M src/torque/earley-parser.cc
M src/torque/implementation-visitor.cc
M src/torque/instance-type-generator.cc
M src/torque/torque-parser.cc
M src/torque/type-inference.cc
M src/torque/type-visitor.cc
M src/torque/types.cc
M src/utils/utils-inl.h
M src/wasm/baseline/liftoff-assembler.cc
M src/wasm/function-body-decoder-impl.h
M src/wasm/fuzzing/random-module-generation.cc
M src/wasm/module-decoder-impl.h
M src/wasm/turboshaft-graph-interface.cc
M src/wasm/wasm-debug.cc
M src/wasm/wasm-module-sourcemap.cc
M test/cctest/heap/test-heap.cc
M test/cctest/test-api-interceptors.cc
M test/cctest/test-api.cc
M test/cctest/test-cpu-profiler.cc
M test/cctest/test-heap-profiler.cc
M test/cctest/test-mementos.cc
M test/cctest/test-profile-generator.cc
M test/cctest/test-serialize.cc
M test/cctest/test-strings.cc
M test/cctest/wasm/test-run-wasm-simd.cc
M test/inspector/isolate-data.cc
M test/inspector/tasks.cc
M test/unittests/base/small-vector-unittest.cc
M test/unittests/builtins/builtins-math-unittest.cc
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc
M test/unittests/compiler/backend/instruction-unittest.cc
M test/unittests/date/date-unittest.cc
M test/unittests/heap/conservative-stack-visitor-unittest.cc
M test/unittests/heap/cppgc-js/embedder-roots-handler-unittest.cc
M test/unittests/heap/cppgc-js/traced-reference-unittest.cc
M test/unittests/heap/cppgc/compactor-unittest.cc
M test/unittests/heap/cppgc/concurrent-marking-unittest.cc
M test/unittests/heap/cppgc/marking-visitor-unittest.cc
M test/unittests/heap/cppgc/minor-gc-unittest.cc
M test/unittests/heap/heap-unittest.cc
M test/unittests/heap/inner-pointer-resolution-unittest.cc
M test/unittests/heap/page-promotion-unittest.cc
M test/unittests/libplatform/default-job-unittest.cc
M test/unittests/objects/feedback-vector-unittest.cc
M test/unittests/objects/value-serializer-unittest.cc
M test/unittests/parser/parsing-unittest.cc
M test/unittests/parser/scanner-streams-unittest.cc
M test/unittests/profiler/heap-snapshot-unittest.cc
M test/unittests/tracing/traced-value-unittest.cc
M test/unittests/wasm/decoder-unittest.cc
M tools/debug_helper/get-object-properties.cc

Change size: XL

Delta: 243 files changed, 1422 insertions(+), 752 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Leszek Swirski

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[cleanup] Apply readability-braces-around-statements [v8/v8 : main]

Matthias Liedtke (Gerrit)

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

1 comment

Related details

Darius Mercadier (Gerrit)

Darius Mercadier added 1 comment

Related details

Matthias Liedtke (Gerrit)

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

1 comment

Related details

Leszek Swirski (Gerrit)

Leszek Swirski voted and added 1 comment

Votes added by Leszek Swirski

1 comment

Related details

Matthias Liedtke (Gerrit)

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

1 comment

Related details

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information