[Memory Coordinator] Add renderer policy using V8 last chance GC [chromium/src : main]

0 views

Skip to first unread message

Patrick Monette (Gerrit)

unread,

Sep 25, 2025, 11:46:54 AMSep 25

to Daniel Cheng, AI Code Reviewer, Francois Pierre Doray, Chromium Metrics Reviews, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org

Attention needed from Daniel Cheng

Patrick Monette voted and added 3 comments

Votes added by Patrick Monette

Commit-Queue

3 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Patrick Monette . resolved

+Daniel PTAL

File third_party/blink/public/platform/platform.h

Line 858, Patchset 6: // Invoked when the garbage collector is about to run it's last GC before

Francois Pierre Doray . resolved

its

Patrick Monette

Done

File third_party/blink/renderer/controller/memory_coordinator/v8_heap_memory_signal_generator.h

Line 20, Patchset 7: static void Initialize(v8::Isolate* isolate);

AI Code Reviewer . resolved

nit: The parameter name 'isolate' is obvious from its type 'v8::Isolate*' and can be omitted from the function declaration in the header file. (Blink Style Guide: Naming - May leave obvious parameter names out of function declarations)
_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason
This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Patrick Monette

Done

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Michael Lippautz (Gerrit)

unread,

Sep 25, 2025, 11:57:19 AMSep 25

to Patrick Monette, Daniel Cheng, AI Code Reviewer, Francois Pierre Doray, Chromium Metrics Reviews, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, oilpan-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org

Attention needed from Daniel Cheng and Patrick Monette

Michael Lippautz added 1 comment

File third_party/blink/renderer/controller/memory_coordinator/v8_heap_memory_signal_generator.cc

Line 15, Patchset 10: v8::GCType gc_type,

Michael Lippautz . unresolved

I think you also need to filter for `GCType::kGCTypeMarkSweepCompact` here as we also emit the signal for other types and you may receive it a few times otherwise.