Add HeapProfiler::IsTakingSnapshot to public API [v8/v8 : main]
0 views
Skip to first unread message
Seth Brenith (Gerrit)
Jun 26, 2024, 9:52:16 AM (3 days ago) Jun 26
to Michael Lippautz, V8 LUCI CQ, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Seth Brenith added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Seth Brenith . resolved
Hi Michael, would you please review this change? Thanks again for pointing out this problem in the other CL.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 26, 2024, 10:13:34 AM (3 days ago) Jun 26
to Seth Brenith, V8 LUCI CQ, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Seth Brenith
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Seth Brenith
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Seth Brenith (Gerrit)
Jun 26, 2024, 10:55:14 AM (3 days ago) Jun 26
to Michael Lippautz, V8 LUCI CQ, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Seth Brenith voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jun 26, 2024, 10:56:35 AM (3 days ago) Jun 26
to Seth Brenith, Michael Lippautz, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add HeapProfiler::IsTakingSnapshot to public API
The function HeapProfiler::CopyNameForHeapSnapshot only works while V8
is taking a heap snapshot, but there is currently no way for the
embedder to tell whether a snapshot is in progress, so nobody can safely
use CopyNameForHeapSnapshot. To remedy the problem, this change adds a
function to check whether the heap profiler is taking a snapshot.
Bug: 343341610
Change-Id: I1e0c40a27b192d241649ac2a2dcefa53d823b971
Commit-Queue: Seth Brenith <seth.b...@microsoft.com>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#94655}
Files:
- M include/cppgc/name-provider.h
- M include/v8-profiler.h
- M src/api/api.cc
- M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
Change size: S
Delta: 4 files changed, 27 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages