[cppgc] Rename src/heap/cppgc/ to src/heap/cppgc-internal/ [v8/v8 : main]

0 views

Skip to first unread message

Igor Sheludko (Gerrit)

unread,

Jun 22, 2026, 5:04:42 AM (8 days ago) Jun 22

to SLSA Policy Verification Service, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Michael Lippautz, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Attention needed from Michael Lippautz

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Igor Sheludko . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Michael Lippautz

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Michael Lippautz (Gerrit)

unread,

Jun 22, 2026, 5:28:25 AM (8 days ago) Jun 22

to Igor Sheludko, SLSA Policy Verification Service, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

Attention needed from Igor Sheludko

Michael Lippautz voted and added 1 comment

Votes added by Michael Lippautz

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Michael Lippautz . resolved

lgtm, thanks for digging here. Quite annoying issues...

Open in Gerrit

Related details

Attention is currently required from:

Igor Sheludko

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,

Jun 22, 2026, 5:41:11 AM (8 days ago) Jun 22

to Igor Sheludko, Michael Lippautz, SLSA Policy Verification Service, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

[cppgc] Rename src/heap/cppgc/ to src/heap/cppgc-internal/

Rename the internal cppgc directory to src/heap/cppgc-internal/ to
clearly distinguish it from the public include/cppgc/ headers and
avoid potential naming confusion.
The collision occurs on Windows builds where -Wmicrosoft-include
is enabled by Clang in MSVC compatible mode. MSVC on Windows uses
different order of directories where the files are searched by the
compiler and `#include "cppgc/blah.h"` in public headers might end up
including "src/heap/cppgc/blah.h" if it exists.

All internal #include paths, include guards, and build configurations
(BUILD.gn and BUILD.bazel) have been updated to reflect the new path.

TAG=agy
CONV=47b06028-d652-41a8-b4f1-39e3cc478096

Bug: 515252150

Change-Id: Idf7ca1d193a8b6bb9d53b22f01320f4363df36f4

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7963663

Commit-Queue: Igor Sheludko <ish...@chromium.org>

Reviewed-by: Michael Lippautz <mlip...@chromium.org>

Auto-Submit: Igor Sheludko <ish...@chromium.org>

Commit-Queue: Michael Lippautz <mlip...@chromium.org>

SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Cr-Commit-Position: refs/heads/main@{#108143}

Files:

M BUILD.bazel
M BUILD.gn
M WATCHLISTS
R src/heap/cppgc-internal/DEPS
R src/heap/cppgc-internal/allocation.cc
R src/heap/cppgc-internal/caged-heap-local-data.cc
R src/heap/cppgc-internal/caged-heap.cc
R src/heap/cppgc-internal/caged-heap.h
R src/heap/cppgc-internal/compaction-worklists.cc
R src/heap/cppgc-internal/compaction-worklists.h
R src/heap/cppgc-internal/compactor.cc
R src/heap/cppgc-internal/compactor.h
R src/heap/cppgc-internal/concurrent-marker.cc
R src/heap/cppgc-internal/concurrent-marker.h
R src/heap/cppgc-internal/explicit-management.cc
R src/heap/cppgc-internal/free-list.cc
R src/heap/cppgc-internal/free-list.h
R src/heap/cppgc-internal/garbage-collector.h
R src/heap/cppgc-internal/gc-info-table.cc
R src/heap/cppgc-internal/gc-info-table.h
R src/heap/cppgc-internal/gc-info.cc
R src/heap/cppgc-internal/gc-invoker.cc
R src/heap/cppgc-internal/gc-invoker.h
R src/heap/cppgc-internal/globals.h
R src/heap/cppgc-internal/heap-base.cc
R src/heap/cppgc-internal/heap-base.h
R src/heap/cppgc-internal/heap-config.h
R src/heap/cppgc-internal/heap-consistency.cc
R src/heap/cppgc-internal/heap-growing.cc
R src/heap/cppgc-internal/heap-growing.h
R src/heap/cppgc-internal/heap-object-header.cc
R src/heap/cppgc-internal/heap-object-header.h
R src/heap/cppgc-internal/heap-page.cc
R src/heap/cppgc-internal/heap-page.h
R src/heap/cppgc-internal/heap-space.cc
R src/heap/cppgc-internal/heap-space.h
R src/heap/cppgc-internal/heap-state.cc
R src/heap/cppgc-internal/heap-statistics-collector.cc
R src/heap/cppgc-internal/heap-statistics-collector.h
R src/heap/cppgc-internal/heap-visitor.h
R src/heap/cppgc-internal/heap.cc
R src/heap/cppgc-internal/heap.h
R src/heap/cppgc-internal/liveness-broker.cc
R src/heap/cppgc-internal/liveness-broker.h
R src/heap/cppgc-internal/logging.cc
R src/heap/cppgc-internal/marker.cc
R src/heap/cppgc-internal/marker.h
R src/heap/cppgc-internal/marking-state.cc
R src/heap/cppgc-internal/marking-state.h
R src/heap/cppgc-internal/marking-verifier.cc
R src/heap/cppgc-internal/marking-verifier.h
R src/heap/cppgc-internal/marking-visitor.cc
R src/heap/cppgc-internal/marking-visitor.h
R src/heap/cppgc-internal/marking-worklists.cc
R src/heap/cppgc-internal/marking-worklists.h
R src/heap/cppgc-internal/member-storage.cc
R src/heap/cppgc-internal/member-storage.h
R src/heap/cppgc-internal/memory.cc
R src/heap/cppgc-internal/memory.h
R src/heap/cppgc-internal/metric-recorder.h
R src/heap/cppgc-internal/name-trait.cc
R src/heap/cppgc-internal/object-allocator.cc
R src/heap/cppgc-internal/object-allocator.h
R src/heap/cppgc-internal/object-poisoner.h
R src/heap/cppgc-internal/object-size-trait.cc
R src/heap/cppgc-internal/object-start-bitmap.h
R src/heap/cppgc-internal/object-view.h
R src/heap/cppgc-internal/page-memory.cc
R src/heap/cppgc-internal/page-memory.h
R src/heap/cppgc-internal/persistent-node.cc
R src/heap/cppgc-internal/platform.cc
R src/heap/cppgc-internal/platform.h
R src/heap/cppgc-internal/pointer-policies.cc
R src/heap/cppgc-internal/prefinalizer-handler.cc
R src/heap/cppgc-internal/prefinalizer-handler.h
R src/heap/cppgc-internal/process-heap-statistics.cc
R src/heap/cppgc-internal/process-heap-statistics.h
R src/heap/cppgc-internal/process-heap.cc
R src/heap/cppgc-internal/process-heap.h
R src/heap/cppgc-internal/raw-heap.cc
R src/heap/cppgc-internal/raw-heap.h
R src/heap/cppgc-internal/remembered-set.cc
R src/heap/cppgc-internal/remembered-set.h
R src/heap/cppgc-internal/stats-collector.cc
R src/heap/cppgc-internal/stats-collector.h
R src/heap/cppgc-internal/sweeper.cc
R src/heap/cppgc-internal/sweeper.h
R src/heap/cppgc-internal/task-handle.h
R src/heap/cppgc-internal/testing.cc
R src/heap/cppgc-internal/trace-event.h
R src/heap/cppgc-internal/trace-trait.cc
R src/heap/cppgc-internal/unmarker.h
R src/heap/cppgc-internal/virtual-memory.cc
R src/heap/cppgc-internal/virtual-memory.h
R src/heap/cppgc-internal/visitor.cc
R src/heap/cppgc-internal/visitor.h
R src/heap/cppgc-internal/write-barrier.cc
R src/heap/cppgc-internal/write-barrier.h
M src/heap/cppgc-js/cpp-heap.cc
M src/heap/cppgc-js/cpp-heap.h
M src/heap/cppgc-js/cpp-marking-state.h
M src/heap/cppgc-js/cpp-snapshot.cc
M src/heap/cppgc-js/cross-heap-remembered-set.cc
M src/heap/cppgc-js/unified-heap-marking-verifier.cc
M src/heap/cppgc-js/unified-heap-marking-verifier.h
M src/heap/cppgc-js/unified-heap-marking-visitor.cc
M src/heap/cppgc-js/unified-heap-marking-visitor.h
M src/heap/gc-tracer.cc
M src/heap/incremental-marking-job.cc
M test/benchmarks/cpp/cppgc/DEPS
M test/benchmarks/cpp/cppgc/allocation_perf.cc
M test/benchmarks/cpp/cppgc/binary-trees_perf.cc
M test/benchmarks/cpp/cppgc/trace_perf.cc
M test/unittests/heap/cppgc-js/traced-reference-unittest.cc
M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
M test/unittests/heap/cppgc-js/unified-heap-unittest.cc
M test/unittests/heap/cppgc-js/young-unified-heap-unittest.cc
M test/unittests/heap/cppgc/age-table-unittest.cc
M test/unittests/heap/cppgc/allocation-unittest.cc
M test/unittests/heap/cppgc/caged-heap-unittest.cc
M test/unittests/heap/cppgc/compactor-unittest.cc
M test/unittests/heap/cppgc/concurrent-marking-unittest.cc
M test/unittests/heap/cppgc/concurrent-sweeper-unittest.cc
M test/unittests/heap/cppgc/custom-spaces-unittest.cc
M test/unittests/heap/cppgc/ephemeron-pair-unittest.cc
M test/unittests/heap/cppgc/explicit-management-unittest.cc
M test/unittests/heap/cppgc/free-list-unittest.cc
M test/unittests/heap/cppgc/garbage-collected-unittest.cc
M test/unittests/heap/cppgc/gc-info-unittest.cc
M test/unittests/heap/cppgc/gc-invoker-unittest.cc
M test/unittests/heap/cppgc/heap-growing-unittest.cc
M test/unittests/heap/cppgc/heap-object-header-unittest.cc
M test/unittests/heap/cppgc/heap-page-unittest.cc
M test/unittests/heap/cppgc/heap-registry-unittest.cc
M test/unittests/heap/cppgc/heap-statistics-collector-unittest.cc
M test/unittests/heap/cppgc/heap-unittest.cc
M test/unittests/heap/cppgc/liveness-broker-unittest.cc
M test/unittests/heap/cppgc/marker-unittest.cc
M test/unittests/heap/cppgc/marking-verifier-unittest.cc
M test/unittests/heap/cppgc/marking-visitor-unittest.cc
M test/unittests/heap/cppgc/metric-recorder-unittest.cc
M test/unittests/heap/cppgc/minor-gc-unittest.cc
M test/unittests/heap/cppgc/object-size-trait-unittest.cc
M test/unittests/heap/cppgc/object-start-bitmap-unittest.cc
M test/unittests/heap/cppgc/page-memory-unittest.cc
M test/unittests/heap/cppgc/persistent-family-unittest.cc
M test/unittests/heap/cppgc/platform-unittest.cc
M test/unittests/heap/cppgc/prefinalizer-unittest.cc
M test/unittests/heap/cppgc/stack-start-marker-unittest.cc
M test/unittests/heap/cppgc/stats-collector-scopes-unittest.cc
M test/unittests/heap/cppgc/stats-collector-unittest.cc
M test/unittests/heap/cppgc/sweeper-unittest.cc
M test/unittests/heap/cppgc/tests.cc
M test/unittests/heap/cppgc/tests.h
M test/unittests/heap/cppgc/visitor-unittest.cc
M test/unittests/heap/cppgc/weak-container-unittest.cc
M test/unittests/heap/cppgc/workloads-unittest.cc
M test/unittests/heap/cppgc/write-barrier-unittest.cc
M test/unittests/profiler/heap-snapshot-utils.h
M tools/cppgc/copy.bara.sky

Change size: XL

Delta: 160 files changed, 813 insertions(+), 818 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Michael Lippautz

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages