[M144-LTS][cppgc] Clear EphemeronPair::key when the key is dead [v8/v8 : refs/branch-heads/14.4]
4 views
Skip to first unread message
Scott Haseley (Gerrit)
Jun 8, 2026, 11:40:21 AMJun 8
to Gyuyoung Kim (xWF), android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-m...@googlegroups.com
Attention needed from Gyuyoung Kim (xWF)
Scott Haseley added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Scott Haseley . resolved
I mentioned in https://issues.chromium.org/issues/508082779#comment14 that this merge shouldn't be needed since the first production use of this API was added in M149 and the bug was fixed in M149. This doesn't hurt anything, but it doesn't fix anything either since this API was only used for testing in M144.
Related details
Attention is currently required from:
- Gyuyoung Kim (xWF)
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Jun 9, 2026, 11:56:18 PMJun 9
to Scott Haseley, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-m...@googlegroups.com
Gyuyoung Kim (xWF) abandoned this change.
Abandoned
No need to cherry-pick the CL.
Gyuyoung Kim (xWF) abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Jun 19, 2026, 7:12:51 AMJun 19
to Scott Haseley, android-bu...@system.gserviceaccount.com, cbruni...@chromium.org, oilpan-r...@chromium.org, v8-m...@googlegroups.com
Gyuyoung Kim (xWF) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Scott Haseley . resolved
I mentioned in https://issues.chromium.org/issues/508082779#comment14 that this merge shouldn't be needed since the first production use of this API was added in M149 and the bug was fixed in M149. This doesn't hurt anything, but it doesn't fix anything either since this API was only used for testing in M144.
Gyuyoung Kim (xWF)
Thank you for letting me know that. Abandon this CL.
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages