cppgc: Fix concurrent marking crash in TaggedUncompressedMember [v8/v8 : main]

[Anton Bikineev (Gerrit)]

Attention needed from Michael Lippautz

Anton Bikineev voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

• Michael Lippautz

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I02be937d4dc74fa2914a897cc27afc746c2d698d

Gerrit-Change-Number: 7968378

Gerrit-PatchSet: 1

Gerrit-Owner: Anton Bikineev <biki...@chromium.org>

Gerrit-Reviewer: Anton Bikineev <biki...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>

Gerrit-Comment-Date: Fri, 19 Jun 2026 12:08:32 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Michael Lippautz (Gerrit)]

Attention needed from Anton Bikineev

Michael Lippautz added 1 comment

File include/cppgc/tagged-member.h

Line 102, Patchset 1 (Latest): v->TraceImpl(untagged);

Michael Lippautz . unresolved

We should not bypass the `Trace()` method as it's non-virtual and we cannot override it for snapshtos/verification in case we need this. Can we do the proper thing and add a virtual method on the visitor that then dispatches?

Open in Gerrit

Related details

Attention is currently required from:

• Anton Bikineev

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I02be937d4dc74fa2914a897cc27afc746c2d698d

Gerrit-Change-Number: 7968378

Gerrit-PatchSet: 1

Gerrit-Owner: Anton Bikineev <biki...@chromium.org>

Gerrit-Reviewer: Anton Bikineev <biki...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Anton Bikineev <biki...@chromium.org>

Gerrit-Comment-Date: Fri, 19 Jun 2026 12:28:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Michael Lippautz (Gerrit)]

Attention needed from Anton Bikineev

Michael Lippautz added 1 comment

Commit Message

Line 14, Patchset 1 (Latest):

Michael Lippautz . unresolved

I guess you are fixing some plugin issues? Can we have a tracking bug what support you are adding?

Open in Gerrit

Related details

Attention is currently required from:

• Anton Bikineev

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I02be937d4dc74fa2914a897cc27afc746c2d698d

Gerrit-Change-Number: 7968378

Gerrit-PatchSet: 1

Gerrit-Owner: Anton Bikineev <biki...@chromium.org>

Gerrit-Reviewer: Anton Bikineev <biki...@chromium.org>

Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Anton Bikineev <biki...@chromium.org>

Gerrit-Comment-Date: Fri, 19 Jun 2026 12:28:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No