Anton Bikineev (Gerrit)

unread,

Apr 22, 2021, 4:05:43 AM4/22/21

to Michael Lippautz, kouhe...@chromium.org, lizeb...@chromium.org, oilpan-...@chromium.org, vmpstr...@chromium.org, wfh+...@chromium.org

Attention is currently required from: Michael Lippautz.

Anton Bikineev would like Michael Lippautz to review this change.

View Change

PCScan: Assume GigaCage is always enabled on 64bit

abf98485688e7d removed that different handling of Windows < 8.1. This
allows us to assume that GigaCage is always enabled for 64bit.

This is only cleanup.

Bug: 1129751
Change-Id: I0b6a079854bc1c69150e720423fcf1021e287703
---
M base/allocator/partition_allocator/starscan/pcscan.cc
1 file changed, 24 insertions(+), 40 deletions(-)

To view, visit change 2846502. To unsubscribe, or for help writing mail filters, visit settings.

Anton Bikineev (Gerrit)

unread,

Apr 22, 2021, 4:05:52 AM4/22/21

to kouhe...@chromium.org, lizeb...@chromium.org, oilpan-...@chromium.org, vmpstr...@chromium.org, wfh+...@chromium.org, Michael Lippautz, chromium...@chromium.org, Kentaro Hara

Attention is currently required from: Michael Lippautz.

Patch set 1:Auto-Submit +1Commit-Queue +1

View Change

To view, visit change 2846502. To unsubscribe, or for help writing mail filters, visit settings.

Michael Lippautz (Gerrit)

unread,

Apr 22, 2021, 4:49:54 AM4/22/21

to Bartek Nowierski, kouhe...@chromium.org, lizeb...@chromium.org, oilpan-...@chromium.org, vmpstr...@chromium.org, wfh+...@chromium.org, Anton Bikineev

Attention is currently required from: Bartek Nowierski, Anton Bikineev.

Michael Lippautz would like Bartek Nowierski to review this change authored by Anton Bikineev.

View Change

PCScan: Assume GigaCage is always enabled on 64bit

abf98485688e7d removed that different handling of Windows < 8.1. This
allows us to assume that GigaCage is always enabled for 64bit.

This is only cleanup.

Bug: 1129751
Change-Id: I0b6a079854bc1c69150e720423fcf1021e287703
---
M base/allocator/partition_allocator/starscan/pcscan.cc
1 file changed, 24 insertions(+), 40 deletions(-)

To view, visit change 2846502. To unsubscribe, or for help writing mail filters, visit settings.

Michael Lippautz (Gerrit)

unread,

Apr 22, 2021, 4:50:03 AM4/22/21

to Anton Bikineev, kouhe...@chromium.org, lizeb...@chromium.org, oilpan-...@chromium.org, vmpstr...@chromium.org, wfh+...@chromium.org, Bartek Nowierski, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara

Attention is currently required from: Bartek Nowierski, Anton Bikineev.

Patch set 1:Code-Review +1Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  lgtm from my side, please wait for Bartek as well
  Bartek: Can you comment on whether the Windows handling will stick or it's more an experiment? We should not make a revert for you folks more complicated.

To view, visit change 2846502. To unsubscribe, or for help writing mail filters, visit settings.

Bartek Nowierski (Gerrit)

unread,

Apr 22, 2021, 5:02:10 AM4/22/21

to Anton Bikineev, kouhe...@chromium.org, lizeb...@chromium.org, oilpan-...@chromium.org, vmpstr...@chromium.org, wfh+...@chromium.org, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara

Attention is currently required from: Anton Bikineev, Michael Lippautz.

View Change

1 comment:

Patchset:
- Patch Set #1:
  lgtm from my side, please wait for Bartek as well […]
  I see that Anton is ready to pop the champagne 😊
  Right now we're in a wishful thinking stage. My CL landed only today and hasn't gone to a Canary yet. Let's wait until it sticks in Dev for a couple days, so let's revise next week.

To view, visit change 2846502. To unsubscribe, or for help writing mail filters, visit settings.

Kentaro Hara (Gerrit)

unread,

Apr 22, 2021, 9:26:52 AM4/22/21

to Anton Bikineev, kouhe...@chromium.org, lizeb...@chromium.org, oilpan-...@chromium.org, vmpstr...@chromium.org, wfh+...@chromium.org, Bartek Nowierski, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Anton Bikineev.

Patch set 1:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  This is nice! LGTM % the landing timing.
  Can we add:
  #if defined(PA_HAS_64_BITS_POINTERS)
  DCHECK(feature::IsPartitionAllocGigaCageEnabled());
  #endif
  somewhere?

To view, visit change 2846502. To unsubscribe, or for help writing mail filters, visit settings.

Mike Frysinger (Gerrit)

unread,

Jan 5, 2026, 7:42:21 PM (12 days ago) Jan 5

to Anton Bikineev, Kentaro Hara, Bartek Nowierski, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, kouhe...@chromium.org, lizeb...@chromium.org, oilpan-...@chromium.org, vmpstr...@chromium.org, wfh+...@chromium.org

Mike Frysinger abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

PCScan: Assume GigaCage is always enabled on 64bit [chromium/src : main]

Anton Bikineev (Gerrit)

Anton Bikineev (Gerrit)

Michael Lippautz (Gerrit)

Michael Lippautz (Gerrit)

Bartek Nowierski (Gerrit)

Kentaro Hara (Gerrit)

Mike Frysinger (Gerrit)

Mike Frysinger abandoned this change

Related details