[handles] Migration to direct handles, part 2 [v8/v8 : main]
0 views
Skip to first unread message
Nikolaos Papaspyrou (Gerrit)
Jun 7, 2024, 4:11:27 AMJun 7
to Omer Katz, Michael Lippautz, V8 LUCI CQ, Hannes Payer, jgrube...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz and Omer Katz
Nikolaos Papaspyrou voted and added 3 comments![]( "Open in Gerrit")
Votes added by Nikolaos Papaspyrou
| Commit-Queue | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Nikolaos Papaspyrou . unresolved
All changes in this CL should be trivial.
- Replacements `s/Handle/DirectHandle/` (mostly by the tool, some manually)
- Replacements `s/handle/direct_handle/`
- Replacements `s/OpenHandle/OpenDirectHandle/`
- Two explicit `IndirectHandle`, marked with comments
- Simplified handle initializations, e.g. `auto h = DirectHandle<T>::cast(...);` or `DirectHandle<T> h(obj, isolate);`
File src/builtins/builtins-callsite.cc
Line 26, Patchset 1:
auto frame = IndirectHandle<CallSiteInfo>::cast(it.GetDataValue())Nikolaos Papaspyrou . unresolved
This is to prevent the tool from trying to change the macro.
It will be reconsidered.
File src/builtins/builtins-utils.h
Line 161, Patchset 1:
auto name = IndirectHandle<Type>::cast(args.receiver())Nikolaos Papaspyrou . unresolved
This is to prevent the tool from trying to change the macro.
It will be reconsidered.
Related details
Attention is currently required from:
- Michael Lippautz
- Omer Katz
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Jun 7, 2024, 5:32:32 AMJun 7
to Nikolaos Papaspyrou, Omer Katz, V8 LUCI CQ, Hannes Payer, jgrube...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nikolaos Papaspyrou and Omer Katz
Michael Lippautz voted and added 3 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
3 comments
Patchset-level comments
Michael Lippautz . resolved
lgtm
File src/builtins/builtins-callsite.cc
Line 26, Patchset 1:
auto frame = IndirectHandle<CallSiteInfo>::cast(it.GetDataValue())Nikolaos Papaspyrou . resolved
This is to prevent the tool from trying to change the macro.
It will be reconsidered.
Michael Lippautz
Acknowledged
File src/builtins/builtins-utils.h
Line 161, Patchset 1:
auto name = IndirectHandle<Type>::cast(args.receiver())Nikolaos Papaspyrou . resolved
This is to prevent the tool from trying to change the macro.
It will be reconsidered.
Attention is currently required from:
- Nikolaos Papaspyrou
- Omer Katz
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Jun 10, 2024, 5:29:47 AMJun 10
to Nikolaos Papaspyrou, Michael Lippautz, V8 LUCI CQ, Hannes Payer, jgrube...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nikolaos Papaspyrou
Omer Katz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Omer Katz
| Code-Review | +1 |
1 comment
Patchset-level comments
Omer Katz . resolved
lgtm
Related details
Attention is currently required from:
- Nikolaos Papaspyrou
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolaos Papaspyrou (Gerrit)
Jun 10, 2024, 5:44:26 AMJun 10
to Omer Katz, Michael Lippautz, V8 LUCI CQ, Hannes Payer, jgrube...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Nikolaos Papaspyrou added 1 comment![]( "Open in Gerrit")
Patchset-level comments
All changes in this CL should be trivial.
- Replacements `s/Handle/DirectHandle/` (mostly by the tool, some manually)
- Replacements `s/handle/direct_handle/`
- Replacements `s/OpenHandle/OpenDirectHandle/`
- Two explicit `IndirectHandle`, marked with comments
- Simplified handle initializations, e.g. `auto h = DirectHandle<T>::cast(...);` or `DirectHandle<T> h(obj, isolate);`
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolaos Papaspyrou (Gerrit)
Jun 10, 2024, 5:44:40 AMJun 10
to Omer Katz, Michael Lippautz, V8 LUCI CQ, Hannes Payer, jgrube...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
Nikolaos Papaspyrou voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jun 10, 2024, 6:54:01 AMJun 10
to Nikolaos Papaspyrou, Omer Katz, Michael Lippautz, Hannes Payer, jgrube...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, pthier...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[handles] Migration to direct handles, part 2
This CL migrates a large number of handles to direct handles. The
changes are only relevant for builds with v8_enable_direct_handle=true.
Affected source directories: asmjs, builtins, compiler-dispatcher,
heap, json, numbers, regexp, runtime, snapshot, strings.
Bug: 42203211
Change-Id: Id0e6e17a1ef45e3a98905db927c4836e9a640ccf
Cq-Include-Trybots: luci.v8.try:v8_linux64_css_dbg
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Nikolaos Papaspyrou <niko...@chromium.org>
Reviewed-by: Omer Katz <omer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#94332}
Files:
- M src/asmjs/asm-js.cc
- M src/asmjs/asm-js.h
- M src/builtins/accessors.cc
- M src/builtins/accessors.h
- M src/builtins/builtins-api.cc
- M src/builtins/builtins-array.cc
- M src/builtins/builtins-arraybuffer.cc
- M src/builtins/builtins-async-module.cc
- M src/builtins/builtins-atomics-synchronization.cc
- M src/builtins/builtins-callsite.cc
- M src/builtins/builtins-console.cc
- M src/builtins/builtins-dataview.cc
- M src/builtins/builtins-date.cc
- M src/builtins/builtins-disposable-stack.cc
- M src/builtins/builtins-function.cc
- M src/builtins/builtins-global.cc
- M src/builtins/builtins-json.cc
- M src/builtins/builtins-number.cc
- M src/builtins/builtins-regexp.cc
- M src/builtins/builtins-shadow-realm.cc
- M src/builtins/builtins-sharedarraybuffer.cc
- M src/builtins/builtins-struct.cc
- M src/builtins/builtins-symbol.cc
- M src/builtins/builtins-temporal.cc
- M src/builtins/builtins-trace.cc
- M src/builtins/builtins-typed-array.cc
- M src/builtins/builtins-utils.h
- M src/builtins/builtins.cc
- M src/builtins/builtins.h
- M src/builtins/constants-table-builder.cc
- M src/builtins/constants-table-builder.h
- M src/builtins/setup-builtins-internal.cc
- M src/compiler-dispatcher/lazy-compile-dispatcher.cc
- M src/compiler-dispatcher/lazy-compile-dispatcher.h
- M src/compiler-dispatcher/optimizing-compile-dispatcher.cc
- M src/heap/cppgc-js/cpp-snapshot.cc
- M src/heap/factory-base.cc
- M src/heap/factory-base.h
- M src/heap/factory-inl.h
- M src/heap/factory.cc
- M src/heap/factory.h
- M src/heap/heap.cc
- M src/heap/heap.h
- M src/heap/memory-measurement.cc
- M src/heap/setup-heap-internal.cc
- M src/json/json-parser.cc
- M src/json/json-parser.h
- M src/json/json-stringifier.cc
- M src/numbers/conversions.cc
- M src/numbers/conversions.h
- M src/numbers/math-random.cc
- M src/numbers/math-random.h
- M src/regexp/experimental/experimental-interpreter.cc
- M src/regexp/experimental/experimental.cc
- M src/regexp/experimental/experimental.h
- M src/regexp/regexp-bytecode-peephole.cc
- M src/regexp/regexp-bytecode-peephole.h
- M src/regexp/regexp-compiler.cc
- M src/regexp/regexp-compiler.h
- M src/regexp/regexp-interpreter.cc
- M src/regexp/regexp-interpreter.h
- M src/regexp/regexp-macro-assembler.cc
- M src/regexp/regexp-macro-assembler.h
- M src/regexp/regexp-parser.cc
- M src/regexp/regexp-parser.h
- M src/regexp/regexp-utils.cc
- M src/regexp/regexp-utils.h
- M src/regexp/regexp.cc
- M src/regexp/regexp.h
- M src/runtime/runtime-array.cc
- M src/runtime/runtime-bigint.cc
- M src/runtime/runtime-classes.cc
- M src/runtime/runtime-collections.cc
- M src/runtime/runtime-compiler.cc
- M src/runtime/runtime-debug.cc
- M src/runtime/runtime-forin.cc
- M src/runtime/runtime-function.cc
- M src/runtime/runtime-futex.cc
- M src/runtime/runtime-generator.cc
- M src/runtime/runtime-internal.cc
- M src/runtime/runtime-intl.cc
- M src/runtime/runtime-literals.cc
- M src/runtime/runtime-module.cc
- M src/runtime/runtime-object.cc
- M src/runtime/runtime-promise.cc
- M src/runtime/runtime-regexp.cc
- M src/runtime/runtime-scopes.cc
- M src/runtime/runtime-shadow-realm.cc
- M src/runtime/runtime-strings.cc
- M src/runtime/runtime-symbol.cc
- M src/runtime/runtime-temporal.cc
- M src/runtime/runtime-test-wasm.cc
- M src/runtime/runtime-test.cc
- M src/runtime/runtime-typedarray.cc
- M src/runtime/runtime-wasm.cc
- M src/runtime/runtime-weak-refs.cc
- M src/snapshot/code-serializer.cc
- M src/snapshot/code-serializer.h
- M src/snapshot/deserializer.cc
- M src/snapshot/deserializer.h
- M src/snapshot/object-deserializer.cc
- M src/snapshot/references.h
- M src/snapshot/serializer.cc
- M src/snapshot/serializer.h
- M src/snapshot/snapshot.cc
- M src/snapshot/snapshot.h
- M src/snapshot/startup-deserializer.cc
- M src/snapshot/startup-serializer.cc
- M src/strings/uri.cc
Change size: XL
Delta: 109 files changed, 985 insertions(+), 937 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Omer Katz, +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages