[profiler] Add start and end position for SharedFunctionInfos [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
Mar 31, 2026, 7:14:26 AMMar 31
to V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 31, 2026, 7:24:46 AMMar 31
to Michael Lippautz, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Dominik Inführ . resolved
PTAL
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 31, 2026, 7:29:54 AMMar 31
to Dominik Inführ, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Attention needed from Dominik Inführ
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 31, 2026, 7:31:08 AMMar 31
to Michael Lippautz, V8 LUCI CQ, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Dominik Inführ . resolved
Thanks for the quick review!
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 31, 2026, 7:49:35 AMMar 31
to Dominik Inführ, Michael Lippautz, devtools-...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[profiler] Add start and end position for SharedFunctionInfos
This enables us to check which function in the script that
SharedFunctionInfo corresponds to.
Since start and end position are simple integers, this CL also adds
a new method AddIntEdge. This method we can also use to emit integer
fields for objects in future CLs.
Bug: 497855658
Change-Id: Idc3ced4deaa10400a71cf4c634b394e818228576
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106173}
Files:
- M src/profiler/heap-snapshot-generator.cc
- M src/profiler/heap-snapshot-generator.h
- M test/unittests/BUILD.gn
- M test/unittests/heap/cppgc-js/unified-heap-snapshot-unittest.cc
- M test/unittests/profiler/heap-snapshot-unittest.cc
- A test/unittests/profiler/heap-snapshot-utils.cc
- A test/unittests/profiler/heap-snapshot-utils.h
Change size: M
Delta: 7 files changed, 150 insertions(+), 28 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages