[Layout] Testing parallel layout [chromium/src : main]

0 views
Skip to first unread message

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Feb 8, 2026, 6:45:02 PMFeb 8
to Kurt Catti-Schmidt, Stephen Chenney, David Bokan, Dirk Schulze, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-revi...@chromium.org, drott+bl...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt

Message from chrom...@appspot.gserviceaccount.com

😿 Job mac-m1_mini_2020-perf-pgo/blink_perf.layout failed.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/137d57ef710000

Open in Gerrit

Related details

Attention is currently required from:
  • Kurt Catti-Schmidt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5c30fcf369e7905935d59d8de6c6a01c2b3769b2
Gerrit-Change-Number: 7554678
Gerrit-PatchSet: 3
Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Comment-Date: Sun, 08 Feb 2026 23:44:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Omer Katz (Gerrit)

unread,
Feb 9, 2026, 3:52:14 AMFeb 9
to Kurt Catti-Schmidt, Stephen Chenney, David Bokan, Dirk Schulze, Kentaro Hara, AyeAye, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-revi...@chromium.org, drott+bl...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt

Omer Katz added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Omer Katz . resolved

Hi Kurt. I'm afraid the GC related changes in this CL are unsafe. There would be more issues than just concurrent allocations, and there is no easy fix for them (e.g. the concurrent accesses are also unsafe, as well as any raw pointers you'd hold on stack). Please avoid making changes to the GC.

Open in Gerrit

Related details

Attention is currently required from:
  • Kurt Catti-Schmidt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5c30fcf369e7905935d59d8de6c6a01c2b3769b2
Gerrit-Change-Number: 7554678
Gerrit-PatchSet: 4
Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Omer Katz <omer...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 08:52:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Feb 9, 2026, 4:14:19 AMFeb 9
to Kurt Catti-Schmidt, Omer Katz, Stephen Chenney, David Bokan, Dirk Schulze, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-revi...@chromium.org, drott+bl...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf-pgo/speedometer3 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12b2de83710000

Gerrit-Comment-Date: Mon, 09 Feb 2026 09:14:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,
Feb 9, 2026, 4:59:20 AMFeb 9
to Kurt Catti-Schmidt, Omer Katz, Stephen Chenney, David Bokan, Dirk Schulze, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-revi...@chromium.org, drott+bl...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m1_mini_2020-perf-pgo/blink_perf.layout complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1195bac4f10000

Gerrit-Comment-Date: Mon, 09 Feb 2026 09:59:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kurt Catti-Schmidt (Gerrit)

unread,
Feb 9, 2026, 11:09:11 AMFeb 9
to Omer Katz, Stephen Chenney, David Bokan, Dirk Schulze, Kentaro Hara, AyeAye, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-revi...@chromium.org, drott+bl...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Omer Katz

Kurt Catti-Schmidt added 1 comment

Patchset-level comments
Omer Katz . resolved

Hi Kurt. I'm afraid the GC related changes in this CL are unsafe. There would be more issues than just concurrent allocations, and there is no easy fix for them (e.g. the concurrent accesses are also unsafe, as well as any raw pointers you'd hold on stack). Please avoid making changes to the GC.

Kurt Catti-Schmidt

That's what I figured, this is just an experiment to see if it makes any difference performance-wise. Right now, it's looking like the answer is no, as it loses the caching the current implementation achieves. I don't plan on landing this.

Open in Gerrit

Related details

Attention is currently required from:
  • Omer Katz
Gerrit-Attention: Omer Katz <omer...@chromium.org>
Gerrit-Comment-Date: Mon, 09 Feb 2026 16:08:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Omer Katz <omer...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Omer Katz (Gerrit)

unread,
Feb 9, 2026, 3:27:00 PMFeb 9
to Kurt Catti-Schmidt, Stephen Chenney, David Bokan, Dirk Schulze, Kentaro Hara, AyeAye, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-revi...@chromium.org, drott+bl...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kurt Catti-Schmidt

Omer Katz added 1 comment

Patchset-level comments
Omer Katz . resolved

Hi Kurt. I'm afraid the GC related changes in this CL are unsafe. There would be more issues than just concurrent allocations, and there is no easy fix for them (e.g. the concurrent accesses are also unsafe, as well as any raw pointers you'd hold on stack). Please avoid making changes to the GC.

Kurt Catti-Schmidt

That's what I figured, this is just an experiment to see if it makes any difference performance-wise. Right now, it's looking like the answer is no, as it loses the caching the current implementation achieves. I don't plan on landing this.

Omer Katz

Thanks. Just FYI: Even if this experiment improved performance, making something like GC-safe would afaik be a multiple-quarter project requiring changes to the GC itself. I don't think this can be resolved solely on the blink side.

Open in Gerrit

Related details

Attention is currently required from:
  • Kurt Catti-Schmidt
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 20:26:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Omer Katz <omer...@chromium.org>
Comment-In-Reply-To: Kurt Catti-Schmidt <ksc...@microsoft.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kurt Catti-Schmidt (Gerrit)

unread,
Feb 9, 2026, 4:38:49 PMFeb 9
to Omer Katz, Stephen Chenney, David Bokan, Dirk Schulze, Kentaro Hara, AyeAye, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-revi...@chromium.org, drott+bl...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Omer Katz

Kurt Catti-Schmidt added 1 comment

Patchset-level comments
Omer Katz . resolved

Hi Kurt. I'm afraid the GC related changes in this CL are unsafe. There would be more issues than just concurrent allocations, and there is no easy fix for them (e.g. the concurrent accesses are also unsafe, as well as any raw pointers you'd hold on stack). Please avoid making changes to the GC.

Kurt Catti-Schmidt

That's what I figured, this is just an experiment to see if it makes any difference performance-wise. Right now, it's looking like the answer is no, as it loses the caching the current implementation achieves. I don't plan on landing this.

Omer Katz

Thanks. Just FYI: Even if this experiment improved performance, making something like GC-safe would afaik be a multiple-quarter project requiring changes to the GC itself. I don't think this can be resolved solely on the blink side.

Kurt Catti-Schmidt

Gotcha, I will abandon, thanks for the heads-up!

Open in Gerrit

Related details

Attention is currently required from:
  • Omer Katz
Gerrit-Attention: Omer Katz <omer...@chromium.org>
Gerrit-Comment-Date: Mon, 09 Feb 2026 21:38:40 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Kurt Catti-Schmidt (Gerrit)

unread,
Feb 9, 2026, 4:39:01 PMFeb 9
to Omer Katz, Stephen Chenney, David Bokan, Dirk Schulze, Kentaro Hara, AyeAye, chrom...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Javier Fernandez, blink-re...@chromium.org, oilpan-rev...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, fmalit...@chromium.org, kouhe...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-revi...@chromium.org, drott+bl...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org

Kurt Catti-Schmidt abandoned this change.

View Change

Abandoned Needs major changes in GC to be feasible

Kurt Catti-Schmidt abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages