[parser] Deduplicate object literal property deduplication [v8/v8 : main]

0 views
Skip to first unread message

Leszek Swirski (Gerrit)

unread,
Apr 1, 2026, 6:49:09 AMApr 1
to Hannes Payer, Igor Sheludko, V8 LUCI CQ, AyeAye, mlippau...@chromium.org, v8-risc...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, verwaes...@chromium.org, dmercadi...@chromium.org, hongcha...@chromium.org, oilpan-r...@chromium.org, cbruni...@chromium.org, was...@google.com, v8-flag...@chromium.org, victorgo...@chromium.org, v8-ppc...@googlegroups.com, rtoy+...@chromium.org, devtools-...@chromium.org, marja...@chromium.org, v8-re...@googlegroups.com
Attention needed from Igor Sheludko

Leszek Swirski voted and added 1 comment

Votes added by Leszek Swirski

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Leszek Swirski . resolved

ready for review

Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ifc77b253e617d98600da3902c95df6675c5592f8
Gerrit-Change-Number: 7718738
Gerrit-PatchSet: 5
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 10:49:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Igor Sheludko (Gerrit)

unread,
Apr 1, 2026, 10:38:32 AMApr 1
to Leszek Swirski, Hannes Payer, V8 LUCI CQ, AyeAye, mlippau...@chromium.org, v8-risc...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, verwaes...@chromium.org, dmercadi...@chromium.org, hongcha...@chromium.org, oilpan-r...@chromium.org, cbruni...@chromium.org, was...@google.com, v8-flag...@chromium.org, victorgo...@chromium.org, v8-ppc...@googlegroups.com, rtoy+...@chromium.org, devtools-...@chromium.org, marja...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Igor Sheludko . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ifc77b253e617d98600da3902c95df6675c5592f8
Gerrit-Change-Number: 7718738
Gerrit-PatchSet: 5
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 14:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Apr 1, 2026, 10:40:24 AMApr 1
to Leszek Swirski, Igor Sheludko, Hannes Payer, AyeAye, mlippau...@chromium.org, v8-risc...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, verwaes...@chromium.org, dmercadi...@chromium.org, hongcha...@chromium.org, oilpan-r...@chromium.org, cbruni...@chromium.org, was...@google.com, v8-flag...@chromium.org, victorgo...@chromium.org, v8-ppc...@googlegroups.com, rtoy+...@chromium.org, devtools-...@chromium.org, marja...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[parser] Deduplicate object literal property deduplication

Refactor ObjectLiteral property deduplication in CalculateEmitStore to
also handle data property deduplication, by keeping track of the first
and last duplicates through some index weaving. This eliminates the need
for a separate boilerplate-specific deduplication pass.
Bug: 485823015
Change-Id: Ifc77b253e617d98600da3902c95df6675c5592f8
Auto-Submit: Leszek Swirski <les...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106214}
Files:
  • M src/ast/ast.cc
  • M src/ast/ast.h
  • M src/ast/prettyprinter.cc
Change size: L
Delta: 3 files changed, 184 insertions(+), 220 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Igor Sheludko
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ifc77b253e617d98600da3902c95df6675c5592f8
Gerrit-Change-Number: 7718738
Gerrit-PatchSet: 6
Gerrit-Owner: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages