[GC] Support late heap check and force last resort GC for oilpan [v8/v8 : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Oct 1, 2025, 2:28:45 PMOct 1
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Inführ
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib5a890d2dc69bee34b9b2e8dd9dff08c07ab54d8
Gerrit-Change-Number: 7002462
Gerrit-PatchSet: 2
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Dominik Inführ <dinf...@google.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 18:28:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Dominik Inführ (Gerrit)

unread,
Oct 2, 2025, 5:48:40 AMOct 2
to Etienne Pierre-Doray, Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ and Etienne Pierre-Doray

Dominik Inführ added 1 comment

File src/heap/cppgc/object-allocator.cc
Line 171, Patchset 2 (Latest): GCConfig::FreeMemoryHandling::kLastResort};
Dominik Inführ . unresolved

This would trigger the "last resort" GC (or actually only parts of it) the first time we encounter an allocation failure IIUC. That's likely too agressive. I would prefer being uniform with JS here and reuse the same logic: Doing 2 lightweight GCs first and if that's not enough call CollectAllAvailableGarbage(kLastResort). cppgc could have its own implementation of the retry implementation imho if reusing the implementation from JS isn't feasible (or too tricky).

Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Inführ
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib5a890d2dc69bee34b9b2e8dd9dff08c07ab54d8
    Gerrit-Change-Number: 7002462
    Gerrit-PatchSet: 2
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Dominik Inführ <dinf...@google.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-CC: Dominik Inführ <dinf...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-Attention: Dominik Inführ <dinf...@google.com>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Oct 2025 09:48:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Michael Lippautz (Gerrit)

    unread,
    Oct 2, 2025, 5:51:30 AMOct 2
    to Etienne Pierre-Doray, Dominik Inführ, Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
    Attention needed from Dominik Inführ and Etienne Pierre-Doray

    Michael Lippautz added 1 comment

    Commit Message
    Line 11, Patchset 2 (Latest):
    Michael Lippautz . unresolved

    This needs a tracking bug.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dominik Inführ
    • Etienne Pierre-Doray
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib5a890d2dc69bee34b9b2e8dd9dff08c07ab54d8
    Gerrit-Change-Number: 7002462
    Gerrit-PatchSet: 2
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Dominik Inführ <dinf...@google.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-CC: Dominik Inführ <dinf...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-CC: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Attention: Dominik Inführ <dinf...@google.com>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Oct 2025 09:51:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages