Fix some compile failures under C++23 [v8/v8 : main]
0 views
Skip to first unread message
David Benjamin (Gerrit)
Oct 1, 2025, 4:47:16 PMOct 1
to Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Hannes Payer
David Benjamin voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Hannes Payer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Oct 2, 2025, 3:49:23 AMOct 2
to David Benjamin, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from David Benjamin and Hannes Payer
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- David Benjamin
- Hannes Payer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Benjamin (Gerrit)
Oct 2, 2025, 10:06:13 AMOct 2
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Hannes Payer
David Benjamin voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Hannes Payer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Benjamin (Gerrit)
Oct 2, 2025, 10:09:27 AMOct 2
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Hannes Payer
David Benjamin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Michael Lippautz . resolved
Saw this fly by, thanks!
David Benjamin
(Thanks! Apparently I need two reviewers in V8 anyway.)
Related details
Attention is currently required from:
- Hannes Payer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Oct 2, 2025, 10:11:45 AMOct 2
to David Benjamin, Dominik Inführ, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from David Benjamin, Dominik Inführ and Hannes Payer
Michael Lippautz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- David Benjamin
- Dominik Inführ
- Hannes Payer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Vianna (Gerrit)
Oct 6, 2025, 10:00:13 AMOct 6
to David Benjamin, Dominik Inführ, Michael Lippautz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Dominik Inführ and Hannes Payer
Victor Vianna added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Victor Vianna . resolved
Gentle ping for dinfuehr@, thanks. The CL is mostly reordering declarations, so hopefully it's fast to review.
Related details
Attention is currently required from:
- Dominik Inführ
- Hannes Payer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Oct 6, 2025, 10:43:27 AMOct 6
to David Benjamin, Michael Lippautz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from David Benjamin and Hannes Payer
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Dominik Inführ . resolved
Sorry I assumed it was already because you got LGTM already, LGTM from me as well
Related details
Attention is currently required from:
- David Benjamin
- Hannes Payer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Benjamin (Gerrit)
Oct 6, 2025, 11:12:04 AMOct 6
to Dominik Inführ, Michael Lippautz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Dominik Inführ and Hannes Payer
David Benjamin voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Benjamin
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Dominik Inführ
- Hannes Payer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Benjamin (Gerrit)
Oct 6, 2025, 11:34:58 AMOct 6
to Dominik Inführ, Michael Lippautz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Dominik Inführ and Hannes Payer
David Benjamin voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
David Benjamin (Gerrit)
Oct 6, 2025, 3:17:44 PMOct 6
to Dominik Inführ, Michael Lippautz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Dominik Inführ and Hannes Payer
David Benjamin voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Benjamin
| Commit-Queue | +2 |
1 comment
File src/heap/heap.cc
Line 144, Patchset 1 (Latest):
David Benjamin . resolved
(I double-checked these are equal to make sure there wasn't a mismerge.)
David Benjamin (Gerrit)
Oct 6, 2025, 5:30:41 PMOct 6
to Dominik Inführ, Michael Lippautz, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Dominik Inführ and Hannes Payer
David Benjamin voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Michael Lippautz (Gerrit)
Oct 7, 2025, 2:07:55 AMOct 7
to David Benjamin, Dominik Inführ, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from David Benjamin, Dominik Inführ and Hannes Payer
Michael Lippautz voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- David Benjamin
- Dominik Inführ
- Hannes Payer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Oct 7, 2025, 10:21:14 AM (14 days ago) Oct 7
to David Benjamin, Dominik Inführ, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from David Benjamin, Dominik Inführ and Hannes Payer
Michael Lippautz voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- David Benjamin
- Dominik Inführ
- Hannes Payer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Oct 7, 2025, 12:16:08 PM (14 days ago) Oct 7
to David Benjamin, Dominik Inführ, Victor Vianna, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from David Benjamin, Dominik Inführ, Hannes Payer and Victor Vianna
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Michael Lippautz . resolved
Let me try to submit manually here. We have seen `linux-rel` to be flaky from time to time.
Related details
Attention is currently required from:
- David Benjamin
- Dominik Inführ
- Hannes Payer
- Victor Vianna
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Oct 7, 2025, 12:16:11 PM (14 days ago) Oct 7
to David Benjamin, Dominik Inführ, Victor Vianna, V8 LUCI CQ, Hannes Payer, devtools-...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Michael Lippautz submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix some compile failures under C++23
As a side effect of making ~unique_ptr<T> constexpr and how Clang
implements things, T must be complete at the point where the template is
instantiated. A forward declaration, with the type filled in later,
isn't sufficient.
One side effect is that inner types often need to be defined earlier, if
the constructor would depend on them by way of unique_ptr.
Bug: 388068055
Change-Id: I333604510252de35bdadce1ef3c2fe52ecb288e8
Auto-Submit: David Benjamin <davi...@chromium.org>
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102981}
Files:
- M src/heap/concurrent-marking.cc
- M src/heap/cppgc-js/cpp-snapshot.cc
- M src/heap/heap.cc
- M src/inspector/inspected-context.cc
- M src/wasm/module-compiler.cc
Change size: L
Delta: 5 files changed, 194 insertions(+), 183 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz, +1 by Dominik Inführ
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages