[runtime] Prevent SharedFunctionInfo from being returned from IC [v8/v8 : main]
0 views
Skip to first unread message
Raphael Herouart (Gerrit)
Dec 18, 2025, 6:30:26 AM (11 days ago) Dec 18
to Hannes Payer, AyeAye, Igor Sheludko, Leszek Swirski, V8 LUCI CQ, oilpan-r...@chromium.org, jgrube...@chromium.org, was...@google.com, leszek...@chromium.org, pthier...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, victorgo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Igor Sheludko and Leszek Swirski
Raphael Herouart added 1 comment![]( "Open in Gerrit")
File src/runtime/runtime-literals.cc
Line 839, Patchset 6:
DirectHandle<FeedbackCell> feedback_cell(Igor Sheludko . resolved
Raphael HerouartPlease add a comment for future readers about why are we doing this.
Done
Related details
Attention is currently required from:
- Igor Sheludko
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Dec 18, 2025, 6:31:34 AM (11 days ago) Dec 18
to Raphael Herouart, Hannes Payer, AyeAye, Leszek Swirski, V8 LUCI CQ, oilpan-r...@chromium.org, jgrube...@chromium.org, was...@google.com, leszek...@chromium.org, pthier...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, victorgo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski and Raphael Herouart
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Leszek Swirski
- Raphael Herouart
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Raphael Herouart (Gerrit)
Dec 18, 2025, 6:34:32 AM (11 days ago) Dec 18
to Igor Sheludko, Hannes Payer, AyeAye, Leszek Swirski, V8 LUCI CQ, oilpan-r...@chromium.org, jgrube...@chromium.org, was...@google.com, leszek...@chromium.org, pthier...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, victorgo...@chromium.org, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Raphael Herouart voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 18, 2025, 7:04:51 AM (11 days ago) Dec 18
to Raphael Herouart, Igor Sheludko, Hannes Payer, AyeAye, Leszek Swirski, oilpan-r...@chromium.org, jgrube...@chromium.org, was...@google.com, leszek...@chromium.org, pthier...@chromium.org, verwaes...@chromium.org, mlippau...@chromium.org, victorgo...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[runtime] Prevent SharedFunctionInfo from being returned from IC
SetPrototypeProperties should not assigned a Shared
Function Info to an existing property
Bug: 469523961
Bug: 449885256
Change-Id: I4d075302c4d1a5e35f92bb8b92bdf814aae6723f
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Raphael Herouart <rher...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104405}
Files:
- M src/runtime/runtime-literals.cc
Change size: S
Delta: 1 file changed, 16 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Igor Sheludko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages