Reland "[heap] Add notes for preempting/finishing jobs" [v8/v8 : main]

0 views
Skip to first unread message

Omer Katz (Gerrit)

unread,
Dec 18, 2025, 3:51:15 AM (11 days ago) Dec 18
to Michael Lippautz, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Attention needed from Michael Lippautz

Omer Katz added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Omer Katz . resolved

ptal. reland as is.

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5c2d8502800a274958578018454f0a8c8222c0fe
Gerrit-Change-Number: 7269391
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 08:51:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Dec 18, 2025, 3:52:38 AM (11 days ago) Dec 18
to Omer Katz, V8 LUCI CQ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org
Attention needed from Omer Katz

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Omer Katz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5c2d8502800a274958578018454f0a8c8222c0fe
Gerrit-Change-Number: 7269391
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Omer Katz <omer...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 08:52:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Omer Katz (Gerrit)

unread,
Dec 18, 2025, 3:56:36 AM (11 days ago) Dec 18
to Michael Lippautz, V8 LUCI CQ, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org

Omer Katz voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5c2d8502800a274958578018454f0a8c8222c0fe
Gerrit-Change-Number: 7269391
Gerrit-PatchSet: 1
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 08:56:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Dec 18, 2025, 4:27:32 AM (11 days ago) Dec 18
to Omer Katz, Michael Lippautz, AyeAye, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
Reland "[heap] Add notes for preempting/finishing jobs"

This is a reland of commit d61897cc21fe643b7378f538464dae866fb4841b

Original change's description:
> [heap] Add notes for preempting/finishing jobs
>
> Help distinguish on a trace which concurrent jobs end because of
> preemption and which end because they run out of work.
> Notes are added only to jobs that can yield.
>
> Bug: 42204085
> Change-Id: If3064174cc6ccfda50230b906589f456983e46a9
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7261997
> Reviewed-by: Michael Lippautz <mlip...@chromium.org>
> Commit-Queue: Omer Katz <omer...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#104328}
Bug: 42204085
Change-Id: I5c2d8502800a274958578018454f0a8c8222c0fe
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Omer Katz <omer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104397}
Files:
  • M src/heap/array-buffer-sweeper.cc
  • M src/heap/concurrent-marking.cc
  • M src/heap/cppgc/concurrent-marker.cc
  • M src/heap/cppgc/stats-collector.h
  • M src/heap/cppgc/sweeper.cc
  • M src/heap/scavenger.cc
  • M src/heap/sweeper.cc
  • M src/heap/sweeper.h
Change size: S
Delta: 8 files changed, 34 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5c2d8502800a274958578018454f0a8c8222c0fe
Gerrit-Change-Number: 7269391
Gerrit-PatchSet: 2
Gerrit-Owner: Omer Katz <omer...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages