Revert "cppgc: Mitigate Oilpan VA exhaustions" [v8/v8 : main]
0 views
Skip to first unread message
Rubber Stamper (Gerrit)
Sep 25, 2025, 5:58:07 PMSep 25
to Rezvan Mahdavi Hezaveh, Michael Lippautz, Anton Bikineev, V8 LUCI CQ, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Anton Bikineev and Michael Lippautz
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Anton Bikineev
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Sep 25, 2025, 5:58:52 PMSep 25
to Rubber Stamper, Michael Lippautz, Anton Bikineev, V8 LUCI CQ, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Anton Bikineev and Michael Lippautz
Rezvan Mahdavi Hezaveh voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Anton Bikineev
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Sep 25, 2025, 5:58:58 PMSep 25
to Rubber Stamper, Michael Lippautz, Anton Bikineev, V8 LUCI CQ, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Anton Bikineev and Michael Lippautz
Rezvan Mahdavi Hezaveh voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
V8 LUCI CQ (Gerrit)
Sep 25, 2025, 5:59:04 PMSep 25
to Rezvan Mahdavi Hezaveh, Rubber Stamper, Michael Lippautz, Anton Bikineev, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "cppgc: Mitigate Oilpan VA exhaustions"
This reverts commit 96b05a7a1c360d9fedc05f038fea17ebff9b4295.
Reason for revert: bisect: https://chromium-review.googlesource.com/c/chromium/src/+/6985125
flagged CL in relation to the following failure
https://ci.chromium.org/ui/p/chromium/builders/try/fuchsia-x64-cast-receiver-rel/1191024/overview
Original change's description:
> cppgc: Mitigate Oilpan VA exhaustions
>
> Currently, Oilpan tries to overreserve the cage to make sure that the
> LSB of the masked out pointer part is 1. It does it by allocating twice
> the actual useful reservation size and twice the needed alignment
> (16GB). This causes the platform allocator to mmap 64GB - kPageSize,
> which may often fail on systems with low reservation limits
> (VA_BITS==39), especially with the presence of the V8 Sandbox and
> the out-of-line PA metadata.
>
> The CL aims to mitigate it by using the opportunistic strategy:
> 1) first, relax the requirement of the alignment to be twice the needed
> alignment. Instead, just pick the needed half. This will try to
> mmap 48GB - kPageSize.
> 2) if this fails, try to allocate the actual useful reservation size
> (16GB) for a few tries until the LSB of the masked out part is 1.
>
> Bug: 444613347
> Change-Id: Idea29fd019d75e9904648bcdcdde8754b3475ac1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6973464
> Commit-Queue: Anton Bikineev <biki...@chromium.org>
> Reviewed-by: Michael Lippautz <mlip...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#102748}
Bug: 444613347
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ib2bcb665087404506b64719aa451f580e4305fe5
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Auto-Submit: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Owners-Override: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102774}
Files:
- M src/heap/cppgc/caged-heap.cc
- M src/heap/cppgc/caged-heap.h
- M src/heap/cppgc/virtual-memory.cc
- M src/heap/cppgc/virtual-memory.h
Change size: M
Delta: 4 files changed, 48 insertions(+), 119 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Sep 25, 2025, 5:59:06 PMSep 25
to V8 LUCI CQ, Rezvan Mahdavi Hezaveh, Michael Lippautz, Anton Bikineev, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
Rubber Stamper voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages