Revert "cppgc: Mitigate Oilpan VA exhaustions" [v8/v8 : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Sep 25, 2025, 5:58:07 PM (5 days ago) Sep 25
to Rezvan Mahdavi Hezaveh, Michael Lippautz, Anton Bikineev, V8 LUCI CQ, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Anton Bikineev and Michael Lippautz

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Anton Bikineev
  • Michael Lippautz
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib2bcb665087404506b64719aa451f580e4305fe5
Gerrit-Change-Number: 6985879
Gerrit-PatchSet: 1
Gerrit-Owner: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Anton Bikineev <biki...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Anton Bikineev <biki...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 21:58:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Rezvan Mahdavi Hezaveh (Gerrit)

unread,
Sep 25, 2025, 5:58:52 PM (5 days ago) Sep 25
to Rubber Stamper, Michael Lippautz, Anton Bikineev, V8 LUCI CQ, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Anton Bikineev and Michael Lippautz

Rezvan Mahdavi Hezaveh voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anton Bikineev
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib2bcb665087404506b64719aa451f580e4305fe5
Gerrit-Change-Number: 6985879
Gerrit-PatchSet: 1
Gerrit-Owner: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Anton Bikineev <biki...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Anton Bikineev <biki...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 21:58:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Rezvan Mahdavi Hezaveh (Gerrit)

unread,
Sep 25, 2025, 5:58:58 PM (5 days ago) Sep 25
to Rubber Stamper, Michael Lippautz, Anton Bikineev, V8 LUCI CQ, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org
Attention needed from Anton Bikineev and Michael Lippautz

Rezvan Mahdavi Hezaveh voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Thu, 25 Sep 2025 21:58:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Sep 25, 2025, 5:59:04 PM (5 days ago) Sep 25
to Rezvan Mahdavi Hezaveh, Rubber Stamper, Michael Lippautz, Anton Bikineev, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
Revert "cppgc: Mitigate Oilpan VA exhaustions"

This reverts commit 96b05a7a1c360d9fedc05f038fea17ebff9b4295.

Reason for revert: bisect: https://chromium-review.googlesource.com/c/chromium/src/+/6985125
flagged CL in relation to the following failure
https://ci.chromium.org/ui/p/chromium/builders/try/fuchsia-x64-cast-receiver-rel/1191024/overview

Original change's description:
> cppgc: Mitigate Oilpan VA exhaustions
>
> Currently, Oilpan tries to overreserve the cage to make sure that the
> LSB of the masked out pointer part is 1. It does it by allocating twice
> the actual useful reservation size and twice the needed alignment
> (16GB). This causes the platform allocator to mmap 64GB - kPageSize,
> which may often fail on systems with low reservation limits
> (VA_BITS==39), especially with the presence of the V8 Sandbox and
> the out-of-line PA metadata.
>
> The CL aims to mitigate it by using the opportunistic strategy:
> 1) first, relax the requirement of the alignment to be twice the needed
> alignment. Instead, just pick the needed half. This will try to
> mmap 48GB - kPageSize.
> 2) if this fails, try to allocate the actual useful reservation size
> (16GB) for a few tries until the LSB of the masked out part is 1.
>
> Bug: 444613347
> Change-Id: Idea29fd019d75e9904648bcdcdde8754b3475ac1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6973464
> Commit-Queue: Anton Bikineev <biki...@chromium.org>
> Reviewed-by: Michael Lippautz <mlip...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#102748}
Bug: 444613347
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ib2bcb665087404506b64719aa451f580e4305fe5
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Auto-Submit: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Owners-Override: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102774}
Files:
  • M src/heap/cppgc/caged-heap.cc
  • M src/heap/cppgc/caged-heap.h
  • M src/heap/cppgc/virtual-memory.cc
  • M src/heap/cppgc/virtual-memory.h
Change size: M
Delta: 4 files changed, 48 insertions(+), 119 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib2bcb665087404506b64719aa451f580e4305fe5
Gerrit-Change-Number: 6985879
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement

Rubber Stamper (Gerrit)

unread,
Sep 25, 2025, 5:59:06 PM (5 days ago) Sep 25
to V8 LUCI CQ, Rezvan Mahdavi Hezaveh, Michael Lippautz, Anton Bikineev, AyeAye, Hannes Payer, oilpan-r...@chromium.org, mlippau...@chromium.org

Rubber Stamper voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib2bcb665087404506b64719aa451f580e4305fe5
Gerrit-Change-Number: 6985879
Gerrit-PatchSet: 2
Gerrit-Owner: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Anton Bikineev <biki...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 21:59:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages