[blink] Switch wtf/hash_table_deleted_value_type to "blink" namespace [chromium/src : main]

0 views
Skip to first unread message

Ho Cheung (Gerrit)

unread,
Jul 19, 2025, 12:04:20 AMJul 19
to Hayato Ito, Chromium LUCI CQ, Luna Lu, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Dirk Schulze, Alexis Menard, Kentaro Hara, AyeAye, drott+bl...@chromium.org, aleventhal...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-revi...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, kyungjunle...@google.com, blink-revi...@chromium.org, francisjp...@google.com, nektar...@chromium.org, scheduler-...@chromium.org, jmedle...@chromium.org, abigailbk...@google.com, zol...@webkit.org, josiah...@chromium.org, chikamu...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, lucasrada...@google.com, dtseng...@chromium.org, yuzo+...@chromium.org
Attention needed from Hayato Ito

Ho Cheung added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Hayato Ito
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id63370ea50654fcdd342816066243e0750e0ebd6
Gerrit-Change-Number: 6771038
Gerrit-PatchSet: 1
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Hayato Ito <hay...@chromium.org>
Gerrit-Comment-Date: Sat, 19 Jul 2025 04:03:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ho Cheung (Gerrit)

unread,
Jul 21, 2025, 7:53:53 PMJul 21
to Kent Tamura, Chromium LUCI CQ, Luna Lu, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Dirk Schulze, Alexis Menard, Kentaro Hara, AyeAye, drott+bl...@chromium.org, aleventhal...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-revi...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, kyungjunle...@google.com, blink-revi...@chromium.org, francisjp...@google.com, nektar...@chromium.org, scheduler-...@chromium.org, jmedle...@chromium.org, abigailbk...@google.com, zol...@webkit.org, josiah...@chromium.org, chikamu...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, lucasrada...@google.com, dtseng...@chromium.org, yuzo+...@chromium.org
Attention needed from Kent Tamura

Ho Cheung added 1 comment

Patchset-level comments
Ho Cheung . resolved

+tkent ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id63370ea50654fcdd342816066243e0750e0ebd6
Gerrit-Change-Number: 6771038
Gerrit-PatchSet: 1
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Mon, 21 Jul 2025 23:53:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Jul 21, 2025, 8:24:55 PMJul 21
to Ho Cheung, Kent Tamura, Chromium LUCI CQ, Luna Lu, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Dirk Schulze, Alexis Menard, Kentaro Hara, AyeAye, drott+bl...@chromium.org, aleventhal...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-revi...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, kyungjunle...@google.com, blink-revi...@chromium.org, francisjp...@google.com, nektar...@chromium.org, scheduler-...@chromium.org, jmedle...@chromium.org, abigailbk...@google.com, zol...@webkit.org, josiah...@chromium.org, chikamu...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, lucasrada...@google.com, dtseng...@chromium.org, yuzo+...@chromium.org
Attention needed from Ho Cheung

Kent Tamura voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ho Cheung
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id63370ea50654fcdd342816066243e0750e0ebd6
Gerrit-Change-Number: 6771038
Gerrit-PatchSet: 1
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Ho Cheung <hoch...@chromium.org>
Gerrit-Comment-Date: Tue, 22 Jul 2025 00:24:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ho Cheung (Gerrit)

unread,
Jul 21, 2025, 8:28:15 PMJul 21
to Kent Tamura, Chromium LUCI CQ, Luna Lu, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Dirk Schulze, Alexis Menard, Kentaro Hara, AyeAye, drott+bl...@chromium.org, aleventhal...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-revi...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, kyungjunle...@google.com, blink-revi...@chromium.org, francisjp...@google.com, nektar...@chromium.org, scheduler-...@chromium.org, jmedle...@chromium.org, abigailbk...@google.com, zol...@webkit.org, josiah...@chromium.org, chikamu...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, lucasrada...@google.com, dtseng...@chromium.org, yuzo+...@chromium.org

Ho Cheung voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Tue, 22 Jul 2025 00:28:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 21, 2025, 9:12:10 PMJul 21
to Ho Cheung, Kent Tamura, Akihiro Ota, Luna Lu, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Dirk Schulze, Alexis Menard, Kentaro Hara, AyeAye, drott+bl...@chromium.org, aleventhal...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, fmalit...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-revi...@chromium.org, oilpan-rev...@chromium.org, kouhe...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, kyungjunle...@google.com, blink-revi...@chromium.org, francisjp...@google.com, nektar...@chromium.org, scheduler-...@chromium.org, jmedle...@chromium.org, abigailbk...@google.com, zol...@webkit.org, josiah...@chromium.org, chikamu...@chromium.org, apavlo...@chromium.org, kinuko...@chromium.org, devtools-re...@chromium.org, lucasrada...@google.com, dtseng...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[blink] Switch wtf/hash_table_deleted_value_type to "blink" namespace

This CL has no behavior changes.
Bug: 422768753
Change-Id: Id63370ea50654fcdd342816066243e0750e0ebd6
Commit-Queue: Ho Cheung <hoch...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1489879}
Files:
  • M third_party/blink/renderer/core/accessibility/blink_ax_event_intent.cc
  • M third_party/blink/renderer/core/accessibility/blink_ax_event_intent.h
  • M third_party/blink/renderer/core/accessibility/blink_ax_event_intent_test.cc
  • M third_party/blink/renderer/core/css/container_selector.h
  • M third_party/blink/renderer/core/frame/font_matching_metrics.h
  • M third_party/blink/renderer/core/html/forms/control_key.h
  • M third_party/blink/renderer/core/inspector/legacy_dom_snapshot_agent.cc
  • M third_party/blink/renderer/core/layout/masonry/masonry_item_group.h
  • M third_party/blink/renderer/core/permissions_policy/policy_helper.h
  • M third_party/blink/renderer/platform/fonts/fallback_list_composite_key.h
  • M third_party/blink/renderer/platform/fonts/font_cache_key.h
  • M third_party/blink/renderer/platform/fonts/font_description.cc
  • M third_party/blink/renderer/platform/fonts/font_description.h
  • M third_party/blink/renderer/platform/fonts/font_platform_data.cc
  • M third_party/blink/renderer/platform/fonts/font_platform_data.h
  • M third_party/blink/renderer/platform/fonts/font_selection_types.h
  • M third_party/blink/renderer/platform/fonts/shaping/shape_cache.h
  • M third_party/blink/renderer/platform/heap/test/heap_test.cc
  • M third_party/blink/renderer/platform/scheduler/main_thread/attribution_group.h
  • M third_party/blink/renderer/platform/wtf/hash_table_deleted_value_type.h
  • M third_party/blink/renderer/platform/wtf/hash_traits.h
  • M third_party/blink/renderer/platform/wtf/linked_hash_set_test.cc
Change size: M
Delta: 22 files changed, 25 insertions(+), 30 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kent Tamura
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id63370ea50654fcdd342816066243e0750e0ebd6
Gerrit-Change-Number: 6771038
Gerrit-PatchSet: 2
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages