Explicitly ignore result of atomic_ref::load() [v8/v8 : main]

0 views
Skip to first unread message

Nico Weber (Gerrit)

unread,
Jan 11, 2026, 5:52:08 PM (6 days ago) Jan 11
to Nico Weber, Omer Katz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Omer Katz

Nico Weber voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Omer Katz
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88711f434535a7ba2f46ffabaf1e8c469a146112
Gerrit-Change-Number: 7430550
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Omer Katz <omer...@chromium.org>
Gerrit-Comment-Date: Sun, 11 Jan 2026 22:52:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Omer Katz (Gerrit)

unread,
Jan 12, 2026, 4:08:20 AM (6 days ago) Jan 12
to Nico Weber, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Weber

Omer Katz voted and added 1 comment

Votes added by Omer Katz

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88711f434535a7ba2f46ffabaf1e8c469a146112
Gerrit-Change-Number: 7430550
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 09:08:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Jan 12, 2026, 4:09:56 AM (6 days ago) Jan 12
to Nico Weber, Omer Katz, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
Explicitly ignore result of atomic_ref::load()

An upstream libc++ change marks that method nodiscard.

No behavior change.
Bug: 468205004
Change-Id: I88711f434535a7ba2f46ffabaf1e8c469a146112
Reviewed-by: Omer Katz <omer...@chromium.org>
Auto-Submit: Nico Weber <tha...@chromium.org>
Commit-Queue: Omer Katz <omer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104624}
Files:
  • M src/heap/cppgc/heap-page.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Omer Katz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I88711f434535a7ba2f46ffabaf1e8c469a146112
Gerrit-Change-Number: 7430550
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Omer Katz <omer...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages