[heap] Reapply the user-provided stack start marker [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
Mar 20, 2026, 3:44:28 AM (11 days ago) Mar 20
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 20, 2026, 8:55:28 AM (11 days ago) Mar 20
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted and added 2 comments![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
2 comments
Patchset-level comments
Michael Lippautz . resolved
lgtm
File src/heap/cppgc-js/cpp-heap.h
Line 191, Patchset 3 (Latest):
std::optional<cppgc::StackStartMarker> stack_start_marker();Michael Lippautz . unresolved
I'd move the accessor here to the base heap as that's also where the field lives.
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 20, 2026, 9:07:41 AM (11 days ago) Mar 20
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Dominik Inführ added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Dominik Inführ . resolved
Updated the CL and lost the +1. PTALA
File src/heap/cppgc-js/cpp-heap.h
Line 191, Patchset 3:
std::optional<cppgc::StackStartMarker> stack_start_marker();Michael Lippautz . resolved
I'd move the accessor here to the base heap as that's also where the field lives.
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Mar 20, 2026, 3:44:30 PM (10 days ago) Mar 20
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Michael Lippautz voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
Mar 23, 2026, 3:57:38 AM (8 days ago) Mar 23
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 23, 2026, 4:37:24 AM (8 days ago) Mar 23
to Dominik Inführ, Michael Lippautz, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[heap] Reapply the user-provided stack start marker
https://crrev.com/c/7666257 added StackStartMarker to configure
CppHeap with a stack start different from the platform's stack start.
However, once CppHeap was attached to an Isolate, the custom stack
start was overwritten again with the stack start of the platform in
Heap::SetStackStart.
Bug: 492198560
Change-Id: I59b7f76a498d2f0c7f6e8f58ff707a2961c8a47b
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105948}
Files:
- M src/heap/base/stack.h
- M src/heap/cppgc/heap-base.cc
- M src/heap/cppgc/heap-base.h
- M src/heap/heap.cc
- M src/heap/heap.h
- M test/unittests/heap/cppgc-js/cpp-heap-stack-start-marker-unittest.cc
Change size: M
Delta: 6 files changed, 52 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages