Disable fuzztest subprocess on Android. [chromium/src : main]

0 views
Skip to first unread message

Titouan Rigoudy (Gerrit)

unread,
Jun 6, 2024, 7:38:49 AMJun 6
to Adrian Taylor, chromotin...@chromium.org, Hans Wennborg, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Ian Vollick, chromium...@chromium.org, abigailbk...@google.com, antoniosartori+wa...@chromium.org, blink-re...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, hirokisa...@chromium.org, huangs...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, mpdento...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oilpan-rev...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, poscia...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org, dominicc+...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, fuzzin...@chromium.org, droger+w...@chromium.org, fuz...@chromium.org
Attention needed from Adrian Taylor

Titouan Rigoudy voted and added 1 comment

Votes added by Titouan Rigoudy

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 26 (Latest):
Titouan Rigoudy . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Adrian Taylor
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4bbbac223c77d8dcd73a7bb23ba20838ff1c5540
Gerrit-Change-Number: 4983734
Gerrit-PatchSet: 26
Gerrit-Owner: Adrian Taylor <adet...@chromium.org>
Gerrit-Reviewer: Titouan Rigoudy <tit...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Adrian Taylor <adet...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Jun 2024 11:38:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Adrian Taylor (Gerrit)

unread,
Jun 6, 2024, 11:04:54 AMJun 6
to Titouan Rigoudy, chromotin...@chromium.org, Hans Wennborg, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Ian Vollick, chromium...@chromium.org, abigailbk...@google.com, antoniosartori+wa...@chromium.org, blink-re...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, hirokisa...@chromium.org, huangs...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, mpdento...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oilpan-rev...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, poscia...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org, dominicc+...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, fuzzin...@chromium.org, droger+w...@chromium.org, fuz...@chromium.org

Adrian Taylor voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4bbbac223c77d8dcd73a7bb23ba20838ff1c5540
Gerrit-Change-Number: 4983734
Gerrit-PatchSet: 27
Gerrit-Owner: Adrian Taylor <adet...@chromium.org>
Gerrit-Reviewer: Adrian Taylor <adet...@chromium.org>
Gerrit-Reviewer: Titouan Rigoudy <tit...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Jun 2024 15:04:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 6, 2024, 12:46:29 PMJun 6
to Adrian Taylor, Titouan Rigoudy, Akihiro Ota, chromotin...@chromium.org, Hans Wennborg, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Peter Beverloo, Rijubrata Bhaumik, Sadrul Chowdhury, Ian Vollick, chromium...@chromium.org, abigailbk...@google.com, antoniosartori+wa...@chromium.org, blink-re...@chromium.org, cblume...@chromium.org, cblum...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, dtseng...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, hirokisa...@chromium.org, huangs...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, mpdento...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, oilpan-rev...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, pdf-r...@chromium.org, penghuan...@chromium.org, poscia...@chromium.org, roblia...@chromium.org, rsesek...@chromium.org, sky+...@chromium.org, vaapi-...@chromium.org, wfh+...@chromium.org, yuzo+...@chromium.org, dominicc+...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, fuzzin...@chromium.org, droger+w...@chromium.org, fuz...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

26 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Disable fuzztest subprocess on Android.

For compatibility, Chromium uses an older version of the Android NDK,
which doesn't support the spawn APIs required by fuzztest. Disable this
part of fuzztest on Android.

FuzzTest appears to use this functionality only in external runner
executables, so fuzztests themselves should still be fully functional
without this.

This problem does not currently cause any build problems because the
existing FuzzTest-using test binaries are only built for Linux, Windows
and Mac. Over time, though, we hope to include FuzzTests within
existing unit test binaries which need to build for every platform, so
this is a pre-requisite for that change.
Bug: 40286211
Change-Id: I4bbbac223c77d8dcd73a7bb23ba20838ff1c5540
Cq-Include-Trybots: luci.chromium.try:linux-libfuzzer-asan-rel,win-libfuzzer-asan-rel,linux-centipede-asan-rel
Reviewed-by: Titouan Rigoudy <tit...@chromium.org>
Commit-Queue: Adrian Taylor <adet...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1311339}
Files:
  • M third_party/fuzztest/BUILD.gn
Change size: XS
Delta: 1 file changed, 6 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Titouan Rigoudy
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4bbbac223c77d8dcd73a7bb23ba20838ff1c5540
Gerrit-Change-Number: 4983734
Gerrit-PatchSet: 28
Gerrit-Owner: Adrian Taylor <adet...@chromium.org>
Gerrit-Reviewer: Adrian Taylor <adet...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages