[heap] Extract limit computation out of Heap [v8/v8 : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Dec 18, 2025, 12:28:47 PM (10 days ago) Dec 18
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Dec 18, 2025, 1:19:53 PM (10 days ago) Dec 18
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
File src/heap/heap.cc
Line 301, Patchset 9 (Parent):
DCHECK_EQ(0, max_old_generation_size() & (PageMetadata::kPageSize - 1));Etienne Pierre-Doray . resolved
This is effectively a no-op, because max_old_generation_size() isn't initialized here.
But it causes problem because heap_limits_ isn't initialized either.
Related details
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages