[maglev] Inline Math.imul, Math.fround and Math.trunc [v8/v8 : main]
0 views
Skip to first unread message
chromeperf@appspot.gserviceaccount.com (Gerrit)
Mar 26, 2026, 9:26:55 AMMar 26
to Anton Bikineev, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Anton Bikineev
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/153deefd090000
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Mar 26, 2026, 9:30:52 AMMar 26
to Anton Bikineev, chrom...@appspot.gserviceaccount.com, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Anton Bikineev
Victor Gomes added 1 comment![]( "Open in Gerrit")
Commit Message
Line 15, Patchset 1 (Latest):
These optimizations significantly improve JetStream 2.1 performance,
especially in crypto and math-intensive benchmarks like
stanford-crypto-sha256 (+9.6%) and stanford-crypto-pbkdf2 (+7.5%).Victor Gomes . unresolved
Amazing! Can you run against --turbolev-future?
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Mar 26, 2026, 11:17:20 AMMar 26
to Anton Bikineev, Victor Gomes, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Anton Bikineev
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/159712a2090000
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Mar 26, 2026, 11:47:37 AMMar 26
to Anton Bikineev, Victor Gomes, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Anton Bikineev
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream2 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/133aba69090000
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Mar 30, 2026, 6:08:03 AMMar 30
to Anton Bikineev, Victor Gomes, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Anton Bikineev
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
- async-fs: base median = 422.00407033551016 -> patched median = 380.2380417087934
- bigint-noble-ed25519: base median = 147.26050758485985 -> patched median = 137.75715600549984
- chai-wtb: base median = 284.78790330563606 -> patched median = 262.96234340561114
- crypto: base median = 1700.5111100983283 -> patched median = 1392.5739746823501
- delta-blue: base median = 2402.8333051102263 -> patched median = 1974.5889553574011
- doxbee-async: base median = 667.2174110608427 -> patched median = 619.9036055012748
- doxbee-promise: base median = 758.4873485268004 -> patched median = 639.3701503696152
- espree-wtb: base median = 109.5499960182349 -> patched median = 100.70209741757321
- esprima-next-wtb: base median = 136.4842558944272 -> patched median = 128.05566796507156
- hash-map: base median = 900.5884721984899 -> patched median = 739.619155529158
- lazy-collections: base median = 337.72758077112206 -> patched median = 313.57082171093316
- mandreel: base median = 176.49257074362146 -> patched median = 166.44297628151995
- ml: base median = 180.7972685244422 -> patched median = 160.09503880833
- raytrace: base median = 736.4028343940491 -> patched median = 654.6485958846246
- raytrace-public-class-fields: base median = 679.7680077378815 -> patched median = 600.4189453278159
- segmentation: base median = 90.38916465578968 -> patched median = 83.6420646991076
- sync-fs: base median = 544.0375658608618 -> patched median = 482.8574206550146
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/15951b07090000
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Mar 30, 2026, 6:47:21 AMMar 30
to Anton Bikineev, Victor Gomes, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Anton Bikineev
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
- async-fs: base median = 420.7400658142377 -> patched median = 380.6622767830198
- bigint-noble-ed25519: base median = 147.41354089639867 -> patched median = 138.09821405436048
- chai-wtb: base median = 284.730573345854 -> patched median = 263.3334635420377
- crypto: base median = 1701.426504246191 -> patched median = 1394.286957112471
- delta-blue: base median = 2399.8058596743404 -> patched median = 1973.6199690361605
- doxbee-async: base median = 666.867219982373 -> patched median = 622.8453245150547
- doxbee-promise: base median = 758.395095597834 -> patched median = 634.3373996937377
- earley-boyer: base median = 1239.4731174179847 -> patched median = 1176.5533903861506
- espree-wtb: base median = 109.57210732748841 -> patched median = 100.76712689218498
- esprima-next-wtb: base median = 136.39509174298973 -> patched median = 128.10748545609493
- hash-map: base median = 902.4936327185342 -> patched median = 660.1861285888725
- lazy-collections: base median = 337.62463124375694 -> patched median = 313.4995364110662
- mandreel: base median = 176.5522461124474 -> patched median = 166.40434027568432
- ml: base median = 180.7061570230021 -> patched median = 160.12832097641723
- raytrace: base median = 736.2871667784173 -> patched median = 655.2259821462808
- raytrace-public-class-fields: base median = 679.0900308477835 -> patched median = 600.3517604933644
- segmentation: base median = 90.43218601024473 -> patched median = 83.64169024501184
- sync-fs: base median = 544.147991679928 -> patched median = 483.30696176140634
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12e4cbcf090000
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Mar 30, 2026, 8:21:35 AMMar 30
to Anton Bikineev, Victor Gomes, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Anton Bikineev
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16b3da90890000
Related details
Attention is currently required from:
- Anton Bikineev
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Mar 30, 2026, 8:34:53 AMMar 30
to Victor Gomes, chrom...@appspot.gserviceaccount.com, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Anton Bikineev added 1 comment![]( "Open in Gerrit")
Commit Message
Line 15, Patchset 1 (Latest):
These optimizations significantly improve JetStream 2.1 performance,
especially in crypto and math-intensive benchmarks like
stanford-crypto-sha256 (+9.6%) and stanford-crypto-pbkdf2 (+7.5%).Victor Gomes . resolved
Amazing! Can you run against --turbolev-future?
Anton Bikineev
With `--turbolev-future` it also seems to yield about 0.2% total improvement: https://pinpoint-dot-chromeperf.appspot.com/job/16b3da90890000
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Mar 31, 2026, 9:59:15 AMMar 31
to Leszek Swirski, V8 LUCI CQ, Victor Gomes, chrom...@appspot.gserviceaccount.com, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski and Victor Gomes
Anton Bikineev voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Leszek Swirski
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Mar 31, 2026, 10:06:51 AMMar 31
to Anton Bikineev, V8 LUCI CQ, Victor Gomes, chrom...@appspot.gserviceaccount.com, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Anton Bikineev and Victor Gomes
Leszek Swirski voted and added 2 comments![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Code-Review | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Leszek Swirski . resolved
lgtm assuming that the machine code is correct for the semantics.
File src/maglev/maglev-graph-builder.cc
Line 11171, Patchset 3 (Latest):
}Leszek Swirski . unresolved
needs a CanSpeculateCall() check to avoid deopt loops -- it can check for `args[i]->is_tagged()` same as fround to still do the multiply even if speculation is off.
Related details
Attention is currently required from:
- Anton Bikineev
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Mar 31, 2026, 12:35:21 PMMar 31
to Leszek Swirski, V8 LUCI CQ, Victor Gomes, chrom...@appspot.gserviceaccount.com, AyeAye, Hannes Payer, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Anton Bikineev added 1 comment![]( "Open in Gerrit")
File src/maglev/maglev-graph-builder.cc
Leszek Swirski . resolved
needs a CanSpeculateCall() check to avoid deopt loops -- it can check for `args[i]->is_tagged()` same as fround to still do the multiply even if speculation is off.
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 7, 2026, 6:08:42 AM (13 days ago) Apr 7
to Anton Bikineev, Leszek Swirski, V8 LUCI CQ, Victor Gomes, AyeAye, Hannes Payer, cbruni...@chromium.org, v8-risc...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Anton Bikineev, Leszek Swirski and Victor Gomes
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12f0e510890000
Related details
Attention is currently required from:
- Anton Bikineev
- Leszek Swirski
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anton Bikineev (Gerrit)
Apr 7, 2026, 6:39:20 AM (13 days ago) Apr 7
to Leszek Swirski, V8 LUCI CQ, Victor Gomes, chrom...@appspot.gserviceaccount.com, AyeAye, Hannes Payer, cbruni...@chromium.org, v8-risc...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski and Victor Gomes
Anton Bikineev voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anton Bikineev
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Anton Bikineev . resolved
Leszek, could you please take another look?
Related details
Attention is currently required from:
- Leszek Swirski
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Apr 7, 2026, 6:44:40 AM (13 days ago) Apr 7
to Anton Bikineev, V8 LUCI CQ, Victor Gomes, chrom...@appspot.gserviceaccount.com, AyeAye, Hannes Payer, cbruni...@chromium.org, v8-risc...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Anton Bikineev and Victor Gomes
Leszek Swirski voted![]( "Open in Gerrit")
Attention is currently required from:
- Anton Bikineev
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Apr 7, 2026, 6:47:29 AM (13 days ago) Apr 7
to Anton Bikineev, Leszek Swirski, Victor Gomes, chrom...@appspot.gserviceaccount.com, AyeAye, Hannes Payer, cbruni...@chromium.org, v8-risc...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev] Inline Math.imul, Math.fround and Math.trunc
This patch implements inlining for several Math builtins in Maglev:
1. Inlines Math.imul using 32-bit integer multiplication instructions.
2. Inlines Math.fround by introducing a new Float64RoundToFloat32 IR node.
3. Inlines Math.trunc by extending Float64Round with a kTrunc kind.
4. Optimizes Math.abs to avoid Float64 conversion for Int32 inputs.
These optimizations improve JetStream 2.1 performance, especially in
crypto and math-intensive benchmarks like
stanford-crypto-sha256 (+2.4%), stanford-crypto-pbkdf2 (+2.9%)
and prismjs-startup-es6 (+4.9%).
Change-Id: I461b449f9160da94584184543eeeefd69c73c8e2
Auto-Submit: Anton Bikineev <biki...@chromium.org>
Commit-Queue: Leszek Swirski <les...@chromium.org>
Reviewed-by: Leszek Swirski <les...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106276}
Files:
- M src/compiler/turboshaft/turbolev-graph-builder.cc
- M src/maglev/arm/maglev-ir-arm.cc
- M src/maglev/arm64/maglev-ir-arm64.cc
- M src/maglev/loong64/maglev-ir-loong64.cc
- M src/maglev/maglev-graph-builder.cc
- M src/maglev/maglev-graph-builder.h
- M src/maglev/maglev-graph-optimizer.cc
- M src/maglev/maglev-ir.cc
- M src/maglev/maglev-ir.h
- M src/maglev/ppc/maglev-ir-ppc.cc
- M src/maglev/riscv/maglev-ir-riscv.cc
- M src/maglev/s390/maglev-ir-s390.cc
- M src/maglev/x64/maglev-ir-x64.cc
Change size: M
Delta: 13 files changed, 183 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 7, 2026, 10:56:14 AM (13 days ago) Apr 7
to V8 LUCI CQ, Anton Bikineev, Leszek Swirski, Victor Gomes, AyeAye, Hannes Payer, cbruni...@chromium.org, v8-risc...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job mac-m1_mini_2020-perf/jetstream2 failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1223f4e8890000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 7, 2026, 10:56:28 AM (13 days ago) Apr 7
to V8 LUCI CQ, Anton Bikineev, Leszek Swirski, Victor Gomes, AyeAye, Hannes Payer, cbruni...@chromium.org, v8-risc...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job mac-m1_mini_2020-perf/jetstream-main.crossbench failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1291b082890000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 7, 2026, 12:26:04 PM (13 days ago) Apr 7
to V8 LUCI CQ, Anton Bikineev, Leszek Swirski, Victor Gomes, AyeAye, Hannes Payer, cbruni...@chromium.org, v8-risc...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job mac-m1_mini_2020-perf/jetstream-main.crossbench failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12cc29f8890000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 8, 2026, 5:35:11 AM (12 days ago) Apr 8
to V8 LUCI CQ, Anton Bikineev, Leszek Swirski, Victor Gomes, AyeAye, Hannes Payer, cbruni...@chromium.org, v8-risc...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, dmercadi...@chromium.org, leszek...@chromium.org, mlippau...@chromium.org, oilpan-r...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
😿 Job mac-m1_mini_2020-perf/jetstream-main.crossbench failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/146aac3c890000
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages