[Memory Coordinator] Register signal for v8 OOMs [chromium/src : main]

[Patrick Monette (Gerrit)]

Attention needed from Francois Pierre Doray

Patrick Monette added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Patrick Monette . resolved

Hi Francois, care to take a first look please?

Open in Gerrit

Related details

Attention is currently required from:

• Francois Pierre Doray

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic7191407b73ea5bf7c7a3f13acb4ccdf4b85fbce

Gerrit-Change-Number: 6885006

Gerrit-PatchSet: 6

Gerrit-Owner: Patrick Monette <pmon...@chromium.org>

Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>

Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>

Gerrit-Comment-Date: Wed, 24 Sep 2025 15:19:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Francois Pierre Doray (Gerrit)]

Attention needed from Patrick Monette

Francois Pierre Doray voted and added 2 comments

Votes added by Francois Pierre Doray

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Francois Pierre Doray . resolved

LGTM % I recommend adding comments to describe each new class/method and a detailed CL description

File third_party/blink/public/platform/platform.h

Line 858, Patchset 6 (Latest): // Invoked when the garbage collector is about to run it's last GC before

Francois Pierre Doray . unresolved

its

Open in Gerrit

Related details

Attention is currently required from:

• Patrick Monette

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic7191407b73ea5bf7c7a3f13acb4ccdf4b85fbce

Gerrit-Change-Number: 6885006

Gerrit-PatchSet: 6

Gerrit-Owner: Patrick Monette <pmon...@chromium.org>

Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>

Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Patrick Monette <pmon...@chromium.org>

Gerrit-Comment-Date: Wed, 24 Sep 2025 21:42:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[AI Code Reviewer (Gerrit)]

Attention needed from Patrick Monette

AI Code Reviewer added 1 comment

File third_party/blink/renderer/controller/memory_coordinator/v8_heap_memory_signal_generator.h

Line 20, Patchset 7 (Latest): static void Initialize(v8::Isolate* isolate);

AI Code Reviewer . unresolved

nit: The parameter name 'isolate' is obvious from its type 'v8::Isolate*' and can be omitted from the function declaration in the header file. (Blink Style Guide: Naming - May leave obvious parameter names out of function declarations)

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:

• Patrick Monette

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ic7191407b73ea5bf7c7a3f13acb4ccdf4b85fbce

Gerrit-Change-Number: 6885006

Gerrit-PatchSet: 7

Gerrit-Owner: Patrick Monette <pmon...@chromium.org>

Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>

Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>

Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Patrick Monette <pmon...@chromium.org>

Gerrit-Comment-Date: Thu, 25 Sep 2025 14:22:12 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No