Issue 1508089 in chromium: Remove expired histograms OfflinePages.PageSize

[histogram-eraser via monorail]

Status: Untriaged
Owner: ----
CC: jia...@chromium.org, offli...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Pri: 3
Type: Task

New issue 1508089 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms OfflinePages.PageSize
https://bugs.chromium.org/p/chromium/issues/detail?id=1508089

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- OfflinePages.PageSize (expired as of 2021-06-25)

The following code locations were found:

components/offline_pages/core/model/offline_page_model_taskified.cc:98:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:383:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:407:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:438:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:451:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:464:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:480:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:495:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:508:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:520:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:564:
"OfflinePages.PageSize"),
components/offline_pages/core/model/offline_page_model_taskified_unittest.cc:596:
"OfflinePages.PageSize"),

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- If the histogram should be removed:
- Recommended: Mark the bug as Available and add the label Proj-CodeHealthRotation-Bug.
- Or, assign to yourself if you'd prefer to do the clean up yourself.
- Otherwise, annotate the histograms as intentionally expired (see above) and update the bug.
- If you believe the bug was filed in error, cc:asvi...@chromium.org and mention the problem.

Available bugs with the label Proj-CodeHealthRotation-Bug will be eligible for cleanup by participants in the code health rotation.

If the bug is left in the Untriaged state without any activity by histogram owner(s), we will consider that the histogram is not needed and it will be considered for removal.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[kylixrd via monorail]

Updates:
Owner: kyl...@chromium.org
Status: Assigned

Comment #1 on issue 1508089 by kyl...@google.com: Remove expired histograms OfflinePages.PageSize
https://bugs.chromium.org/p/chromium/issues/detail?id=1508089#c1

Code Health Rotation

[Git Watcher via monorail]

Comment #2 on issue 1508089 by Git Watcher: Remove expired histograms OfflinePages.PageSize
https://bugs.chromium.org/p/chromium/issues/detail?id=1508089#c2

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/ddc6dc25c936e6d92c34be08228cff84ca81f1ad

commit ddc6dc25c936e6d92c34be08228cff84ca81f1ad
Author: Allen Bauer <kyl...@chromium.org>
Date: Fri Dec 15 18:57:56 2023

Remove various expired Offline Pages UMA histograms.

Code Health Rotation

Bug: 1508091, 1508090, 1508089, 1508088, 1508087, 1508086, 1508085, 1508084, 1508083
Change-Id: Ib65dfae4398529cbeb168d10e46b80b5f5b93ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5119363
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Reviewed-by: Roger McFarlane <rog...@chromium.org>
Auto-Submit: Allen Bauer <kyl...@chromium.org>
Reviewed-by: Robert Ogden <rober...@chromium.org>
Commit-Queue: Allen Bauer <kyl...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1238171}

[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/model/persistent_page_consistency_check_task.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/model/startup_maintenance_task_unittest.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/model/cleanup_visuals_task_unittest.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/tools/metrics/histograms/metadata/histogram_suffixes_list.xml
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/offline_page_metadata_store.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/model/mark_page_accessed_task.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/chrome/browser/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/model/startup_maintenance_task.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/chrome/browser/offline_pages/recent_tab_helper.h
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/model/persistent_page_consistency_check_task_unittest.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/chrome/browser/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/tools/metrics/histograms/metadata/offline/histograms.xml
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/chrome/browser/offline_pages/offline_page_tab_helper.h
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/model/cleanup_visuals_task.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/components/offline_pages/core/model/mark_page_accessed_task_unittest.cc
[modify] https://crrev.com/ddc6dc25c936e6d92c34be08228cff84ca81f1ad/chrome/browser/offline_pages/recent_tab_helper_unittest.cc

[kylixrd via monorail]

Updates:
Status: Fixed

Comment #3 on issue 1508089 by kyl...@chromium.org: Remove expired histograms OfflinePages.PageSize
https://bugs.chromium.org/p/chromium/issues/detail?id=1508089#c3

(No comment was entered for this change.)