Issue 1508077 in chromium: Remove expired histograms Net.ErrorPageCounts.SuggestionClicked

[histogram-eraser via monorail]

Status: Untriaged
Owner: ----
CC: scli...@chromium.org, offli...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>Network
Pri: 3
Type: Task

New issue 1508077 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms Net.ErrorPageCounts.SuggestionClicked
https://bugs.chromium.org/p/chromium/issues/detail?id=1508077

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- Net.ErrorPageCounts.SuggestionClicked (expired as of 2021-12-19)

The following code locations were found:

chrome/renderer/net/available_offline_content_helper.cc:135:
UMA_HISTOGRAM_ENUMERATION("Net.ErrorPageCounts.SuggestionClicked",

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- If the histogram should be removed:
- Recommended: Mark the bug as Available and add the label Proj-CodeHealthRotation-Bug.
- Or, assign to yourself if you'd prefer to do the clean up yourself.
- Otherwise, annotate the histograms as intentionally expired (see above) and update the bug.
- If you believe the bug was filed in error, cc:asvi...@chromium.org and mention the problem.

Available bugs with the label Proj-CodeHealthRotation-Bug will be eligible for cleanup by participants in the code health rotation.

If the bug is left in the Untriaged state without any activity by histogram owner(s), we will consider that the histogram is not needed and it will be considered for removal.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[arichiv via monorail]

Comment #3 on issue 1508077 by ari...@chromium.org: Remove expired histograms Net.ErrorPageCounts.SuggestionClicked
https://bugs.chromium.org/p/chromium/issues/detail?id=1508077#c3

https://chromium-review.googlesource.com/c/chromium/src/+/5129986

[Git Watcher via monorail]

Comment #4 on issue 1508077 by Git Watcher: Remove expired histograms Net.ErrorPageCounts.SuggestionClicked
https://bugs.chromium.org/p/chromium/issues/detail?id=1508077#c4

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/5fcb911c40c92404c188630648ee4a8c884a571a

commit 5fcb911c40c92404c188630648ee4a8c884a571a
Author: Ari Chivukula <ari...@chromium.org>
Date: Mon Dec 18 10:29:18 2023

Remove expired histogram Net.ErrorPageCounts.SuggestionClicked

The following histogram was marked as expired:

- Net.ErrorPageCounts.SuggestionClicked (expired as of 2021-12-19)

Let's clean it up.

OBSOLETE_HISTOGRAMS=Expired as of 2021-12-19 and removed as of 2023-12-17.

Bug: 1508077
Change-Id: I203871f85751ae8378cb65be1f4335affbb6d3ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5129986
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
Commit-Queue: Ari Chivukula <ari...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1238547}

[modify] https://crrev.com/5fcb911c40c92404c188630648ee4a8c884a571a/tools/metrics/histograms/metadata/net/histograms.xml
[modify] https://crrev.com/5fcb911c40c92404c188630648ee4a8c884a571a/chrome/renderer/net/available_offline_content_helper.cc

[arichiv via monorail]

Updates:
Status: Fixed

Comment #5 on issue 1508077 by ari...@chromium.org: Remove expired histograms Net.ErrorPageCounts.SuggestionClicked
https://bugs.chromium.org/p/chromium/issues/detail?id=1508077#c5

(No comment was entered for this change.)