Issue 1508078 in chromium: Remove expired histograms Net.ErrorPageCounts.SuggestionPresented

0 views
Skip to first unread message

histogram-eraser via monorail

unread,
Dec 4, 2023, 3:45:04 PM12/4/23
to offli...@chromium.org
Status: Untriaged
Owner: ----
CC: scli...@chromium.org, offli...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>Network
Pri: 3
Type: Task

New issue 1508078 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms Net.ErrorPageCounts.SuggestionPresented
https://bugs.chromium.org/p/chromium/issues/detail?id=1508078

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- Net.ErrorPageCounts.SuggestionPresented (expired as of 2021-12-05)

The following code locations were found:

chrome/renderer/net/available_offline_content_helper.cc:77:
UMA_HISTOGRAM_ENUMERATION("Net.ErrorPageCounts.SuggestionPresented",
chrome/renderer/net/net_error_helper_core_unittest.cc:1058:
histogram_tester_.ExpectTotalCount("Net.ErrorPageCounts.SuggestionPresented",
chrome/renderer/net/net_error_helper_core_unittest.cc:1061:
"Net.ErrorPageCounts.SuggestionPresented",
chrome/renderer/net/net_error_helper_core_unittest.cc:1064:
"Net.ErrorPageCounts.SuggestionPresented",
chrome/renderer/net/net_error_helper_core_unittest.cc:1075:
"Net.ErrorPageCounts.SuggestionPresented",
chrome/renderer/net/net_error_helper_core_unittest.cc:1097:
histogram_tester_.ExpectTotalCount("Net.ErrorPageCounts.SuggestionPresented",
chrome/renderer/net/net_error_helper_core_unittest.cc:1100:
"Net.ErrorPageCounts.SuggestionPresented",
chrome/renderer/net/net_error_helper_core_unittest.cc:1103:
"Net.ErrorPageCounts.SuggestionPresented",
chrome/renderer/net/net_error_helper_core_unittest.cc:1114:
"Net.ErrorPageCounts.SuggestionPresented",
chrome/renderer/net/net_error_helper_core_unittest.cc:1152:
histogram_tester_.ExpectTotalCount("Net.ErrorPageCounts.SuggestionPresented",

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- If the histogram should be removed:
- Recommended: Mark the bug as Available and add the label Proj-CodeHealthRotation-Bug.
- Or, assign to yourself if you'd prefer to do the clean up yourself.
- Otherwise, annotate the histograms as intentionally expired (see above) and update the bug.
- If you believe the bug was filed in error, cc:asvi...@chromium.org and mention the problem.

Available bugs with the label Proj-CodeHealthRotation-Bug will be eligible for cleanup by participants in the code health rotation.

If the bug is left in the Untriaged state without any activity by histogram owner(s), we will consider that the histogram is not needed and it will be considered for removal.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

arichiv via monorail

unread,
Dec 17, 2023, 4:31:25 AM12/17/23
to offli...@chromium.org

arichiv via monorail

unread,
Dec 18, 2023, 5:32:04 AM12/18/23
to offli...@chromium.org
Updates:
Status: Fixed

Comment #4 on issue 1508078 by ari...@chromium.org: Remove expired histograms Net.ErrorPageCounts.SuggestionPresented
https://bugs.chromium.org/p/chromium/issues/detail?id=1508078#c4

(No comment was entered for this change.)

Git Watcher via monorail

unread,
Dec 18, 2023, 3:45:27 PM12/18/23
to offli...@chromium.org

Comment #5 on issue 1508078 by Git Watcher: Remove expired histograms Net.ErrorPageCounts.SuggestionPresented
https://bugs.chromium.org/p/chromium/issues/detail?id=1508078#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/8f5ccf1d1023d67ce2e9a42f084732cff7951713

commit 8f5ccf1d1023d67ce2e9a42f084732cff7951713
Author: Ari Chivukula <ari...@chromium.org>
Date: Mon Dec 18 20:44:10 2023

Remove expired histogram Net.ErrorPageCounts.SuggestionPresented

The following histogram was marked as expired:

- Net.ErrorPageCounts.SuggestionPresented (expired as of 2021-12-05)

Let's clean it up.

OBSOLETE_HISTOGRAMS=Expired as of 2021-12-05 and removed as of 2023-12-17.

Bug: 1508078
Change-Id: Ic6b421c21e836e3774e2c0be614d27f526dd36c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5126802
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Commit-Queue: Ari Chivukula <ari...@chromium.org>
Auto-Submit: Ari Chivukula <ari...@chromium.org>
Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1238722}

[modify] https://crrev.com/8f5ccf1d1023d67ce2e9a42f084732cff7951713/tools/metrics/histograms/metadata/net/histograms.xml
[modify] https://crrev.com/8f5ccf1d1023d67ce2e9a42f084732cff7951713/chrome/renderer/net/net_error_helper_core_unittest.cc
[modify] https://crrev.com/8f5ccf1d1023d67ce2e9a42f084732cff7951713/chrome/renderer/net/available_offline_content_helper.cc
[modify] https://crrev.com/8f5ccf1d1023d67ce2e9a42f084732cff7951713/tools/metrics/histograms/metadata/net/enums.xml
Reply all
Reply to author
Forward
0 new messages