[Editing] Control text truncation based on selection [chromium/src : main]

[Shweta Bindal (Gerrit)]

Attention needed from Kent Tamura, Rohan Raja and Sambamurthy Bandaru

Shweta Bindal added 2 comments

File third_party/blink/renderer/core/layout/layout_block_flow.cc

Line 672, Patchset 31: ContainsSelectionFocus()) {

Kent Tamura . resolved

I guess `ContainsSelectionFocus()` should be `object_to_check->ContainsSelectionFocus()` for the following case:

```html
<div style="text-overflow:ellispsis">
<div>sub-block</div>
foo | bar (this is wrapped by an anonymous block-flow)
</div>
```

Shweta Bindal

Good catch. Changed to object_to_check->ContainsSelectionFocus() and set the flag on the non-anonymous parent that owns the text-overflow style.
Since ShouldTruncateOverflowingText() is evaluated during each child's inline layout and LayoutNG caches child results, the flag change alone doesn't cause cache misses — so we explicitly call SetNeedsLayout() on each block child (and on the block itself when it has no block children) to force re-evaluation.

File third_party/blink/web_tests/fast/css/text-overflow-input-focus-placeholder.html

File-level comment, Patchset 28 (Parent):

Kent Tamura . resolved

Why will it be removed?

Shweta Bindal

It was written when someone added change in styleadjuster to change text-overflow property on focus. Now since we are directly setting it from layout, I dont think it will matter if placeholder is clipped or not since user cannot interact with placeholder in any way

Kent Tamura

Do you mean this CL will change the placeholder/autocomplete behavior?

Will a placeholder have no ellipsis? Will a placeholder have an ellipsis even if the text control is focused? What about interoperability with other browsers? Can we change the behavior by a separated patch?

Anyway, we should update the test for the new behavior, not remove the test.

Shweta Bindal

For placeholder yes behavior will change, placeholder's ellipsis text will not we converted into clipped on selection or focus.
Firefox also behaves in the same way

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura
• Rohan Raja
• Sambamurthy Bandaru

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 36

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 04:14:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Shweta Bindal <shweta...@microsoft.com>

Comment-In-Reply-To: Kent Tamura <tk...@chromium.org>

[Kent Tamura (Gerrit)]

Attention needed from Rohan Raja, Sambamurthy Bandaru and Shweta Bindal

Kent Tamura added 1 comment

File third_party/blink/web_tests/fast/css/text-overflow-input-focus-placeholder.html

File-level comment, Patchset 28 (Parent):

Kent Tamura . unresolved

Why will it be removed?

Shweta Bindal

It was written when someone added change in styleadjuster to change text-overflow property on focus. Now since we are directly setting it from layout, I dont think it will matter if placeholder is clipped or not since user cannot interact with placeholder in any way

Kent Tamura

Do you mean this CL will change the placeholder/autocomplete behavior?

Will a placeholder have no ellipsis? Will a placeholder have an ellipsis even if the text control is focused? What about interoperability with other browsers? Can we change the behavior by a separated patch?

Anyway, we should update the test for the new behavior, not remove the test.

Shweta Bindal

For placeholder yes behavior will change, placeholder's ellipsis text will not we converted into clipped on selection or focus.
Firefox also behaves in the same way

Kent Tamura

I recommend to drop the placeholder behavior change from this CL, and handle it in a separated CL and behind a separated runtime flag.

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Sambamurthy Bandaru
• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 05:00:58 +0000

[Shweta Bindal (Gerrit)]

Attention needed from Kent Tamura, Rohan Raja and Sambamurthy Bandaru

Shweta Bindal added 1 comment

File third_party/blink/web_tests/fast/css/text-overflow-input-focus-placeholder.html

File-level comment, Patchset 28 (Parent):

Kent Tamura . resolved

Why will it be removed?

Shweta Bindal

It was written when someone added change in styleadjuster to change text-overflow property on focus. Now since we are directly setting it from layout, I dont think it will matter if placeholder is clipped or not since user cannot interact with placeholder in any way

Kent Tamura

Do you mean this CL will change the placeholder/autocomplete behavior?

Will a placeholder have no ellipsis? Will a placeholder have an ellipsis even if the text control is focused? What about interoperability with other browsers? Can we change the behavior by a separated patch?

Anyway, we should update the test for the new behavior, not remove the test.

Shweta Bindal

For placeholder yes behavior will change, placeholder's ellipsis text will not we converted into clipped on selection or focus.
Firefox also behaves in the same way

Kent Tamura

I recommend to drop the placeholder behavior change from this CL, and handle it in a separated CL and behind a separated runtime flag.

Shweta Bindal

Made the changes. Will handle removing styleAdjuster code in separate PR

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura
• Rohan Raja
• Sambamurthy Bandaru

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 38

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 06:06:30 +0000

[Kent Tamura (Gerrit)]

Attention needed from Rohan Raja, Sambamurthy Bandaru and Shweta Bindal

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Code-Review

+1

1 comment

Commit Message

Line 11, Patchset 38 (Latest):during editing. This was a hack in StyleAdjuster.

Kent Tamura . unresolved

The hack in StyleAdjust is only for placeholder and suggestions. This sentense should be removed.

<input>'s behavior is in TextControlInnerEditorElement::CustomStyleForLayoutObject().

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Sambamurthy Bandaru
• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 06:55:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Shweta Bindal (Gerrit)]

Attention needed from Rohan Raja and Sambamurthy Bandaru

Shweta Bindal added 1 comment

Commit Message

Line 11, Patchset 38:during editing. This was a hack in StyleAdjuster.

Kent Tamura . resolved

The hack in StyleAdjust is only for placeholder and suggestions. This sentense should be removed.

<input>'s behavior is in TextControlInnerEditorElement::CustomStyleForLayoutObject().

Shweta Bindal

Done

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Sambamurthy Bandaru

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 39

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 07:28:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Kent Tamura <tk...@chromium.org>

[Shweta Bindal (Gerrit)]

Attention needed from Rohan Raja and Sambamurthy Bandaru

Shweta Bindal voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Mon, 02 Mar 2026 07:29:07 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Blink W3C Test Autoroller (Gerrit)]

Attention needed from Rohan Raja and Sambamurthy Bandaru

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/58159.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Sambamurthy Bandaru

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 39

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 07:36:56 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Unreviewed changes

38 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

[Editing] Control text truncation based on selection

Previously, text-overflow ellipsis was converted to clip
for focused input elements and placeholders to avoid rendering ellipsis
during editing.

Instead:
- Add |LayoutObject::ContainsSelection()| bitfield to track selection state
- In |SelectionEditor::SetSelection()|, notify parent elements of selection
  changes and update their |ContainsSelection()| state
- In InlineLayoutAlgorithm, skip ellipsis truncation if block contains
  selection |LayoutBlockFlow::ContainsSelection()|

New WPT tests verify ellipsis suppression in editable div/input/textarea
with caret. Updates multiple platform baselines for selection-aware
ellipsis rendering.

Bug: 40731275

Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7452739

Commit-Queue: Shweta Bindal <shweta...@microsoft.com>

Reviewed-by: Kent Tamura <tk...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1592277}

Files:

• M third_party/blink/renderer/core/editing/selection_editor.cc
• M third_party/blink/renderer/core/editing/selection_editor.h
• M third_party/blink/renderer/core/layout/layout_block_flow.cc
• M third_party/blink/renderer/core/layout/layout_object.cc
• M third_party/blink/renderer/core/layout/layout_object.h
• M third_party/blink/renderer/platform/runtime_enabled_features.json5
• A third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-anonymous-block-expected.html
• A third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-anonymous-block.html
• M third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
• M third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr.html
• M third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
• M third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl.html
• A third_party/blink/web_tests/editing/selection/text-overflow-ellipsis-selection-error-scenarios.html
• A third_party/blink/web_tests/editing/selection/text-overflow-ellipsis-selection.html
• A third_party/blink/web_tests/external/wpt/css/css-overflow/reference/text-overflow-ellipsis-editable-div-with-caret-ref.html
• A third_party/blink/web_tests/external/wpt/css/css-overflow/reference/text-overflow-ellipsis-textarea-with-caret-ref.html
• A third_party/blink/web_tests/external/wpt/css/css-overflow/text-overflow-ellipsis-editable-div-with-caret.html
• A third_party/blink/web_tests/external/wpt/css/css-overflow/text-overflow-ellipsis-textarea-with-caret.html
• M third_party/blink/web_tests/platform/linux/editing/selection/select-text-overflow-ellipsis-expected.png
• M third_party/blink/web_tests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
• M third_party/blink/web_tests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
• M third_party/blink/web_tests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
• M third_party/blink/web_tests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
• M third_party/blink/web_tests/platform/linux/virtual/text-antialias/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png
• M third_party/blink/web_tests/platform/mac-mac14-arm64/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
• M third_party/blink/web_tests/platform/mac-mac14-arm64/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
• M third_party/blink/web_tests/platform/mac-mac14-arm64/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
• M third_party/blink/web_tests/platform/mac-mac14-arm64/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
• M third_party/blink/web_tests/platform/mac-mac14/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
• M third_party/blink/web_tests/platform/mac-mac14/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
• M third_party/blink/web_tests/platform/mac-mac14/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
• M third_party/blink/web_tests/platform/mac-mac14/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
• M third_party/blink/web_tests/platform/mac/editing/selection/select-text-overflow-ellipsis-expected.png
• M third_party/blink/web_tests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
• M third_party/blink/web_tests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
• M third_party/blink/web_tests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
• M third_party/blink/web_tests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
• M third_party/blink/web_tests/platform/mac/virtual/text-antialias/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png
• M third_party/blink/web_tests/platform/win/editing/selection/select-text-overflow-ellipsis-expected.png
• M third_party/blink/web_tests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
• M third_party/blink/web_tests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
• M third_party/blink/web_tests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
• M third_party/blink/web_tests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
• M third_party/blink/web_tests/platform/win/virtual/text-antialias/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png

Change size: L

Delta: 44 files changed, 512 insertions(+), 9 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Kent Tamura

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 40

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

[Blink W3C Test Autoroller (Gerrit)]

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/58159

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Comment-Date: Mon, 02 Mar 2026 08:24:52 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[luci-bisection@appspot.gserviceaccount.com (Gerrit)]

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: revert

[Ian Kilpatrick (Gerrit)]

Attention needed from Shweta Bindal

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/core/layout/layout_object.cc

Line 1835, Patchset 40 (Latest): return block;

Ian Kilpatrick . unresolved

This doesn't do what it says in the method name - e.g. it can return a non-LayoutBlock object is this safe?

Open in Gerrit

Related details

Attention is currently required from:

• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 40

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 17:33:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No