[DirectReceiver] Bind NetworkContext as a DirectReceiver [chromium/src : main]
Nafis Abedin (Gerrit)
Nafis Abedin added 1 comment![]( "Open in Gerrit")
ricea@ PTAL at the Network Context changes :)
Related details
- Adam Rice
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
Adam Rice voted and added 2 comments![]( "Open in Gerrit")
Votes added by Adam Rice
| Code-Review | +1 |
2 comments
lgtm with nit
if (mojo::IsDirectReceiverSupported() && base::CurrentIOThread::IsSet() &&I don't like repeated code, so please move this to a method or something.
Related details
- Nafis Abedin
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nafis Abedin (Gerrit)
Nafis Abedin added 2 comments![]( "Open in Gerrit")
dcheng@ PTAL :) Added directly instead of chrome-ipc-reviews@ due to mojo/ changes as well
if (mojo::IsDirectReceiverSupported() && base::CurrentIOThread::IsSet() &&I don't like repeated code, so please move this to a method or something.
- Daniel Cheng
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Daniel Cheng added 1 comment![]( "Open in Gerrit")
Unsurprisingly, this has really broad effects.
In general, does the network service use threads/thread pools? The documentation on direct_receiver.h specifically discourages this sort of thing.
I guess one might argue that this isn't "really" worse than having a hop through a dedicated I/O thread... but honestly, it's kind of hard to tell with how many things this is affecting.
Related details
- Nafis Abedin
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
Adam Rice voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Rice
| Code-Review | +1 |
1 comment
Unsurprisingly, this has really broad effects.
In general, does the network service use threads/thread pools? The documentation on direct_receiver.h specifically discourages this sort of thing.
I guess one might argue that this isn't "really" worse than having a hop through a dedicated I/O thread... but honestly, it's kind of hard to tell with how many things this is affecting.
The parts of the network service that are exposed to mojo are all on the IO thread. There are threads and thread pools used internally inside //net, but the public interfaces are all called on the IO thread, so AFAIK that shouldn't make any difference to mojo.
Nafis Abedin (Gerrit)
Nafis Abedin added 1 comment![]( "Open in Gerrit")
Adam RiceUnsurprisingly, this has really broad effects.
In general, does the network service use threads/thread pools? The documentation on direct_receiver.h specifically discourages this sort of thing.
I guess one might argue that this isn't "really" worse than having a hop through a dedicated I/O thread... but honestly, it's kind of hard to tell with how many things this is affecting.
The parts of the network service that are exposed to mojo are all on the IO thread. There are threads and thread pools used internally inside //net, but the public interfaces are all called on the IO thread, so AFAIK that shouldn't make any difference to mojo.
+1 to Adam's comment. Local testing & tracing didn't show any immediate signs of concern for that particular gotcha of DirectReceiver either.
Related details
- Daniel Cheng
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |