[M138-LTS] shared_dictionary: Fix Use-After-Free in SharedDictionaryOnDisk [chromium/src : refs/branch-heads/7204]
0 views
Skip to first unread message
Tsuyoshi Horo (Gerrit)
Mar 10, 2026, 8:56:09 PMMar 10
to Gyuyoung Kim (xWF), Chromium LUCI CQ, AyeAye, network-ser...@chromium.org
Attention needed from Gyuyoung Kim (xWF)
Tsuyoshi Horo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tsuyoshi Horo . unresolved
lgtm...
Q: Do we still support M138?
Related details
Attention is currently required from:
- Gyuyoung Kim (xWF)
Submit Requirements:
Code-Owners
Code-Review
Lint
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Apr 1, 2026, 10:15:23 PM (2 days ago) Apr 1
to Tsuyoshi Horo, Victor Gabriel Savu, Patrick Meenan, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org
Attention needed from Patrick Meenan and Victor Gabriel Savu
Gyuyoung Kim (xWF) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Patrick Meenan
- Victor Gabriel Savu
Submit Requirements:
Code-Owners
Code-Review
Lint
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Apr 1, 2026, 10:16:02 PM (2 days ago) Apr 1
to Tsuyoshi Horo, Victor Gabriel Savu, Patrick Meenan, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org
Attention needed from Patrick Meenan and Victor Gabriel Savu
Gyuyoung Kim (xWF) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Tsuyoshi Horo . resolved
lgtm...
Q: Do we still support M138?
Gyuyoung Kim (xWF)
Sorry for the late reply. Yes, we need to support the LTS release.
Related details
Attention is currently required from:
- Patrick Meenan
- Victor Gabriel Savu
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Apr 1, 2026, 10:16:17 PM (2 days ago) Apr 1
to Tsuyoshi Horo, Victor Gabriel Savu, Patrick Meenan, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org
Attention needed from Patrick Meenan and Victor Gabriel Savu
Gyuyoung Kim (xWF) removed a vote from this change![]( "Open in Gerrit")
Removed Lint-1 by AyeAye <android-bu...@system.gserviceaccount.com>
Related details
Attention is currently required from:
- Patrick Meenan
- Victor Gabriel Savu
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Meenan (Gerrit)
Apr 1, 2026, 10:33:18 PM (2 days ago) Apr 1
to Tsuyoshi Horo, Gyuyoung Kim (xWF), Victor Gabriel Savu, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org
Attention needed from Gyuyoung Kim (xWF) and Victor Gabriel Savu
Patrick Meenan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Meenan
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Gyuyoung Kim (xWF)
- Victor Gabriel Savu
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gabriel Savu (Gerrit)
Apr 2, 2026, 3:03:44 AM (2 days ago) Apr 2
to Tsuyoshi Horo, Gyuyoung Kim (xWF), Patrick Meenan, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org
Attention needed from Gyuyoung Kim (xWF)
Victor Gabriel Savu voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Gyuyoung Kim (xWF)
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gyuyoung Kim (xWF) (Gerrit)
Apr 2, 2026, 9:01:07 AM (2 days ago) Apr 2
to Tsuyoshi Horo, Victor Gabriel Savu, Patrick Meenan, Chromium LUCI CQ, AyeAye, network-ser...@chromium.org
Gyuyoung Kim (xWF) voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 2, 2026, 9:46:56 AM (2 days ago) Apr 2
to Tsuyoshi Horo, Gyuyoung Kim (xWF), Victor Gabriel Savu, Patrick Meenan, AyeAye, network-ser...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M138-LTS] shared_dictionary: Fix Use-After-Free in SharedDictionaryOnDisk
This CL fixes a Use-After-Free bug in SharedDictionaryOnDisk::SetState.
Previously, SetState() accessed the member variable state_ within a loop
that executes callbacks. If one of these callbacks resulted in the
deletion of the SharedDictionaryOnDisk object, subsequent accesses to
state_ would result in a Use-After-Free.
This CL resolves the issue by using the local 'state' parameter instead
of the 'state_' member variable.
A regression test DeleteInReadAllCallback is added to
shared_dictionary_on_disk_unittest.cc to ensure that deleting the
dictionary in a ReadAll() callback does not cause a crash.
(cherry picked from commit d1fbfa27e826d6e6424c1f73b93a03744c2091fb)
Fixed: 488585488
Change-Id: I2192458c2d58825bed91f8791604ceeb20b1056b
Commit-Queue: Patrick Meenan <pme...@chromium.org>
Reviewed-by: Patrick Meenan <pme...@chromium.org>
Auto-Submit: Tsuyoshi Horo <ho...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1594661}
Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
Commit-Queue: Gyuyoung Kim (xWF) <qk...@google.com>
Reviewed-by: Victor Gabriel Savu <vs...@google.com>
Owners-Override: Victor Gabriel Savu <vs...@google.com>
Cr-Commit-Position: refs/branch-heads/7204@{#3515}
Cr-Branched-From: d5de512dc9dc8ddfe4e6d71b0637578bb6158683-refs/heads/main@{#1465706}
Files:
- M services/network/shared_dictionary/shared_dictionary_on_disk.cc
- M services/network/shared_dictionary/shared_dictionary_on_disk_unittest.cc
Change size: M
Delta: 2 files changed, 58 insertions(+), 4 deletions(-)
Branch: refs/branch-heads/7204
Submit Requirements:
Code-Review: +1 by Victor Gabriel Savu, +1 by Patrick Meenan, +1 by Tsuyoshi Horo
Lint: +0 by AyeAye
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages