Support pattern matching in the network throttler [chromium/src : main]
Philip Pfaffe (Gerrit)
Philip Pfaffe added 1 comment![]( "Open in Gerrit")
Any thoughts on the test coverage? Anything I'm missing?
Related details
- Alex Rudenko
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko added 6 comments![]( "Open in Gerrit")
Any thoughts on the test coverage? Anything I'm missing?
Looks good to me!
Let's add a description about the scope and high-level design to explain this change
void SetNetworkConditions(document what the string is in the pair?
// Returns the interceptor for the NetLog source ID.Document the url param as well.
// Multple patterns with the same conditions get grouped into a single pipe.Please fix this WARNING reported by Spellchecker: "Multple" is a possible misspelling of "Multiple".
To bypass Spellchecker, add ...
"Multple" is a possible misspelling of "Multiple".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
/*download=*/0,Please fix this WARNING reported by ClangTidy: check: bugprone-argument-comment
argument name 'download' in comment does not m...
check: bugprone-argument-comment
argument name 'download' in comment does not match parameter name 'download_throughput' (https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)
(Note: You can add `Skip-Clang-Tidy-Checks: bugprone-argument-comment` footer to the CL description to skip the check)
(Note: running clang-tidy on this file failed; this diagnostic might be incorrect as a result.)
(Lint observed on `linux-clang-tidy-rel`, but not on `android-clang-tidy-rel`)
Related details
- Philip Pfaffe
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |