Add a feature to limit the early loading of compression dictionaries [chromium/src : main]

0 views

Skip to first unread message

Patrick Meenan (Gerrit)

unread,

Mar 2, 2026, 8:17:30 PM (16 hours ago) Mar 2

to Tsuyoshi Horo, Yoav Weiss (@Shopify), AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, net-r...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, network-ser...@chromium.org

Attention needed from Tsuyoshi Horo

Patrick Meenan voted and added 1 comment

Votes added by Patrick Meenan

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Patrick Meenan . resolved

horo@ could you PTAL?

Open in Gerrit

Related details

Attention is currently required from:

Tsuyoshi Horo

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tsuyoshi Horo (Gerrit)

unread,

Mar 2, 2026, 11:58:13 PM (12 hours ago) Mar 2

to Patrick Meenan, Yoav Weiss (@Shopify), AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, net-r...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, asvitkine...@chromium.org, network-ser...@chromium.org

Attention needed from Patrick Meenan

Tsuyoshi Horo added 2 comments

File net/http/http_response_info.h

Line 205, Patchset 3 (Latest): // This is always false for resources served from cache (where

Tsuyoshi Horo . unresolved

I think `did_send_available_dictionary` should also have the same comment.

File net/shared_dictionary/shared_dictionary_network_transaction.cc

Line 287, Patchset 3 (Latest):

  bool succeeded = result == OK;
  base::UmaHistogramTimes(
      base::StrCat({"Net.SharedDictionaryTransaction.DictionaryReadLatency.",
                    succeeded ? "Success" : "Failure"}),
      base::Time::Now() - read_start_time);

Tsuyoshi Horo . unresolved

This feature has a significant impact on DictionaryReadLatency only when fetching subresources. To accurately measure this impact, it would be better to record DictionaryReadLatency separately for the main resource and subresource.