Revert "[Connection-Allowlist] Set up Origin Trial for workers." [chromium/src : main]

0 views

Skip to first unread message

Rubber Stamper (Gerrit)

unread,

Apr 3, 2026, 3:39:17 PM (18 hours ago) Apr 3

to luci-bi...@appspot.gserviceaccount.com, Stefan Zager, Alex Moshchuk, Shivani Sharma, Andrew Verge, Chromium LUCI CQ, Kenichi Ishibashi, Xiaochen Zhou, Yoshisato Yanagisawa, David Baron, AyeAye, chromium...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, blink-work...@chromium.org, network-ser...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, ort...@google.com

Attention needed from Alex Moshchuk, Andrew Verge, David Baron, Kenichi Ishibashi, Shivani Sharma, Stefan Zager, Xiaochen Zhou and Yoshisato Yanagisawa

Rubber Stamper voted Bot-Commit+1

Bot-Commit

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk
Andrew Verge
David Baron
Kenichi Ishibashi
Shivani Sharma
Stefan Zager
Xiaochen Zhou
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Giovanni Ortuno Urquidi (Gerrit)

unread,

Apr 3, 2026, 3:45:01 PM (18 hours ago) Apr 3

to luci-bi...@appspot.gserviceaccount.com, Giovanni Ortuno Urquidi, Rubber Stamper, Stefan Zager, Alex Moshchuk, Shivani Sharma, Andrew Verge, Chromium LUCI CQ, Kenichi Ishibashi, Xiaochen Zhou, Yoshisato Yanagisawa, David Baron, AyeAye, chromium...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, blink-work...@chromium.org, network-ser...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, ort...@google.com

Attention needed from Alex Moshchuk, Andrew Verge, David Baron, Kenichi Ishibashi, Shivani Sharma, Stefan Zager, Xiaochen Zhou and Yoshisato Yanagisawa

Giovanni Ortuno Urquidi voted

Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Alex Moshchuk
Andrew Verge
David Baron
Kenichi Ishibashi
Shivani Sharma
Stefan Zager
Xiaochen Zhou
Yoshisato Yanagisawa

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 3, 2026, 3:45:35 PM (18 hours ago) Apr 3

to luci-bi...@appspot.gserviceaccount.com, Giovanni Ortuno Urquidi, Rubber Stamper, Stefan Zager, Alex Moshchuk, Shivani Sharma, Andrew Verge, Kenichi Ishibashi, Xiaochen Zhou, Yoshisato Yanagisawa, David Baron, AyeAye, chromium...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, blink-work...@chromium.org, network-ser...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, ort...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "[Connection-Allowlist] Set up Origin Trial for workers."

This reverts commit c45a40cde85882c000c724b163904ef8ec0ca02e.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5655549128474624

Sample build with failed test: https://ci.chromium.org/b/8685523181357396705
Affected test(s):
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.externalnav:UrlOverridingTest#testIncognitoSubframeExternalNavigation_Rejected](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.externalnav:UrlOverridingTest%23testIncognitoSubframeExternalNavigation_Rejected?q=VHash%3A9b216f545ab27397)
[://chrome/android\:chrome_public_test_apk!junit:org.chromium.chrome.browser.externalnav:UrlOverridingTest#testSubframeLoadCannotLaunchPlayApp](https://ci.chromium.org/ui/test/chromium/:%2F%2Fchrome%2Fandroid%5C:chrome_public_test_apk%21junit:org.chromium.chrome.browser.externalnav:UrlOverridingTest%23testSubframeLoadCannotLaunchPlayApp?q=VHash%3A9b216f545ab27397)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5655549128474624&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7688831&type=BUG

Original change's description:
> [Connection-Allowlist] Set up Origin Trial for workers.
>
> In order for the Connection-Allowlist origin trial to proceed, we need
> to ensure that worker content is also aware of the OT token. We also
> need the kConnectionAllowlists flag to be enabled by default, so that
> the OT token and override are governing whether Connection-Allowlist
> is enabled or not.
>
> 1. The OT token checks have been added to the
> NetworkRestrictionsWorkerThrottle and worker script fetcher.
> 2. Refactoring: move the connection allowlists existence check and
> token validation to two functions in connection_allowlist_gating.h/cc
>
> I have tests for the following cases:
> * Worker script fetch respects the document's connection allowlist
> * Worker subresource fetch respects the main script fetcher's connection allowlist (when inheriting the allowlist via a local scheme).
>
> I still need to add tests for:
> * Worker script fetch returns its own Connection-Allowlist, and subresource requests respect that.
>
> These tests are in a wpt_internal virtual suite because they require
> special setup for our slightly-non-standard OT implementation. Given the
> size of this CL, might make sense to split the other test cases into a
> separate CL. This CL adds 2 virtual tests in total.
>
> Bug: 447954811
> Change-Id: I3fd9bcb52cbeb48b79650311e0af8a78d62bff79
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7688831
> Reviewed-by: Yoshisato Yanagisawa <yyana...@chromium.org>
> Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
> Reviewed-by: Shivani Sharma <shiva...@chromium.org>
> Commit-Queue: Andrew Verge <ave...@chromium.org>
> Reviewed-by: David Baron <dba...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1609818}
>

Bug: 447954811

No-Presubmit: true

No-Tree-Checks: true

No-Try: true

Change-Id: I68d9ad06a8c766318942c81136fa440cc1da885a

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7729621

Owners-Override: Giovanni Ortuno Urquidi <ort...@chromium.org>

Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Commit-Queue: Giovanni Ortuno Urquidi <ort...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1609910}

Files:

M content/browser/BUILD.gn
D content/browser/connection_allowlist_gating.cc
D content/browser/connection_allowlist_gating.h
M content/browser/renderer_host/navigation_request.cc
M content/browser/worker_host/network_restrictions_worker_throttle.cc
M content/browser/worker_host/worker_script_fetcher.cc
M services/network/network_context.cc
M services/network/public/cpp/features.cc
M third_party/blink/web_tests/VirtualTestSuites
D third_party/blink/web_tests/virtual/connection-allowlist-origin-trial/README.md
M third_party/blink/web_tests/virtual/connection-allowlist/README.md
D third_party/blink/web_tests/wpt_internal/connection-allowlist/resources/dedicated-worker-test.js
D third_party/blink/web_tests/wpt_internal/connection-allowlist/resources/origin-trial-token.txt
D third_party/blink/web_tests/wpt_internal/connection-allowlist/resources/worker-fetch-script.js
D third_party/blink/web_tests/wpt_internal/connection-allowlist/worker-origin-trial-disabled.sub.https.window.js
D third_party/blink/web_tests/wpt_internal/connection-allowlist/worker-origin-trial-disabled.sub.https.window.js.headers
D third_party/blink/web_tests/wpt_internal/connection-allowlist/worker-origin-trial-enabled.sub.https.window.js
D third_party/blink/web_tests/wpt_internal/connection-allowlist/worker-origin-trial-enabled.sub.https.window.js.headers

Change size: L

Delta: 18 files changed, 53 insertions(+), 346 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: Bot-Commit+1 by Rubber Stamper

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages