Make testing DomainReliability mojo methods async [chromium/src : main]
Matt Mueller (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Chromium IPC Reviews
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mpde...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): mpde...@chromium.org
Reviewer source(s):
mpde...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Matthew Denton
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Denton (Gerrit)
Matthew Denton voted Code-Review+1![]( "Open in Gerrit")
- Matt Mueller
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Mueller (Gerrit)
Matt Mueller voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Make testing DomainReliability mojo methods async
Speculative fix for flaky test timeouts in
DomainReliabilityBrowserTest.RequestAtShutdown
DomainReliabilityBrowserTest.Upload
DomainReliabilityBrowserTest.UploadAtShutdown
Sync mojo methods were responsible for similar flaky browser test
timeouts in other tests, so try switching these mojo methods to async to
see if it fixes these tests.
- M chrome/browser/domain_reliability/browsertest.cc
- M services/network/public/mojom/network_context.mojom
Code-Review: +1 by Matthew Denton
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |