[fenced frames] Disable sharedStorage.get() in fenced frames [chromium/src : main]

[Shivani Sharma (Gerrit)]

Attention needed from Andrew Verge and Yao Xiao

Shivani Sharma added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Shivani Sharma . resolved

Yao, PTAL at the shared_storage/* files, thanks!
Andrew, PTAL at the overall change, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Andrew Verge
• Yao Xiao

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15

Gerrit-Change-Number: 7709973

Gerrit-PatchSet: 17

Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>

Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Yao Xiao <yao...@chromium.org>

Gerrit-Attention: Andrew Verge <ave...@chromium.org>

Gerrit-Comment-Date: Tue, 31 Mar 2026 20:06:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Yao Xiao (Gerrit)]

Attention needed from Andrew Verge and Shivani Sharma

Yao Xiao voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Andrew Verge
• Shivani Sharma

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15

Gerrit-Change-Number: 7709973

Gerrit-PatchSet: 17

Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>

Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Shivani Sharma <shiva...@chromium.org>

Gerrit-Attention: Andrew Verge <ave...@chromium.org>

Gerrit-Comment-Date: Tue, 31 Mar 2026 20:14:32 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Shivani Sharma (Gerrit)]

Attention needed from Alex Moshchuk, Andrew Verge and Mike West

Shivani Sharma added 1 comment

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Shivani Sharma . resolved

Adding Alex for the owner's approval of content/browser and content/public/browser. PTAL, thanks!

Adding Mike for the owner's approval of third_party/blink/, content/shell/browser/, services/network/public/. PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Andrew Verge
• Mike West

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15

Gerrit-Change-Number: 7709973

Gerrit-PatchSet: 17

Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>

Gerrit-Attention: Andrew Verge <ave...@chromium.org>

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 14:19:52 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mike West (Gerrit)]

Attention needed from Alex Moshchuk, Andrew Verge and Shivani Sharma

Mike West voted and added 2 comments

Votes added by Mike West

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 17 (Latest):

Mike West . resolved

blink and mojo LGTM.

File third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

Line 9138, Patchset 17 (Parent): method get

Mike West . unresolved

Blink side of this LGTM, but you'll need an API owner to weigh in on this. I assume you sent an intent already?

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Andrew Verge
• Shivani Sharma

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15

Gerrit-Change-Number: 7709973

Gerrit-PatchSet: 17

Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>

Gerrit-Attention: Shivani Sharma <shiva...@chromium.org>

Gerrit-Attention: Andrew Verge <ave...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 15:57:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Andrew Verge (Gerrit)]

Attention needed from Alex Moshchuk and Shivani Sharma

Andrew Verge added 1 comment

File third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

Line 9138, Patchset 17 (Parent): method get

Mike West . unresolved

Blink side of this LGTM, but you'll need an API owner to weigh in on this. I assume you sent an intent already?

Andrew Verge

Allowing sharedStorage.get() from documents (fenced frames) never actually shipped; we only got as far as I2P. Do we still need an intent to remove it?

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Shivani Sharma

Gerrit-Comment-Date: Wed, 01 Apr 2026 16:06:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Mike West <mk...@chromium.org>

[Shivani Sharma (Gerrit)]

Attention needed from Alex Moshchuk, Andrew Verge and Mike West

Shivani Sharma added 1 comment

File third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt

Line 9138, Patchset 17 (Parent): method get

Mike West . unresolved

Blink side of this LGTM, but you'll need an API owner to weigh in on this. I assume you sent an intent already?

Andrew Verge

Allowing sharedStorage.get() from documents (fenced frames) never actually shipped; we only got as far as I2P. Do we still need an intent to remove it?

Shivani Sharma

+1. shared storage.get() is gated behind a default disabled feature flag and it was never enabled.

flag: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/common/features.cc;drc=f79a5eea7a342c492253d84aa68d44513fa84ef4;l=750

gate:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/shared_storage/shared_storage.cc;drc=f79a5eea7a342c492253d84aa68d44513fa84ef4;l=765

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Andrew Verge
• Mike West

Gerrit-Attention: Andrew Verge <ave...@chromium.org>

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 16:37:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Andrew Verge <ave...@chromium.org>

Comment-In-Reply-To: Mike West <mk...@chromium.org>

[Andrew Verge (Gerrit)]

Attention needed from Alex Moshchuk, Mike West and Shivani Sharma

Andrew Verge voted and added 2 comments

Votes added by Andrew Verge

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 19 (Latest):

Andrew Verge . resolved

LGTM as well.

File content/browser/fenced_frame/fenced_frame_browsertest.cc

Line 6127, Patchset 19 (Latest):// 8. Access to shared storage get is now allowed.

Andrew Verge . unresolved

If we're updating this test to remove shared storage calls, the comment should reflect that as well.

Are we planning to remove this test entirely in the followup that removes disableUntrustedNetwork?

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Mike West
• Shivani Sharma

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15

Gerrit-Change-Number: 7709973

Gerrit-PatchSet: 19

Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>

Gerrit-Attention: Shivani Sharma <shiva...@chromium.org>

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 17:10:05 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Shivani Sharma (Gerrit)]

Attention needed from Alex Moshchuk and Mike West

Shivani Sharma added 1 comment

File content/browser/fenced_frame/fenced_frame_browsertest.cc

Line 6127, Patchset 19:// 8. Access to shared storage get is now allowed.

Andrew Verge . resolved

If we're updating this test to remove shared storage calls, the comment should reflect that as well.

Are we planning to remove this test entirely in the followup that removes disableUntrustedNetwork?

Shivani Sharma

Done

Yes the test will be removed in the follow-up disableUntrustedNetwork removal CL.

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Mike West

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15

Gerrit-Change-Number: 7709973

Gerrit-PatchSet: 20

Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 17:35:09 +0000

[Alex Moshchuk (Gerrit)]

Attention needed from Mike West and Shivani Sharma

Alex Moshchuk voted and added 1 comment

Votes added by Alex Moshchuk

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 19:

Alex Moshchuk . resolved

content/ LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Mike West
• Shivani Sharma

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15

Gerrit-Change-Number: 7709973

Gerrit-PatchSet: 21

Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Shivani Sharma <shiva...@chromium.org>

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 17:39:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Shivani Sharma (Gerrit)]

Attention needed from Fiona Macintosh, Maks Orlovich and Mike West

Shivani Sharma added 1 comment

Patchset-level comments

File-level comment, Patchset 21 (Latest):

Shivani Sharma . resolved

fmacintosh@, PTAL at components/privacy_sandbox/*, thanks!
morlovich@, PTAL at services/network/public/cpp/permissions_policy/*, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Fiona Macintosh
• Maks Orlovich
• Mike West

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Iedcd065280b56ed86dbc4317e3221cbc00da1e15

Gerrit-Change-Number: 7709973

Gerrit-PatchSet: 21

Gerrit-Owner: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>

Gerrit-Reviewer: Fiona Macintosh <fmaci...@google.com>

Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>

Gerrit-Reviewer: Mike West <mk...@chromium.org>

Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>

Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mike West <mk...@chromium.org>

Gerrit-Attention: Fiona Macintosh <fmaci...@google.com>

Gerrit-Attention: Maks Orlovich <morl...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 17:47:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No