Add Request.isReloadNavigation attribute [chromium/src : main]

0 views
Skip to first unread message

Helmut Januschka (Gerrit)

unread,
Feb 2, 2026, 6:45:38 PMFeb 2
to Helmut Januschka, Chromium Metrics Reviews, Alex Moshchuk, Daniel Cheng, Adam Rice, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Adam Rice, Alex Moshchuk, Daniel Cheng and Yoav Weiss (@Shopify)

Helmut Januschka added 1 comment

File content/browser/security_exploit_browsertest.cc
Line 1626, Patchset 16 (Parent): ui::PAGE_TRANSITION_RELOAD,
Adam Rice . unresolved

Why is this safe to remove?

Helmut Januschka

think it is safe to remove because this CL makes PAGE_TRANSITION_RELOAD web-triggerable for script-initiated reloads. Since it's now intentionally web-triggerable, it would be incorrect to test.

Adam Rice

But `isReloadNavigation` is a read-only attribute. JavaScript can't even set it, so how does this CL enable JavaScript to trigger PAGE_TRANSITION_RELOAD?

Helmut Januschka

i changed `render_frame_impl.cc` to send `PAGE_TRANSITION_RELOAD` for reload navigations (`location.reload()`). Previously, all renderer-initiated navigations used `PAGE_TRANSITION_LINK`.

Since the renderer now sends `PAGE_TRANSITION_RELOAD`, it must be added to `PageTransitionIsWebTriggerable()` - otherwise the browser would kill the renderer.

Adam Rice

Oh! I missed that important point. I think I need that part to be reviewed first. Let me find a review for it.

Helmut Januschka

any update?

Adam Rice

Sorry for the delay.

Alex Moshchuk

On first glance, this change seems risky to me. It's hard to judge all the implications, but it seems that we've been previously relying on PAGE_TRANSITION_RELOAD to mean that the navigation had been browser-initiated, and now it will be renderer-initiated instead: see comments [here](https://source.chromium.org/chromium/chromium/src/+/main:ui/base/page_transition_types.h;l=83-90;drc=1d1fcea6ebbc1c2c3d04ab5538c74f742c66444f). That might mean that the navigation would be subject to fewer security checks than before, e.g. it seems that a few places that use this to initialize is_renderer_initiated ([example 1](https://source.chromium.org/chromium/chromium/src/+/main:android_webview/browser/network_service/aw_web_resource_request.cc;l=28-29;drc=1d1fcea6ebbc1c2c3d04ab5538c74f742c66444f), [example 2](https://source.chromium.org/chromium/chromium/src/+/main:android_webview/browser/safe_browsing/aw_url_checker_delegate_impl.cc;l=54;drc=1d1fcea6ebbc1c2c3d04ab5538c74f742c66444f)) would now be potentially wrong. It might have UI implications as well (where browser-initiated navigations are treated slightly differently from renderer-initiated ones). I'll see if I can discuss this with a couple of other navigation owners and report back here.

Helmut Januschka

Thanks for the detailed analysis, Alex! You're absolutely right about the security implications.

I've refactored the CL to avoid changing `PageTransitionIsWebTriggerable()` entirely:

  • Added a new `is_reload_navigation` field to `network::ResourceRequest`, populated from `NavigationTypeUtils::IsReload(common_params->navigation_type)` in `NavigationURLLoaderImpl`
  • Use this field in `fetch_request_type_converters.cc` instead of checking `transition_type == PAGE_TRANSITION_RELOAD`
  • Reverted all problematic changes - `PAGE_TRANSITION_RELOAD` remains browser-initiated only

The `Request.isReloadNavigation` spec requirement is now satisfied via this dedicated field, while keeping existing security invariants intact.

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Alex Moshchuk
  • Daniel Cheng
  • Yoav Weiss (@Shopify)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
Gerrit-Change-Number: 7137783
Gerrit-PatchSet: 18
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Feb 2026 23:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alex Moshchuk <ale...@chromium.org>
Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>
Comment-In-Reply-To: Adam Rice <ri...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Moshchuk (Gerrit)

unread,
Feb 4, 2026, 6:31:12 PMFeb 4
to Helmut Januschka, Chromium Metrics Reviews, Daniel Cheng, Adam Rice, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Adam Rice, Daniel Cheng, Helmut Januschka and Yoav Weiss (@Shopify)

Alex Moshchuk added 2 comments

File content/browser/security_exploit_browsertest.cc
Alex Moshchuk

Thanks, that resolves my immediate concerns with changes in //content, but I'll defer to ricea@ and others to actually review this from the networking and fetch API perspective. Happy to approve content when everybody's happy.

File content/renderer/render_frame_impl.cc
Line 605, Patchset 18 (Latest): info->navigation_type == blink::kWebNavigationTypeFormResubmittedReload) {
Alex Moshchuk . unresolved

Why is this change necessary, and what are its implications?

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Daniel Cheng
  • Helmut Januschka
  • Yoav Weiss (@Shopify)
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Wed, 04 Feb 2026 23:31:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>
Comment-In-Reply-To: Alex Moshchuk <ale...@chromium.org>
Comment-In-Reply-To: Adam Rice <ri...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Feb 5, 2026, 4:08:45 PMFeb 5
to Helmut Januschka, Chromium Metrics Reviews, Alex Moshchuk, Daniel Cheng, Adam Rice, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Adam Rice, Alex Moshchuk, Daniel Cheng and Yoav Weiss (@Shopify)

Helmut Januschka added 1 comment

File content/renderer/render_frame_impl.cc
Line 605, Patchset 18 (Latest): info->navigation_type == blink::kWebNavigationTypeFormResubmittedReload) {
Alex Moshchuk . resolved

Why is this change necessary, and what are its implications?

Helmut Januschka

This makes form-resubmitted reloads map to NavigationType::RELOAD, instead of falling back to DIFFERENT_DOCUMENT. I need that so Request.isReloadNavigation is true for real reloads, including form resubmissions, per the Fetch spec.

Implications should be limited to code that checks NavigationTypeUtils::IsReload and only for these already-reload navigations. It does not change page transition or renderer/browser initiation semantics beyond marking them as reloads, consistent with existing behavior for non-form reloads.

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Alex Moshchuk
  • Daniel Cheng
  • Yoav Weiss (@Shopify)
Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Feb 2026 21:08:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alex Moshchuk <ale...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Feb 9, 2026, 4:03:51 PMFeb 9
to Helmut Januschka, Chromium Metrics Reviews, Alex Moshchuk, Daniel Cheng, Adam Rice, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Adam Rice, Alex Moshchuk, Daniel Cheng and Yoav Weiss (@Shopify)

Helmut Januschka added 1 comment

Patchset-level comments
File-level comment, Patchset 18 (Latest):
Helmut Januschka . resolved

@ri...@chromium.org, ping. i have a question once you CR+1. i'll wait and send: https://chromestatus.com/feature/5154214529597440 to API-OWNERS and once that is green, the CL can land? is that understanding valid?

Gerrit-Comment-Date: Mon, 09 Feb 2026 21:03:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Adam Rice (Gerrit)

unread,
Feb 13, 2026, 7:50:23 AMFeb 13
to Helmut Januschka, Chromium Metrics Reviews, Alex Moshchuk, Daniel Cheng, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Daniel Cheng, Helmut Januschka and Yoav Weiss (@Shopify)

Adam Rice voted and added 2 comments

Votes added by Adam Rice

Code-Review+1

2 comments

Patchset-level comments
Adam Rice . resolved

lgtm, sorry to keep you waiting!

File third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
Line 7535, Patchset 18 (Latest): getter isReloadNavigation
Adam Rice . unresolved

Oh, right, this is web visible, so you'll need API owner approval to land, or put it in //third_party/blink/renderer/platform/runtime_enabled_features.json5 as experimental until you have approval.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Helmut Januschka
  • Yoav Weiss (@Shopify)
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
    Gerrit-Change-Number: 7137783
    Gerrit-PatchSet: 18
    Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
    Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
    Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Fri, 13 Feb 2026 12:49:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Helmut Januschka (Gerrit)

    unread,
    Feb 14, 2026, 4:27:23 PMFeb 14
    to Helmut Januschka, Adam Rice, Chromium Metrics Reviews, Alex Moshchuk, Daniel Cheng, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Adam Rice, Alex Moshchuk, Daniel Cheng and Yoav Weiss (@Shopify)

    Helmut Januschka added 2 comments

    File content/browser/security_exploit_browsertest.cc
    Line 1626, Patchset 16 (Parent): ui::PAGE_TRANSITION_RELOAD,
    Adam Rice . resolved
    Helmut Januschka

    Done

    File third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
    Line 7535, Patchset 18: getter isReloadNavigation
    Adam Rice . resolved

    Oh, right, this is web visible, so you'll need API owner approval to land, or put it in //third_party/blink/renderer/platform/runtime_enabled_features.json5 as experimental until you have approval.

    Helmut Januschka

    its feature flagged now

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Rice
    • Alex Moshchuk
    • Daniel Cheng
    • Yoav Weiss (@Shopify)
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
      Gerrit-Change-Number: 7137783
      Gerrit-PatchSet: 20
      Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
      Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
      Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
      Gerrit-Attention: Adam Rice <ri...@chromium.org>
      Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Comment-Date: Sat, 14 Feb 2026 21:27:09 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Alex Moshchuk <ale...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Adam Rice (Gerrit)

      unread,
      Feb 16, 2026, 9:39:08 AMFeb 16
      to Helmut Januschka, Chromium Metrics Reviews, Alex Moshchuk, Daniel Cheng, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
      Attention needed from Alex Moshchuk, Daniel Cheng, Helmut Januschka and Yoav Weiss (@Shopify)

      Adam Rice voted and added 1 comment

      Votes added by Adam Rice

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 20 (Latest):
      Adam Rice . resolved

      Thanks. lgtm.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alex Moshchuk
      • Daniel Cheng
      • Helmut Januschka
      • Yoav Weiss (@Shopify)
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
        Gerrit-Change-Number: 7137783
        Gerrit-PatchSet: 20
        Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
        Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
        Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
        Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
        Gerrit-Comment-Date: Mon, 16 Feb 2026 14:38:39 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Daniel Cheng (Gerrit)

        unread,
        Feb 27, 2026, 2:37:34 AM (5 days ago) Feb 27
        to Helmut Januschka, Daniel Cheng, Adam Rice, Chromium Metrics Reviews, Alex Moshchuk, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
        Attention needed from Alex Moshchuk, Helmut Januschka and Yoav Weiss (@Shopify)

        Daniel Cheng voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex Moshchuk
        • Helmut Januschka
        • Yoav Weiss (@Shopify)
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
        Gerrit-Change-Number: 7137783
        Gerrit-PatchSet: 21
        Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
        Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
        Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
        Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Comment-Date: Fri, 27 Feb 2026 07:37:27 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Alex Moshchuk (Gerrit)

        unread,
        Feb 27, 2026, 12:48:13 PM (4 days ago) Feb 27
        to Helmut Januschka, Daniel Cheng, Adam Rice, Chromium Metrics Reviews, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
        Attention needed from Helmut Januschka and Yoav Weiss (@Shopify)

        Alex Moshchuk voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Comment-Date: Fri, 27 Feb 2026 17:48:04 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Crisrael Lucero (Gerrit)

        unread,
        Mar 2, 2026, 12:48:26 PM (yesterday) Mar 2
        to Helmut Januschka, Alex Moshchuk, Daniel Cheng, Adam Rice, Chromium Metrics Reviews, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
        Attention needed from Helmut Januschka and Yoav Weiss (@Shopify)

        Crisrael Lucero voted and added 2 comments

        Votes added by Crisrael Lucero

        Code-Review+1

        2 comments

        Patchset-level comments
        File-level comment, Patchset 21 (Latest):
        Crisrael Lucero . resolved

        LGTM % nit!

        File tools/metrics/histograms/metadata/network/enums.xml
        Line 1476, Patchset 21 (Latest): <int value="68" label="is_reload_navigation"/>
        Crisrael Lucero . unresolved

        nit: Is this supposed to be 67 instead of 68?

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Helmut Januschka
        • Yoav Weiss (@Shopify)
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
        Gerrit-Change-Number: 7137783
        Gerrit-PatchSet: 21
        Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
        Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
        Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
        Gerrit-Reviewer: Crisrael Lucero <cris...@google.com>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
        Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
        Gerrit-Comment-Date: Mon, 02 Mar 2026 17:48:20 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Crisrael Lucero (Gerrit)

        unread,
        Mar 2, 2026, 12:49:43 PM (yesterday) Mar 2
        to Helmut Januschka, Alex Moshchuk, Daniel Cheng, Adam Rice, Chromium Metrics Reviews, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
        Attention needed from Helmut Januschka and Yoav Weiss (@Shopify)

        Crisrael Lucero added 1 comment

        File tools/metrics/histograms/metadata/network/enums.xml
        Line 1476, Patchset 21 (Latest): <int value="68" label="is_reload_navigation"/>
        Crisrael Lucero . resolved

        nit: Is this supposed to be 67 instead of 68?

        Crisrael Lucero

        Nevermind! I see that the previous Enum for 67 was deprecated. Ignore!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Helmut Januschka
        • Yoav Weiss (@Shopify)
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
          Gerrit-Change-Number: 7137783
          Gerrit-PatchSet: 21
          Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
          Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
          Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
          Gerrit-Reviewer: Crisrael Lucero <cris...@google.com>
          Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
          Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
          Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Comment-Date: Mon, 02 Mar 2026 17:49:36 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Crisrael Lucero <cris...@google.com>
          satisfied_requirement
          open
          diffy

          Blink W3C Test Autoroller (Gerrit)

          unread,
          Mar 2, 2026, 12:54:22 PM (yesterday) Mar 2
          to Helmut Januschka, Crisrael Lucero, Alex Moshchuk, Daniel Cheng, Adam Rice, Chromium Metrics Reviews, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
          Attention needed from Helmut Januschka and Yoav Weiss (@Shopify)

          Message from Blink W3C Test Autoroller

          Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/58181.

          When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

          WPT Export docs:
          https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
          Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
          Gerrit-Comment-Date: Mon, 02 Mar 2026 17:54:13 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: No
          satisfied_requirement
          open
          diffy

          Crisrael Lucero (Gerrit)

          unread,
          Mar 2, 2026, 6:06:26 PM (21 hours ago) Mar 2
          to Helmut Januschka, Blink W3C Test Autoroller, Alex Moshchuk, Daniel Cheng, Adam Rice, Chromium Metrics Reviews, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
          Attention needed from Helmut Januschka and Yoav Weiss (@Shopify)

          Crisrael Lucero added 1 comment

          File tools/metrics/histograms/metadata/network/enums.xml
          Line 1476, Patchset 21 (Latest): <int value="68" label="is_reload_navigation"/>
          Crisrael Lucero . unresolved

          Sorry for thrash- but could you actually add a line above this for consistency:

          ```
          <int value="67" label="allow_unsafe_redirect_schemes (deprecated)"/>
          ```

          Thanks!

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Helmut Januschka
          • Yoav Weiss (@Shopify)
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement is not satisfiedNo-Unresolved-Comments
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
            Gerrit-Change-Number: 7137783
            Gerrit-PatchSet: 21
            Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
            Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
            Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
            Gerrit-Reviewer: Crisrael Lucero <cris...@google.com>
            Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
            Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
            Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
            Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
            Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
            Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
            Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
            Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
            Gerrit-Comment-Date: Mon, 02 Mar 2026 23:06:19 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Helmut Januschka (Gerrit)

            unread,
            Mar 2, 2026, 6:19:18 PM (21 hours ago) Mar 2
            to Helmut Januschka, Blink W3C Test Autoroller, Crisrael Lucero, Alex Moshchuk, Daniel Cheng, Adam Rice, Chromium Metrics Reviews, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
            Attention needed from Yoav Weiss (@Shopify)

            Helmut Januschka added 1 comment

            File tools/metrics/histograms/metadata/network/enums.xml
            Line 1476, Patchset 21: <int value="68" label="is_reload_navigation"/>
            Crisrael Lucero . resolved

            Sorry for thrash- but could you actually add a line above this for consistency:

            ```
            <int value="67" label="allow_unsafe_redirect_schemes (deprecated)"/>
            ```

            Thanks!

            Helmut Januschka

            Done

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Yoav Weiss (@Shopify)
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
              Gerrit-Change-Number: 7137783
              Gerrit-PatchSet: 21
              Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
              Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
              Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
              Gerrit-Reviewer: Crisrael Lucero <cris...@google.com>
              Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
              Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
              Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
              Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
              Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
              Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
              Gerrit-Comment-Date: Mon, 02 Mar 2026 23:19:04 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: No
              Comment-In-Reply-To: Crisrael Lucero <cris...@google.com>
              satisfied_requirement
              open
              diffy

              Helmut Januschka (Gerrit)

              unread,
              11:33 AM (4 hours ago) 11:33 AM
              to Helmut Januschka, Blink W3C Test Autoroller, Crisrael Lucero, Alex Moshchuk, Daniel Cheng, Adam Rice, Chromium Metrics Reviews, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
              Attention needed from Yoav Weiss (@Shopify)

              Helmut Januschka voted Commit-Queue+2

              Commit-Queue+2
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Yoav Weiss (@Shopify)
              Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
              Gerrit-Change-Number: 7137783
              Gerrit-PatchSet: 22
              Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
              Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
              Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
              Gerrit-Reviewer: Crisrael Lucero <cris...@google.com>
              Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
              Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
              Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
              Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
              Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
              Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
              Gerrit-Comment-Date: Tue, 03 Mar 2026 16:33:30 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              open
              diffy

              Chromium LUCI CQ (Gerrit)

              unread,
              12:29 PM (3 hours ago) 12:29 PM
              to Helmut Januschka, Blink W3C Test Autoroller, Crisrael Lucero, Alex Moshchuk, Daniel Cheng, Adam Rice, Chromium Metrics Reviews, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

              Chromium LUCI CQ submitted the change with unreviewed changes

              Unreviewed changes

              21 is the latest approved patch-set.
              The change was submitted with unreviewed changes in the following files:

              ```
              The name of the file: tools/metrics/histograms/metadata/network/enums.xml
              Insertions: 1, Deletions: 0.

              @@ -1473,6 +1473,7 @@
                 <int value="64" label="expected_public_keys"/>
                 <int value="65" label="permissions_policy"/>
                 <int value="66" label="client_side_content_decoding_enabled"/>
              +  <int value="67" label="allow_unsafe_redirect_schemes (deprecated)"/>

                 <int value="68" label="is_reload_navigation"/>
               </enum>
               
              ```

              Change information

              Commit message:
              Add Request.isReloadNavigation attribute

              Spec: https://fetch.spec.whatwg.org/#dom-request-isreloadnavigation
              Bug: 40487194
              Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
              Reviewed-by: Adam Rice <ri...@chromium.org>
              Commit-Queue: Helmut Januschka <hel...@januschka.com>
              Reviewed-by: Daniel Cheng <dch...@chromium.org>
              Reviewed-by: Crisrael Lucero <cris...@google.com>
              Reviewed-by: Alex Moshchuk <ale...@chromium.org>
              Cr-Commit-Position: refs/heads/main@{#1593278}
              Files:
              • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
              • M content/browser/cache_storage/cache_storage.proto
              • M content/browser/cache_storage/cache_storage_cache.cc
              • M content/browser/loader/navigation_url_loader_impl.cc
              • M content/browser/renderer_host/navigation_request.cc
              • M content/common/fetch/fetch_api_request.proto
              • M content/common/fetch/fetch_api_request_proto.cc
              • M content/common/fetch/fetch_request_type_converters.cc
              • M content/renderer/render_frame_impl.cc
              • M services/network/prefetch_matches.cc
              • M services/network/public/cpp/resource_request.cc
              • M services/network/public/cpp/resource_request.h
              • M services/network/public/cpp/url_request_mojom_traits.cc
              • M services/network/public/cpp/url_request_mojom_traits.h
              • M services/network/public/cpp/url_request_mojom_traits_perftest.cc
              • M services/network/public/cpp/url_request_mojom_traits_unittest.cc
              • M services/network/public/mojom/url_request.mojom
              • M third_party/blink/renderer/core/fetch/fetch_request_data.cc
              • M third_party/blink/renderer/core/fetch/fetch_request_data.h
              • M third_party/blink/renderer/core/fetch/request.cc
              • M third_party/blink/renderer/core/fetch/request.h
              • M third_party/blink/renderer/core/fetch/request.idl
              • M third_party/blink/renderer/platform/runtime_enabled_features.json5
              • D third_party/blink/web_tests/external/wpt/fetch/api/idlharness.https.any-expected.txt
              • D third_party/blink/web_tests/external/wpt/fetch/api/idlharness.https.any.serviceworker-expected.txt
              • D third_party/blink/web_tests/external/wpt/fetch/api/idlharness.https.any.sharedworker-expected.txt
              • D third_party/blink/web_tests/external/wpt/fetch/api/idlharness.https.any.worker-expected.txt
              • D third_party/blink/web_tests/external/wpt/fetch/api/request/request-reset-attributes.https-expected.txt
              • D third_party/blink/web_tests/external/wpt/fetch/api/request/request-structure.any-expected.txt
              • D third_party/blink/web_tests/external/wpt/fetch/api/request/request-structure.any.serviceworker-expected.txt
              • D third_party/blink/web_tests/external/wpt/fetch/api/request/request-structure.any.sharedworker-expected.txt
              • D third_party/blink/web_tests/external/wpt/fetch/api/request/request-structure.any.worker-expected.txt
              • D third_party/blink/web_tests/external/wpt/service-workers/cache-storage/cache-keys-attributes-for-service-worker.https-expected.txt
              • D third_party/blink/web_tests/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt
              • M third_party/blink/web_tests/external/wpt/service-workers/service-worker/fetch-event.https.html
              • M third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
              • M third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
              • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
              • M third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
              • M tools/metrics/histograms/metadata/network/enums.xml
              Change size: M
              Delta: 40 files changed, 61 insertions(+), 86 deletions(-)
              Branch: refs/heads/main
              Submit Requirements:
              • requirement satisfiedCode-Review: +1 by Adam Rice, +1 by Alex Moshchuk, +1 by Daniel Cheng, +1 by Crisrael Lucero
              Open in Gerrit
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: merged
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
              Gerrit-Change-Number: 7137783
              Gerrit-PatchSet: 23
              Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
              Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
              Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Crisrael Lucero <cris...@google.com>
              Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
              Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
              open
              diffy
              satisfied_requirement

              Blink W3C Test Autoroller (Gerrit)

              unread,
              2:38 PM (1 hour ago) 2:38 PM
              to Helmut Januschka, Chromium LUCI CQ, Crisrael Lucero, Alex Moshchuk, Daniel Cheng, Adam Rice, Chromium Metrics Reviews, Yoav Weiss (@Shopify), Hiroki Nakagawa, AyeAye, chromium...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, creis...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, ashleynewson+w...@chromium.org, android-web...@chromium.org, peter+watch...@chromium.org, kenjibah...@chromium.org, shimazu+se...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

              Message from Blink W3C Test Autoroller

              The exported PR, https://github.com/web-platform-tests/wpt/pull/58181, has failed the following check(s) on GitHub:

              wpt-firefox-nightly-stability (https://github.com/web-platform-tests/wpt/runs/65603641380)

              These failures will block the export. They may represent new or existing problems; please take a look at the output and see if it can be fixed. Unresolved failures will be looked at by the Ecosystem-Infra sheriff after this CL has been landed in Chromium; if you need earlier help please contact blin...@chromium.org.

              Any suggestions to improve this service are welcome; crbug.com/1027618.

              Gerrit CL SHA: Latest

              Open in Gerrit

              Related details

              Attention set is empty
              Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: Ib03c3fdb8762cd8df7ffc40f8565d17eadc4a562
              Gerrit-Change-Number: 7137783
              Gerrit-PatchSet: 23
              Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
              Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
              Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Crisrael Lucero <cris...@google.com>
              Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
              Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
              Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
              Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
              Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
              Gerrit-Comment-Date: Tue, 03 Mar 2026 19:38:52 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: No
              satisfied_requirement
              open
              diffy
              Reply all
              Reply to author
              Forward
              0 new messages