Delete network::features::kVisibilityAwareResourceScheduler. [chromium/src : main]
0 views
Skip to first unread message
mmenke (Gerrit)
Sep 3, 2025, 5:48:29 PM (5 days ago) Sep 3
to Kenichi Ishibashi, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Kenichi Ishibashi
mmenke added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
mmenke . resolved
[bashi] I assume this can all be deleted, given the TODO about removing it, and that this was landed 2 years ago?
Related details
Attention is currently required from:
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
Sep 3, 2025, 6:19:08 PM (5 days ago) Sep 3
to Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from mmenke
Kenichi Ishibashi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kenichi Ishibashi
| Code-Review | +1 |
1 comment
Patchset-level comments
Kenichi Ishibashi . resolved
lgtm, thank you for the clean-up! I should have removed these dead code.
(P.S. Today I'm ooo sick so I may not be able to make progress, but thank you for investigating HEv3 bugs).
Related details
Attention is currently required from:
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Sep 3, 2025, 6:57:02 PM (5 days ago) Sep 3
to Kenichi Ishibashi, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
mmenke added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Kenichi Ishibashi . resolved
lgtm, thank you for the clean-up! I should have removed these dead code.
(P.S. Today I'm ooo sick so I may not be able to make progress, but thank you for investigating HEv3 bugs).
mmenke
Sorry to hear it, hope you feel better soon. I will be sending out what I hope is a crash fix later tonight, but there's no rush to review it.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Sep 3, 2025, 6:59:52 PM (5 days ago) Sep 3
to Chromium IPC Reviews, Jonathan Ross, Hiroshige Hayashizaki, Kenichi Ishibashi, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Chromium IPC Reviews, Hiroshige Hayashizaki and Jonathan Ross
mmenke added 1 comment![]( "Open in Gerrit")
Patchset-level comments
mmenke . resolved
[+chrome-ipc-reviews] Please review network_context.mojom (just deleting a method).
[+jonross] Please review content/browser/renderer_host/render_frame_host_impl.cc
[+hiroshige] Please review third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h
Note that for all three of those files, this is a straight revert of https://chromium-review.googlesource.com/c/chromium/src/+/4650930,
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Hiroshige Hayashizaki
- Jonathan Ross
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Sep 3, 2025, 7:04:26 PM (5 days ago) Sep 3
to Chromium IPC Reviews, Dominic Farolino, Jonathan Ross, Hiroshige Hayashizaki, Kenichi Ishibashi, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Dominic Farolino, Hiroshige Hayashizaki and Jonathan Ross
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: d...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): d...@chromium.org
Reviewer source(s):
d...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Dominic Farolino
- Hiroshige Hayashizaki
- Jonathan Ross
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroshige Hayashizaki (Gerrit)
Sep 3, 2025, 10:03:58 PM (5 days ago) Sep 3
to Chromium IPC Reviews, Dominic Farolino, Jonathan Ross, Kenichi Ishibashi, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Dominic Farolino, Jonathan Ross and mmenke
Hiroshige Hayashizaki voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hiroshige Hayashizaki
| Code-Review | +1 |
1 comment
Patchset-level comments
Hiroshige Hayashizaki . resolved
third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h LGTM.
Related details
Attention is currently required from:
- Dominic Farolino
- Jonathan Ross
- mmenke
Dominic Farolino (Gerrit)
Sep 4, 2025, 9:27:23 AM (5 days ago) Sep 4
to Hiroshige Hayashizaki, Chromium IPC Reviews, Jonathan Ross, Kenichi Ishibashi, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Jonathan Ross and mmenke
Dominic Farolino voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jonathan Ross
- mmenke
Jonathan Ross (Gerrit)
Sep 4, 2025, 9:27:29 AM (5 days ago) Sep 4
to Dominic Farolino, Hiroshige Hayashizaki, Chromium IPC Reviews, Kenichi Ishibashi, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from mmenke
Jonathan Ross voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Sep 4, 2025, 9:29:15 AM (5 days ago) Sep 4
to Jonathan Ross, Dominic Farolino, Hiroshige Hayashizaki, Chromium IPC Reviews, Kenichi Ishibashi, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
mmenke voted and added 1 comment![]( "Open in Gerrit")
Votes added by mmenke
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 4, 2025, 9:32:29 AM (5 days ago) Sep 4
to Jonathan Ross, Dominic Farolino, Hiroshige Hayashizaki, Chromium IPC Reviews, Kenichi Ishibashi, AyeAye, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, fenced-fra...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Delete network::features::kVisibilityAwareResourceScheduler.
Also delete all code gated on it. It was never launched, and has a TODO
to remove it.
This is basically a revert of
https://chromium-review.googlesource.com/c/chromium/src/+/4650930,
addressing conflicts, and keeping a minor cleanup or two.
Fixed: 356624849
Change-Id: I23112f7a68d1b11f9d7351c8aa6d4ffa75413aaa
Commit-Queue: mmenke <mme...@chromium.org>
Reviewed-by: Jonathan Ross <jon...@chromium.org>
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Reviewed-by: Dominic Farolino <d...@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiro...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1510863}
Files:
- M content/browser/loader/resource_scheduler_browsertest.cc
- M content/browser/renderer_host/render_frame_host_impl.cc
- M services/network/network_context.cc
- M services/network/network_context.h
- M services/network/public/cpp/features.cc
- M services/network/public/cpp/features.h
- M services/network/public/mojom/network_context.mojom
- M services/network/resource_scheduler/resource_scheduler.cc
- M services/network/resource_scheduler/resource_scheduler.h
- M services/network/resource_scheduler/resource_scheduler_unittest.cc
- M services/network/test/test_network_context.h
- M third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h
Change size: L
Delta: 12 files changed, 17 insertions(+), 251 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dominic Farolino, +1 by Hiroshige Hayashizaki, +1 by Jonathan Ross, +1 by Kenichi Ishibashi
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages