Remove browser to cert verifier plumbing for sha1_local_anchors_enabled [chromium/src : main]

0 views
Skip to first unread message

Matt Mueller (Gerrit)

unread,
Feb 25, 2026, 9:45:07 PM (6 days ago) Feb 25
to Matt Mueller, Mustafa Emre Acer, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Mustafa Emre Acer

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Mustafa Emre Acer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5e6381217d83aa411f092de4c71946cd9c586c45
Gerrit-Change-Number: 7609979
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Mueller <ma...@chromium.org>
Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>
Gerrit-Attention: Mustafa Emre Acer <mea...@chromium.org>
Gerrit-Comment-Date: Thu, 26 Feb 2026 02:45:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mustafa Emre Acer (Gerrit)

unread,
Feb 26, 2026, 12:27:48 PM (5 days ago) Feb 26
to Matt Mueller, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
Attention needed from Matt Mueller

Mustafa Emre Acer voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Matt Mueller
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5e6381217d83aa411f092de4c71946cd9c586c45
    Gerrit-Change-Number: 7609979
    Gerrit-PatchSet: 1
    Gerrit-Owner: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>
    Gerrit-Attention: Matt Mueller <ma...@chromium.org>
    Gerrit-Comment-Date: Thu, 26 Feb 2026 17:27:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Matt Mueller (Gerrit)

    unread,
    Feb 26, 2026, 5:45:47 PM (5 days ago) Feb 26
    to Matt Mueller, Kenichi Ishibashi, Mustafa Emre Acer, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
    Attention needed from Kenichi Ishibashi

    Matt Mueller added 1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Matt Mueller . resolved

    +bashi for services/network/ OWNERS

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kenichi Ishibashi
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5e6381217d83aa411f092de4c71946cd9c586c45
    Gerrit-Change-Number: 7609979
    Gerrit-PatchSet: 1
    Gerrit-Owner: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>
    Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Comment-Date: Thu, 26 Feb 2026 22:45:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kenichi Ishibashi (Gerrit)

    unread,
    Feb 26, 2026, 7:09:59 PM (5 days ago) Feb 26
    to Matt Mueller, Mustafa Emre Acer, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org
    Attention needed from Matt Mueller

    Kenichi Ishibashi voted and added 1 comment

    Votes added by Kenichi Ishibashi

    Code-Review+1

    1 comment

    Patchset-level comments
    Kenichi Ishibashi . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Matt Mueller
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5e6381217d83aa411f092de4c71946cd9c586c45
    Gerrit-Change-Number: 7609979
    Gerrit-PatchSet: 1
    Gerrit-Owner: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>
    Gerrit-Attention: Matt Mueller <ma...@chromium.org>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 00:09:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Matt Mueller (Gerrit)

    unread,
    Mar 2, 2026, 5:38:07 PM (18 hours ago) Mar 2
    to Matt Mueller, Kenichi Ishibashi, Mustafa Emre Acer, Chromium LUCI CQ, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

    Matt Mueller voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5e6381217d83aa411f092de4c71946cd9c586c45
    Gerrit-Change-Number: 7609979
    Gerrit-PatchSet: 1
    Gerrit-Owner: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>
    Gerrit-Comment-Date: Mon, 02 Mar 2026 22:38:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 2, 2026, 7:32:49 PM (16 hours ago) Mar 2
    to Matt Mueller, Kenichi Ishibashi, Mustafa Emre Acer, chromium...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove browser to cert verifier plumbing for sha1_local_anchors_enabled

    The rest of the implementation will be removed in followups.
    Bug: 487349971
    Change-Id: I5e6381217d83aa411f092de4c71946cd9c586c45
    Commit-Queue: Matt Mueller <ma...@chromium.org>
    Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
    Reviewed-by: Mustafa Emre Acer <mea...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1592845}
    Files:
    • M chrome/browser/ssl/ssl_browsertest.cc
    • M net/cert/cert_verifier.h
    • M net/cert/multi_threaded_cert_verifier.cc
    • M net/cert/multi_threaded_cert_verifier_unittest.cc
    • M services/network/public/cpp/cert_verifier/cert_verifier_mojom_traits.cc
    • M services/network/public/cpp/cert_verifier/cert_verifier_mojom_traits.h
    • M services/network/public/cpp/cert_verifier/cert_verifier_mojom_traits_unittest.cc
    • M services/network/public/mojom/cert_verifier_service.mojom
    • M services/network/public/mojom/ssl_config.mojom
    • M services/network/ssl_config_service_mojo_unittest.cc
    • M services/network/ssl_config_type_converter.cc
    Change size: S
    Delta: 11 files changed, 2 insertions(+), 39 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mustafa Emre Acer, +1 by Kenichi Ishibashi
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5e6381217d83aa411f092de4c71946cd9c586c45
    Gerrit-Change-Number: 7609979
    Gerrit-PatchSet: 2
    Gerrit-Owner: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Matt Mueller <ma...@chromium.org>
    Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages