Add feature flags for SourceSpecificMulticastInDirectSockets [chromium/src : main]

[Omar Ramadan (Gerrit)]

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 27 (Latest):

Omar Ramadan . resolved

Ready for review.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 27

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 14 Jan 2026 21:29:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Ian Kilpatrick

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 43 (Latest):

Omar Ramadan . resolved

kindly requesting review

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 43

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Thu, 29 Jan 2026 05:19:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Ian Kilpatrick (Gerrit)]

Attention needed from Omar Ramadan

Ian Kilpatrick voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 43

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Thu, 29 Jan 2026 05:27:46 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 46 (Latest):

Omar Ramadan . resolved

can I get another +1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 46

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Mon, 02 Feb 2026 21:03:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Ian Kilpatrick (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Ian Kilpatrick voted and added 1 comment

Votes added by Ian Kilpatrick

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 46 (Latest):

Ian Kilpatrick . resolved

+Adam who reviewed other patches for additional +1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 46

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Feb 2026 08:22:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Adam Rice (Gerrit)]

Attention needed from Omar Ramadan

Adam Rice voted and added 2 comments

Votes added by Adam Rice

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 46 (Latest):

Adam Rice . resolved

lgtm

File chrome/browser/flag_descriptions.h

Line 2792, Patchset 46 (Latest): "https://github.com/WICG/direct-sockets/blob/main/docs/"

Adam Rice . unresolved

Thanks for providing the link! That's helpful to developers.

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 46

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Mon, 16 Feb 2026 15:30:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Adam Rice (Gerrit)]

Attention needed from Omar Ramadan

Adam Rice added 1 comment

File chrome/browser/flag_descriptions.h

Line 2792, Patchset 46 (Latest): "https://github.com/WICG/direct-sockets/blob/main/docs/"

Adam Rice . resolved

Thanks for providing the link! That's helpful to developers.

Adam Rice

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 46

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Mon, 16 Feb 2026 15:30:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice and Ian Kilpatrick

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 47 (Latest):

Omar Ramadan . resolved

rebased + resolved merge conflicts. ready for submission.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 47

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 09:22:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Andrew Rayskiy (Gerrit)]

Attention needed from Adam Rice, Ian Kilpatrick and Omar Ramadan

Andrew Rayskiy voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Ian Kilpatrick
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 47

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 10:37:59 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Ian Kilpatrick (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5182, Patchset 47 (Latest): status: "experimental",

Ian Kilpatrick . unresolved

Is this flag ready to be enabled with --experimental-web-platform-features enabled?

Lots of developers have this flag enabled on Stable, so if it'll accidentally crash the browser or still in development its not ready for this status yet.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 47

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 17:52:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice and Ian Kilpatrick

Omar Ramadan added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5182, Patchset 47 (Latest): status: "experimental",

Ian Kilpatrick . unresolved

Is this flag ready to be enabled with --experimental-web-platform-features enabled?

Lots of developers have this flag enabled on Stable, so if it'll accidentally crash the browser or still in development its not ready for this status yet.

Omar Ramadan

Yes, it was run tested on target platforms: OSX (ARM+Intel), Windows and Linux (Intel)

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 47

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 17:59:14 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>

[Ian Kilpatrick (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5182, Patchset 47 (Latest): status: "experimental",

Ian Kilpatrick . unresolved

Is this flag ready to be enabled with --experimental-web-platform-features enabled?

Lots of developers have this flag enabled on Stable, so if it'll accidentally crash the browser or still in development its not ready for this status yet.

Omar Ramadan

Yes, it was run tested on target platforms: OSX (ARM+Intel), Windows and Linux (Intel)

Ian Kilpatrick

How was it tested if nothing uses the Blink flag yet?

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 47

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 18:03:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>

Comment-In-Reply-To: Omar Ramadan <om...@blockcast.net>

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Omar Ramadan added 1 comment

Message

Oh sorry this is the first feature I'm shipping so still piecing together how this all works. I've tested it with --enable-features=SourceSpecificMulticastInDirectSockets its gated behind `

1 comment

Patchset-level comments

File-level comment, Patchset 47 (Latest):

Omar Ramadan . resolved

Oh sorry this is the first feature I'm shipping so still piecing together how this all works. I've tested it with --enable-features=SourceSpecificMulticastInDirectSockets its gated behind `

Gerrit-Comment-Date: Mon, 23 Feb 2026 20:26:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice and Ian Kilpatrick

Omar Ramadan added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5182, Patchset 47 (Latest): status: "experimental",

Ian Kilpatrick . resolved

Is this flag ready to be enabled with --experimental-web-platform-features enabled?

Lots of developers have this flag enabled on Stable, so if it'll accidentally crash the browser or still in development its not ready for this status yet.

Omar Ramadan

Yes, it was run tested on target platforms: OSX (ARM+Intel), Windows and Linux (Intel)

Ian Kilpatrick

How was it tested if nothing uses the Blink flag yet?

Omar Ramadan

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 47

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 20:27:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Ian Kilpatrick (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5182, Patchset 47 (Latest): status: "experimental",

Ian Kilpatrick . unresolved

Is this flag ready to be enabled with --experimental-web-platform-features enabled?

Lots of developers have this flag enabled on Stable, so if it'll accidentally crash the browser or still in development its not ready for this status yet.

Omar Ramadan

Yes, it was run tested on target platforms: OSX (ARM+Intel), Windows and Linux (Intel)

Ian Kilpatrick

How was it tested if nothing uses the Blink flag yet?

Omar Ramadan

Acknowledged

Ian Kilpatrick

So (I'm a little confused) - I don't think you need the Blink-flag component of this patch then if nothing is going to use it? E.g. is the feature already complete?

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 47

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 21:15:23 +0000

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice and Ian Kilpatrick

Omar Ramadan added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5182, Patchset 47 (Latest): status: "experimental",

Ian Kilpatrick . unresolved

Is this flag ready to be enabled with --experimental-web-platform-features enabled?

Lots of developers have this flag enabled on Stable, so if it'll accidentally crash the browser or still in development its not ready for this status yet.

Omar Ramadan

Yes, it was run tested on target platforms: OSX (ARM+Intel), Windows and Linux (Intel)

Ian Kilpatrick

How was it tested if nothing uses the Blink flag yet?

Omar Ramadan

Acknowledged

Ian Kilpatrick

So (I'm a little confused) - I don't think you need the Blink-flag component of this patch then if nothing is going to use it? E.g. is the feature already complete?

Omar Ramadan

Yes, the feature is complete. The flag IS used — patch 2's IDL gates on it directly:
```
// multicast_controller.idl:6-8
dictionary MulticastGroupOptions {
  [RuntimeEnabled=SourceSpecificMulticastInDirectSockets]
  DOMString sourceAddress;
};

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 47

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 21:32:17 +0000

[Ian Kilpatrick (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5182, Patchset 47 (Latest): status: "experimental",

Ian Kilpatrick . unresolved

Is this flag ready to be enabled with --experimental-web-platform-features enabled?

Lots of developers have this flag enabled on Stable, so if it'll accidentally crash the browser or still in development its not ready for this status yet.

Omar Ramadan

Yes, it was run tested on target platforms: OSX (ARM+Intel), Windows and Linux (Intel)

Ian Kilpatrick

How was it tested if nothing uses the Blink flag yet?

Omar Ramadan

Acknowledged

Ian Kilpatrick

So (I'm a little confused) - I don't think you need the Blink-flag component of this patch then if nothing is going to use it? E.g. is the feature already complete?

Omar Ramadan

Yes, the feature is complete. The flag IS used — patch 2's IDL gates on it directly:
```
// multicast_controller.idl:6-8
dictionary MulticastGroupOptions {
  [RuntimeEnabled=SourceSpecificMulticastInDirectSockets]
  DOMString sourceAddress;
};

Ian Kilpatrick

Ah - Does that compile? This patch should be placed earlier in the chain.

Also you've introduced a behaviour change in `joinGroup`/`leaveGroup` without the flag by allowing an extra arg. See:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/RuntimeEnabledFeatures.md;l=196;drc=e415911248aaf70d148fb40d7876ab66f702ddcb

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 47

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Feb 2026 22:33:46 +0000

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice and Ian Kilpatrick

Omar Ramadan added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5182, Patchset 47: status: "experimental",

Ian Kilpatrick . resolved

Is this flag ready to be enabled with --experimental-web-platform-features enabled?

Lots of developers have this flag enabled on Stable, so if it'll accidentally crash the browser or still in development its not ready for this status yet.

Omar Ramadan

Yes, it was run tested on target platforms: OSX (ARM+Intel), Windows and Linux (Intel)

Ian Kilpatrick

How was it tested if nothing uses the Blink flag yet?

Omar Ramadan

Acknowledged

Ian Kilpatrick

So (I'm a little confused) - I don't think you need the Blink-flag component of this patch then if nothing is going to use it? E.g. is the feature already complete?

Omar Ramadan

Yes, the feature is complete. The flag IS used — patch 2's IDL gates on it directly:
```
// multicast_controller.idl:6-8
dictionary MulticastGroupOptions {
  [RuntimeEnabled=SourceSpecificMulticastInDirectSockets]
  DOMString sourceAddress;
};

Ian Kilpatrick

Ah - Does that compile? This patch should be placed earlier in the chain.

Also you've introduced a behaviour change in `joinGroup`/`leaveGroup` without the flag by allowing an extra arg. See:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/RuntimeEnabledFeatures.md;l=196;drc=e415911248aaf70d148fb40d7876ab66f702ddcb

Omar Ramadan

Done. Addressed both issues:

  1. Reordered the patches so the feature flag CL comes first in the chain.
  2. Changed joinGroup/leaveGroup from optional MulticastGroupOptions to proper overloads — the base signature joinGroup(DOMString ipAddress) is always available, and the overload accepting MulticastGroupOptions is gated with
  [RuntimeEnabled=SourceSpecificMulticastInDirectSockets]. When the flag is off, the extra arg is not accepted.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 48

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 25 Feb 2026 04:04:14 +0000

[Ian Kilpatrick (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Ian Kilpatrick voted and added 1 comment

Votes added by Ian Kilpatrick

Code-Review

+1

1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5182, Patchset 48 (Latest): status: "experimental",

Ian Kilpatrick . unresolved

you'll want this off until the main patch lands, then a sepearate enable patch afterwards (e.g. set this to "test").

The reason for this is that if you large patch breaks something, the whole patch may get reverted instead of just a flag flip which will be much less potential work for you.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 48

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 25 Feb 2026 18:46:50 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice

Omar Ramadan added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5182, Patchset 48 (Latest): status: "experimental",

Ian Kilpatrick . resolved

you'll want this off until the main patch lands, then a sepearate enable patch afterwards (e.g. set this to "test").

The reason for this is that if you large patch breaks something, the whole patch may get reverted instead of just a flag flip which will be much less potential work for you.

Omar Ramadan

Good call, changed to "test". Will do a separate follow-up CL to flip it to "experimental" once the main patches land.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 48

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 25 Feb 2026 22:58:08 +0000

[Ian Kilpatrick (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy and Omar Ramadan

Ian Kilpatrick voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 49

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 25 Feb 2026 23:03:01 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Andrew Rayskiy (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Andrew Rayskiy voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 49

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 25 Feb 2026 23:14:23 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice

Omar Ramadan voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 49

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 25 Feb 2026 23:27:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy, Ian Kilpatrick and Reilly Grant

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 50 (Latest):

Omar Ramadan . resolved

changed patch order but forgot to put AUTHORS change first

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Ian Kilpatrick
• Reilly Grant

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 50

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Feb 2026 00:28:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Reilly Grant (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy, Ian Kilpatrick and Omar Ramadan

Reilly Grant added 1 comment

File chrome/browser/flag-metadata.json

Line 6664, Patchset 50 (Latest): "name": "multiline-browser-omnibox",
"owners": [ "chris...@chromium.org", "chrome-mob...@google.com" ],
"expiry_milestone": 148
},
{

Reilly Grant . unresolved

Looks like a rebasing error here.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Ian Kilpatrick

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 50

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Feb 2026 00:37:04 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy, Ian Kilpatrick and Reilly Grant

Omar Ramadan added 1 comment

File chrome/browser/flag-metadata.json

Line 6664, Patchset 50: "name": "multiline-browser-omnibox",


"owners": [ "chris...@chromium.org", "chrome-mob...@google.com" ],
"expiry_milestone": 148
},
{

Reilly Grant . resolved

Looks like a rebasing error here.

Omar Ramadan

Good catch, fix. Thanks

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Ian Kilpatrick

• Reilly Grant

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 51

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Feb 2026 00:42:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>

[Reilly Grant (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy, Ian Kilpatrick and Omar Ramadan

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 51 (Latest):

Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Ian Kilpatrick

• Omar Ramadan

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Feb 2026 00:43:59 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ian Kilpatrick (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy and Omar Ramadan

Ian Kilpatrick voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 51

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Feb 2026 01:24:38 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy, Ian Kilpatrick and Reilly Grant

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 52 (Latest):

Omar Ramadan . resolved

Can I get help to try and submit this again?

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Ian Kilpatrick
• Reilly Grant

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 52

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Feb 2026 18:45:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Reilly Grant (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy, Ian Kilpatrick and Omar Ramadan

Reilly Grant voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Ian Kilpatrick

• Omar Ramadan

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Feb 2026 18:48:10 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Reilly Grant (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy, Ian Kilpatrick and Omar Ramadan

Reilly Grant added 1 comment

Patchset-level comments

File-level comment, Patchset 52 (Latest):

Omar Ramadan . resolved

Can I get help to try and submit this again?

Reilly Grant

Have you re-run `AboutFlagsTest.FlagsListedInAlphabeticalOrder`? I still don't think it will pass.

Gerrit-Comment-Date: Thu, 26 Feb 2026 18:49:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Omar Ramadan <om...@blockcast.net>

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy, Ian Kilpatrick and Reilly Grant

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 52:

Omar Ramadan . resolved

Can I get help to try and submit this again?

Reilly Grant

Have you re-run `AboutFlagsTest.FlagsListedInAlphabeticalOrder`? I still don't think it will pass.

Omar Ramadan

Ah sorry I missed `flag-metadata.json` should pass now

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Ian Kilpatrick

• Reilly Grant

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 53

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Feb 2026 19:12:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>

Comment-In-Reply-To: Omar Ramadan <om...@blockcast.net>

[Reilly Grant (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy, Ian Kilpatrick and Omar Ramadan

Reilly Grant voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Ian Kilpatrick

• Omar Ramadan

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Feb 2026 19:40:51 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Reilly Grant (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy, Ian Kilpatrick and Omar Ramadan

Reilly Grant added 1 comment

Patchset-level comments

File-level comment, Patchset 53 (Latest):

Reilly Grant . unresolved

Please resolve the presubmit failure.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Ian Kilpatrick
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Gerrit-Comment-Date: Thu, 26 Feb 2026 19:54:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Ian Kilpatrick (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy and Omar Ramadan

Ian Kilpatrick added 1 comment

Patchset-level comments

File-level comment, Patchset 53 (Latest):

Reilly Grant . unresolved

Please resolve the presubmit failure.

Ian Kilpatrick

The presubmit bot is currently broken for some reason.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Omar Ramadan

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 26 Feb 2026 20:05:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>

[Omar Ramadan (Gerrit)]

Attention needed from Andrew Rayskiy, Ian Kilpatrick and Reilly Grant

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 53:

Reilly Grant . resolved

Please resolve the presubmit failure.

Ian Kilpatrick

The presubmit bot is currently broken for some reason.

Omar Ramadan

can we try again?

Open in Gerrit

Related details

Attention is currently required from:

• Andrew Rayskiy
• Ian Kilpatrick
• Reilly Grant

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 54

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Comment-Date: Fri, 27 Feb 2026 19:45:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ian Kilpatrick <ikilp...@chromium.org>

Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>

[Reilly Grant (Gerrit)]

Attention needed from Andrew Rayskiy, Ian Kilpatrick and Omar Ramadan

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 54 (Latest):

Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Andrew Rayskiy
• Ian Kilpatrick
• Omar Ramadan

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Comment-Date: Fri, 27 Feb 2026 19:58:21 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ian Kilpatrick (Gerrit)]

Attention needed from Andrew Rayskiy and Omar Ramadan

Ian Kilpatrick voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

• Andrew Rayskiy
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 54

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Comment-Date: Fri, 27 Feb 2026 20:43:13 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Add feature flags for SourceSpecificMulticastInDirectSockets

https://chromestatus.com/feature/6208452397498368

Intent to prototype: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/692dffe2.050a0220.17ec37.0673.GAE%40google.com

Runtime blink flag is added to runtime_enabled_features.json5 and to
chrome://flags for Source-Specific Multicast in Direct Sockets API.

This adds a separate flag for the new SSM feature while keeping the
base MulticastInDirectSockets as stable to avoid breaking existing
multicast users.

Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7212151

Reviewed-by: Reilly Grant <rei...@chromium.org>

Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>

Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1591769}

Files:

• M AUTHORS
• M chrome/browser/about_flags.cc
• M chrome/browser/flag-metadata.json
• M chrome/browser/flag_descriptions.h
• M third_party/blink/renderer/platform/runtime_enabled_features.json5
• M tools/metrics/histograms/enums.xml

Change size: S

Delta: 6 files changed, 34 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Reilly Grant, +1 by Ian Kilpatrick

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I60fda8d518acd462b2ef78d60ce418f5b1a0838e

Gerrit-Change-Number: 7212151

Gerrit-PatchSet: 55

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>