[Connection Allowlist] Bypass for local schemes. [chromium/src : main]

0 views
Skip to first unread message

Mike West (Gerrit)

unread,
Apr 2, 2026, 11:03:39 AM (2 days ago) Apr 2
to Shivani Sharma, Chromium LUCI CQ, chromium...@chromium.org, fenced-fra...@chromium.org, network-ser...@chromium.org
Attention needed from Shivani Sharma

Mike West voted and added 1 comment

Votes added by Mike West

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1:
Mike West . resolved

Shivani: I didn't actually compile this, so it might blow up on the bots. Assuming it doesn't (and you're happy with it), I'll find someone to review the network service portion. 😊

(I'll check it tonight or tomorrow to make sure the code actually works, I promise!)

Open in Gerrit

Related details

Attention is currently required from:
  • Shivani Sharma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8615ded166b261961ed6ab23f6fdd998be4b4105
Gerrit-Change-Number: 7725903
Gerrit-PatchSet: 1
Gerrit-Owner: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>
Gerrit-Attention: Shivani Sharma <shiva...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 15:03:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shivani Sharma (Gerrit)

unread,
Apr 2, 2026, 11:12:26 AM (2 days ago) Apr 2
to Mike West, Chromium LUCI CQ, chromium...@chromium.org, fenced-fra...@chromium.org, network-ser...@chromium.org
Attention needed from Mike West

Shivani Sharma voted and added 1 comment

Votes added by Shivani Sharma

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Shivani Sharma . resolved

lgtm, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Mike West
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8615ded166b261961ed6ab23f6fdd998be4b4105
    Gerrit-Change-Number: 7725903
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Shivani Sharma <shiva...@chromium.org>
    Gerrit-Attention: Mike West <mk...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 15:12:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages