Make EnableStaticKeyPinningForTesting and SetTransportSecurityStateSource async [chromium/src : main]
0 views
Skip to first unread message
Matt Mueller (Gerrit)
Sep 3, 2025, 9:19:36 PM (5 days ago) Sep 3
to Matt Mueller, Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, hayato...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, twifka...@chromium.org
Attention needed from Chris Thompson
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Chris Thompson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Thompson (Gerrit)
Sep 4, 2025, 11:44:06 AM (4 days ago) Sep 4
to Matt Mueller, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, hayato...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, twifka...@chromium.org
Attention needed from Matt Mueller
Chris Thompson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Matt Mueller
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Sep 4, 2025, 1:05:38 PM (4 days ago) Sep 4
to Matt Mueller, Enterprise Policy Reviews, Chromium IPC Reviews, Tom Sepez, Igor, Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, hayato...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, twifka...@chromium.org
Attention needed from Igor and Tom Sepez
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: tse...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): tse...@chromium.org
Reviewer source(s):
igo...@chromium.org is from context(chrome/enterprise/gwsq/enterprise-policy-review.gwsq)
tse...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Igor
- Tom Sepez
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Sepez (Gerrit)
Sep 4, 2025, 1:06:21 PM (4 days ago) Sep 4
to Matt Mueller, Enterprise Policy Reviews, Chromium IPC Reviews, Igor, Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, hayato...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, twifka...@chromium.org
Attention needed from Igor and Matt Mueller
Tom Sepez voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Igor
- Matt Mueller
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Sep 4, 2025, 8:53:35 PM (4 days ago) Sep 4
to Matt Mueller, Eric Orth, Tom Sepez, Enterprise Policy Reviews, Chromium IPC Reviews, Igor, Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, hayato...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, twifka...@chromium.org
Attention needed from Eric Orth, Igor and Matt Mueller
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Eric Orth
- Igor
- Matt Mueller
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Orth (Gerrit)
Sep 5, 2025, 2:27:28 PM (3 days ago) Sep 5
to Matt Mueller, Kouhei Ueno, Tom Sepez, Enterprise Policy Reviews, Chromium IPC Reviews, Igor, Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, hayato...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, twifka...@chromium.org
Attention needed from Igor and Matt Mueller
Eric Orth voted and added 1 comment![]( "Open in Gerrit")
Votes added by Eric Orth
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Eric Orth . resolved
LGTM for net/ and services/network/ related files (including network_service_test_helper.cc).
Related details
Attention is currently required from:
- Igor
- Matt Mueller
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor (Gerrit)
2:08 AM (10 hours ago) 2:08 AM
to Matt Mueller, Eric Orth, Kouhei Ueno, Tom Sepez, Enterprise Policy Reviews, Chromium IPC Reviews, Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, hayato...@chromium.org, ipc-securi...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, twifka...@chromium.org
Attention needed from Matt Mueller
Igor voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Matt Mueller
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages