CORS: Add feature flag to ignore CorsPreflightPolicy [chromium/src : main]

0 views
Skip to first unread message

Takashi Toyoshima (Gerrit)

unread,
Apr 3, 2026, 7:48:17 AM (yesterday) Apr 3
to Rakina Zata Amni, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, James Maclean, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Kenichi Ishibashi and Rakina Zata Amni

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Kenichi Ishibashi
  • Rakina Zata Amni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iae680ff0940a0b2a012170bc322e78f72c624556
Gerrit-Change-Number: 7728431
Gerrit-PatchSet: 12
Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Apr 2026 11:47:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

AI Code Reviewer (Gerrit)

unread,
Apr 3, 2026, 7:49:32 AM (yesterday) Apr 3
to Takashi Toyoshima, Rakina Zata Amni, Kenichi Ishibashi, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, James Maclean, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
Attention needed from Kenichi Ishibashi and Rakina Zata Amni

AI Code Reviewer added 1 comment

File third_party/blink/renderer/platform/loader/fetch/resource_request.h
Line 514, Patchset 12 (Latest): void SetEventSourceLastId(const String& value) {
AI Code Reviewer . unresolved

nit: Blink Style Guide: Naming - Precede setters with the word “Set”; use bare words for getters. Setter and getter names should match the names of the variable being accessed/mutated. Consider renaming the methods to `SetEventSourceLastEventId` and `GetEventSourceLastEventId` to match the `event_source_last_event_id_` member, or rename the member to `event_source_last_id_`.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:
  • Kenichi Ishibashi
  • Rakina Zata Amni
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iae680ff0940a0b2a012170bc322e78f72c624556
    Gerrit-Change-Number: 7728431
    Gerrit-PatchSet: 12
    Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 11:49:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kenichi Ishibashi (Gerrit)

    unread,
    Apr 3, 2026, 5:26:58 PM (16 hours ago) Apr 3
    to Takashi Toyoshima, AI Code Reviewer, Rakina Zata Amni, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, James Maclean, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, network-ser...@chromium.org
    Attention needed from Rakina Zata Amni and Takashi Toyoshima

    Kenichi Ishibashi voted and added 1 comment

    Votes added by Kenichi Ishibashi

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 12 (Latest):
    Kenichi Ishibashi . resolved

    lgtm, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rakina Zata Amni
    • Takashi Toyoshima
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iae680ff0940a0b2a012170bc322e78f72c624556
      Gerrit-Change-Number: 7728431
      Gerrit-PatchSet: 12
      Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      Gerrit-CC: James Maclean <wjma...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Comment-Date: Fri, 03 Apr 2026 21:26:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages