Report cookies to the UI thread later in the navigation flow [chromium/src : main]

0 views
Skip to first unread message

Charlie Harrison (Gerrit)

unread,
Sep 5, 2025, 3:51:32 PM (3 days ago) Sep 5
to Maks Orlovich, Giovanni Ortuno Urquidi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Maks Orlovich

Charlie Harrison added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Charlie Harrison . resolved

Maks: can you review? I've also cc'd Giovanni who worked on making cookie observers more robust for navigational requests.

Open in Gerrit

Related details

Attention is currently required from:
  • Maks Orlovich
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I51aa798cd41d29f91e4b9e37afe5379a0ddbf26d
Gerrit-Change-Number: 6916536
Gerrit-PatchSet: 6
Gerrit-Owner: Charlie Harrison <cshar...@chromium.org>
Gerrit-Reviewer: Charlie Harrison <cshar...@chromium.org>
Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Attention: Maks Orlovich <morl...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 19:51:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Maks Orlovich (Gerrit)

unread,
Sep 5, 2025, 3:53:56 PM (3 days ago) Sep 5
to Charlie Harrison, Giovanni Ortuno Urquidi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Charlie Harrison

Maks Orlovich added 2 comments

Patchset-level comments
Charlie Harrison . resolved

Maks: can you review? I've also cc'd Giovanni who worked on making cookie observers more robust for navigational requests.

Maks Orlovich

Generally yes, but will probably have to wait till Monday. Brain too invested in current task.

Maks Orlovich . resolved

Generally

Open in Gerrit

Related details

Attention is currently required from:
  • Charlie Harrison
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I51aa798cd41d29f91e4b9e37afe5379a0ddbf26d
Gerrit-Change-Number: 6916536
Gerrit-PatchSet: 6
Gerrit-Owner: Charlie Harrison <cshar...@chromium.org>
Gerrit-Reviewer: Charlie Harrison <cshar...@chromium.org>
Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Attention: Charlie Harrison <cshar...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 19:53:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Charlie Harrison <cshar...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Charlie Harrison (Gerrit)

unread,
Sep 5, 2025, 3:58:13 PM (3 days ago) Sep 5
to Maks Orlovich, Giovanni Ortuno Urquidi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, creis...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Maks Orlovich

Charlie Harrison added 1 comment

Patchset-level comments
Charlie Harrison . resolved

Maks: can you review? I've also cc'd Giovanni who worked on making cookie observers more robust for navigational requests.

Maks Orlovich

Generally yes, but will probably have to wait till Monday. Brain too invested in current task.

Charlie Harrison

No rush!

Open in Gerrit

Related details

Attention is currently required from:
  • Maks Orlovich
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I51aa798cd41d29f91e4b9e37afe5379a0ddbf26d
Gerrit-Change-Number: 6916536
Gerrit-PatchSet: 6
Gerrit-Owner: Charlie Harrison <cshar...@chromium.org>
Gerrit-Reviewer: Charlie Harrison <cshar...@chromium.org>
Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
Gerrit-CC: Giovanni Ortuno Urquidi <ort...@chromium.org>
Gerrit-Attention: Maks Orlovich <morl...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 19:58:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maks Orlovich <morl...@chromium.org>
Comment-In-Reply-To: Charlie Harrison <cshar...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages