[LNA] Enable LNA enforcement by default [chromium/src : main]
2 views
Skip to first unread message
Chris Thompson (Gerrit)
Sep 3, 2025, 7:09:16 PM (5 days ago) Sep 3
to Hubert Chao, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Hubert Chao
Chris Thompson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Chris Thompson . resolved
hchao@ could you PTAL before I send to owners? Thanks!
Related details
Attention is currently required from:
- Hubert Chao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hubert Chao (Gerrit)
Sep 4, 2025, 10:42:44 AM (4 days ago) Sep 4
to Chris Thompson, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Chris Thompson
Hubert Chao voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hubert Chao
| Code-Review | +1 |
1 comment
File content/browser/worker_host/shared_worker_host_unittest.cc
Line 427, Patchset 9 (Latest):
// Enable PrivateNetworkAccessForWorkers.Hubert Chao . unresolved
nit: fix comment
Related details
Attention is currently required from:
- Chris Thompson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Thompson (Gerrit)
Sep 4, 2025, 11:31:09 AM (4 days ago) Sep 4
to Hubert Chao, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Chris Thompson added 1 comment![]( "Open in Gerrit")
File content/browser/worker_host/shared_worker_host_unittest.cc
Line 427, Patchset 9:
// Enable PrivateNetworkAccessForWorkers.Hubert Chao . resolved
Chris Thompsonnit: fix comment
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Thompson (Gerrit)
Sep 4, 2025, 11:41:31 AM (4 days ago) Sep 4
to Chris Harrelson, Camille Lamy, Richard (Torne) Coles, Hubert Chao, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Camille Lamy, Chris Harrelson, Richard (Torne) Coles and mmenke
Chris Thompson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 10 (Latest):
Chris Thompson . resolved
Adding OWNERS, could you PTAL?
- torne@ for android_webview/
- clamy@ for content/
- mmenke@ for services/network/
- chrishtr@ for API Owners review of webexposed WPT expectations
Thanks!
Related details
Attention is currently required from:
- Camille Lamy
- Chris Harrelson
- Richard (Torne) Coles
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Sep 4, 2025, 11:52:31 AM (4 days ago) Sep 4
to Chris Thompson, Chris Harrelson, Camille Lamy, Richard (Torne) Coles, Hubert Chao, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Camille Lamy, Chris Harrelson, Chris Thompson and Richard (Torne) Coles
mmenke voted and added 1 comment![]( "Open in Gerrit")
Votes added by mmenke
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Camille Lamy
- Chris Harrelson
- Chris Thompson
- Richard (Torne) Coles
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Harrelson (Gerrit)
Sep 4, 2025, 12:04:02 PM (4 days ago) Sep 4
to Chris Thompson, Camille Lamy, Richard (Torne) Coles, Hubert Chao, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Camille Lamy, Chris Thompson and Richard (Torne) Coles
Chris Harrelson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Camille Lamy
- Chris Thompson
- Richard (Torne) Coles
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Richard (Torne) Coles (Gerrit)
Sep 4, 2025, 1:07:16 PM (4 days ago) Sep 4
to Chris Thompson, Richard (Torne) Coles, Chris Harrelson, Camille Lamy, Hubert Chao, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Camille Lamy and Chris Thompson
Richard (Torne) Coles voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Camille Lamy
- Chris Thompson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Thompson (Gerrit)
Sep 4, 2025, 6:23:23 PM (4 days ago) Sep 4
to Richard (Torne) Coles, Chris Harrelson, Camille Lamy, Hubert Chao, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Camille Lamy
Chris Thompson voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Camille Lamy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camille Lamy (Gerrit)
Sep 5, 2025, 5:49:12 AM (3 days ago) Sep 5
to Chris Thompson, Richard (Torne) Coles, Chris Harrelson, Hubert Chao, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Chris Thompson
Camille Lamy voted and added 1 comment![]( "Open in Gerrit")
Votes added by Camille Lamy
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Chris Thompson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hubert Chao (Gerrit)
Sep 5, 2025, 11:25:20 AM (3 days ago) Sep 5
to Chris Thompson, Camille Lamy, Richard (Torne) Coles, Chris Harrelson, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Camille Lamy, Chris Harrelson, Chris Thompson, Richard (Torne) Coles and mmenke
Hubert Chao voted![]( "Open in Gerrit")
Attention is currently required from:
- Camille Lamy
- Chris Harrelson
- Chris Thompson
- Richard (Torne) Coles
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Harrelson (Gerrit)
Sep 5, 2025, 1:06:43 PM (3 days ago) Sep 5
to Chris Thompson, Hubert Chao, Camille Lamy, Richard (Torne) Coles, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Camille Lamy, Chris Thompson, Hubert Chao, Richard (Torne) Coles and mmenke
Chris Harrelson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Camille Lamy
- Chris Thompson
- Hubert Chao
- Richard (Torne) Coles
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Thompson (Gerrit)
Sep 5, 2025, 1:48:02 PM (3 days ago) Sep 5
to Chris Harrelson, Hubert Chao, Camille Lamy, Richard (Torne) Coles, AyeAye, Chromium LUCI CQ, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Attention needed from Camille Lamy, Hubert Chao, Richard (Torne) Coles and mmenke
Chris Thompson voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Camille Lamy
Chromium LUCI CQ (Gerrit)
Sep 5, 2025, 1:58:15 PM (3 days ago) Sep 5
to Chris Thompson, Chris Harrelson, Hubert Chao, Camille Lamy, Richard (Torne) Coles, AyeAye, android-web...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org, network-ser...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[LNA] Enable LNA enforcement by default
Enables Local Network Access check enforcement by default. This covers
subresources requests, fetch() requests, and subframe navigations
(including via workers). Out of scope is WebSockets, WebTransport, and
WebRTC.
This also explicitly *disables* the feature flag in WebView, as the
permissions policy would still be required in iframes inside a WebView
despite the permission itself being auto-granted. See
crbug.com/442879527 for more details.
Various tests are updated (or removed as obsolete now that LNA is
launching).
ChromeStatus: https://chromestatus.com/feature/5152728072060928
Intent-to-Ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/cwu_RUmBpzY/m/hk8YuZDWHgAJ
Bug: 442860602
Enabled-by-default-reason: launching
Change-Id: I25be86778ccff81ab2648b394845e16e7642047d
Reviewed-by: Hubert Chao <hc...@chromium.org>
Commit-Queue: Chris Thompson <cth...@chromium.org>
Auto-Submit: Chris Thompson <cth...@chromium.org>
Reviewed-by: Chris Harrelson <chri...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511728}
Files:
- M android_webview/browser/aw_field_trials.cc
- M content/browser/renderer_host/private_network_access_util_unittest.cc
- M content/browser/worker_host/shared_worker_host_unittest.cc
- M services/network/private_network_access_checker_unittest.cc
- M services/network/public/cpp/features.cc
- M services/network/url_loader_unittest.cc
- M third_party/blink/web_tests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
- M third_party/blink/web_tests/virtual/stable/webexposed/feature-policy-features-expected.txt
- M third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
- M third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
- M third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
- M third_party/blink/web_tests/wpt_internal/isolated-permissions-policy-stable/permissions_policy.https.html
Change size: M
Delta: 12 files changed, 50 insertions(+), 128 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chris Harrelson, +1 by Hubert Chao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages