Fix raw headers access leak in DevTools. [chromium/src : main]

0 views

Skip to first unread message

Danil Somsikov (Gerrit)

unread,

Apr 2, 2026, 10:17:01 AM (2 days ago) Apr 2

to Andrey Kosyakov, AyeAye, Chromium LUCI CQ, devtools...@chromium.org, network-ser...@chromium.org

Attention needed from Andrey Kosyakov

Danil Somsikov voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Andrey Kosyakov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrey Kosyakov (Gerrit)

unread,

Apr 2, 2026, 7:42:17 PM (2 days ago) Apr 2

to Danil Somsikov, AyeAye, Chromium LUCI CQ, devtools...@chromium.org, network-ser...@chromium.org

Attention needed from Danil Somsikov

Andrey Kosyakov voted and added 2 comments

Votes added by Andrey Kosyakov

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Andrey Kosyakov . unresolved

lgtm, but... any chance we could get rid of raw headers access altogether now? This used to be needed before we had a dedicated way to report headers to browser (i.e. NetworkServiceDevToolsObserver) and ideally should not be needed now.

File content/browser/devtools/render_frame_devtools_agent_host.h

Line 141, Patchset 5 (Latest): RenderFrameDevToolsAgentHost* force_include_host = nullptr);

Andrey Kosyakov . unresolved

can we drop the default value here? shouldn't be too many calls to take care of.