Add Source-Specific Multicast (SSM) support to net/socket layer [chromium/src : main]

[Omar Ramadan (Gerrit)]

Attention needed from Harald Alvestrand, Reilly Grant and Vlad Krot

Omar Ramadan added 3 comments

Patchset-level comments

File-level comment, Patchset 19:

Omar Ramadan . resolved

thanks @vk...@google.com for guidance. i've reduce the scope here to net/socket layer and moved the rest to CL7186747

Commit Message

Line 7, Patchset 10:Add Source-Specific Multicast (SSM) support to Direct Sockets API

Vlad Krot . resolved

Attach link to chrome entry for other reviewers.

Omar Ramadan

Done

File net/socket/udp_socket_unittest.cc

Line 2138, Patchset 10:TEST_F(UDPSocketTest, JoinSourceGroupIPv4) {

Vlad Krot . resolved

I would split the CL into multiple. The /net/socket/ directory should be in a separate CL from other layers to simplify job of the reviewers.

Omar Ramadan

Done

Open in Gerrit

Related details

Attention is currently required from:

• Harald Alvestrand
• Reilly Grant
• Vlad Krot

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 20

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Vlad Krot <vk...@google.com>

Gerrit-Comment-Date: Fri, 21 Nov 2025 22:37:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Vlad Krot <vk...@google.com>

[Omar Ramadan (Gerrit)]

Attention needed from Harald Alvestrand, Reilly Grant and Vlad Krot

Omar Ramadan added 2 comments

File third_party/blink/public/mojom/direct_sockets/direct_sockets.mojom

Line 113, Patchset 10:// Result codes for Direct Sockets operations.

Vlad Krot . resolved

unused?

Omar Ramadan

Done

File third_party/blink/renderer/modules/direct_sockets/multicast_controller.h

Line 31, Patchset 10: public:

Vlad Krot . resolved

If blink layer is modified, then it must be tested.
First of all unit tests: third_party/blink/renderer/modules/direct_sockets/multicast_controller_unittest.cc

Second, e2e tests on chrome or content layer:
content/browser/direct_sockets/direct_sockets_udp_browsertest.cc,
chrome/browser/direct_sockets/direct_sockets_apitest.cc

There should be complete cases, checking that source filtering works, and many other corner cases.

Omar Ramadan

addressed in CL7186747

Open in Gerrit

Related details

Attention is currently required from:

• Harald Alvestrand
• Reilly Grant
• Vlad Krot

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Gerrit-Comment-Date: Fri, 21 Nov 2025 22:45:27 +0000

[Reilly Grant (Gerrit)]

Attention needed from Harald Alvestrand, Omar Ramadan and Vlad Krot

Reilly Grant added 2 comments

File net/socket/udp_socket_posix.cc

Line 1063, Patchset 20 (Latest): struct ip_mreq_source mreqs = {};

Reilly Grant . unresolved

Can you define helper functions to populate a `struct ip_mreq_source` or `struct group_source_req` from an `IPAddress` that we can use in both the join and leave methods?

File net/socket/udp_socket_win.cc

Line 1408, Patchset 20 (Latest): std::memcpy(&group->sin6_addr, group_address.bytes().data(),

Reilly Grant . unresolved

Why `memcpy` here instead of using `ToIn6Addr`?

Open in Gerrit

Related details

Attention is currently required from:

• Harald Alvestrand
• Omar Ramadan
• Vlad Krot

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 20

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Vlad Krot <vk...@google.com>

Gerrit-Comment-Date: Fri, 21 Nov 2025 23:26:21 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Harald Alvestrand, Reilly Grant and Vlad Krot

Omar Ramadan added 2 comments

File net/socket/udp_socket_posix.cc

Line 1063, Patchset 20: struct ip_mreq_source mreqs = {};

Reilly Grant . resolved

Can you define helper functions to populate a `struct ip_mreq_source` or `struct group_source_req` from an `IPAddress` that we can use in both the join and leave methods?

Omar Ramadan

added `CreateIPv4SourceGroupRequest` / `CreateIPv6SourceGroupRequest` helpers

File net/socket/udp_socket_win.cc

Line 1408, Patchset 20: std::memcpy(&group->sin6_addr, group_address.bytes().data(),

Reilly Grant . resolved

Why `memcpy` here instead of using `ToIn6Addr`?

Omar Ramadan

Done

Open in Gerrit

Related details

Attention is currently required from:

• Harald Alvestrand
• Reilly Grant
• Vlad Krot

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 21

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Vlad Krot <vk...@google.com>

Gerrit-Comment-Date: Sat, 22 Nov 2025 01:28:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>

[Reilly Grant (Gerrit)]

Attention needed from Harald Alvestrand, Omar Ramadan and Vlad Krot

Reilly Grant added 1 comment

File net/socket/udp_socket_win.cc

Line 1374, Patchset 22 (Latest): struct ip_mreq_source mreqs;

Reilly Grant . unresolved

Add struct building helpers here as well?

Open in Gerrit

Related details

Attention is currently required from:

• Harald Alvestrand
• Omar Ramadan
• Vlad Krot

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 22

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Vlad Krot <vk...@google.com>

Gerrit-Comment-Date: Sat, 22 Nov 2025 01:42:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Harald Alvestrand, Reilly Grant and Vlad Krot

Omar Ramadan added 1 comment

File net/socket/udp_socket_win.cc

Line 1374, Patchset 22: struct ip_mreq_source mreqs;

Reilly Grant . resolved

Add struct building helpers here as well?

Omar Ramadan

Done

Open in Gerrit

Related details

Attention is currently required from:

• Harald Alvestrand
• Reilly Grant
• Vlad Krot

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 23

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Vlad Krot <vk...@google.com>

Gerrit-Comment-Date: Sat, 22 Nov 2025 02:06:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>

[Reilly Grant (Gerrit)]

Attention needed from Harald Alvestrand, Omar Ramadan and Vlad Krot

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 23 (Latest):

Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Harald Alvestrand
• Omar Ramadan
• Vlad Krot

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Vlad Krot <vk...@google.com>

Gerrit-Comment-Date: Sat, 22 Nov 2025 02:37:03 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Vlad Krot (Gerrit)]

Attention needed from Harald Alvestrand and Omar Ramadan

Vlad Krot voted and added 1 comment

Votes added by Vlad Krot

Code-Review

+0

1 comment

Patchset-level comments

File-level comment, Patchset 23 (Latest):

Vlad Krot . resolved

please include /net owners.

Open in Gerrit

Related details

Attention is currently required from:

• Harald Alvestrand
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 23

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Mon, 24 Nov 2025 13:07:52 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice, Harald Alvestrand, Kenichi Ishibashi and Nidhi Jaju

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 23 (Latest):

Omar Ramadan . resolved

requesting /net owners review
thank you!

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Harald Alvestrand
• Kenichi Ishibashi
• Nidhi Jaju

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 23

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 24 Nov 2025 16:26:09 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Kenichi Ishibashi (Gerrit)]

Attention needed from Adam Rice, Harald Alvestrand, Nidhi Jaju and Omar Ramadan

Kenichi Ishibashi added 4 comments

Patchset-level comments

File-level comment, Patchset 23 (Latest):

Kenichi Ishibashi . resolved

Mostly looking good! Next time, please consider limiting the number of reviewers.

https://chromium.googlesource.com/chromium/src/+/lkgr/docs/cl_respect.md#choose-your-reviewers

I think you need two approvals from chromium committers though.

File net/socket/udp_socket_posix.h

Line 199, Patchset 23 (Latest): // |group_address| is the multicast group address to join.

Kenichi Ishibashi . unresolved

nit: We use backquotes for new code even existing code uses bars.
https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#comment-style

File net/socket/udp_socket_posix.cc

Line 1084, Patchset 23 (Latest): // Validate that both addresses are the same IP version

Kenichi Ishibashi . unresolved

nit: Please add period.

File net/socket/udp_socket_unittest.cc

Line 2136, Patchset 23 (Latest):// Tests for Source-Specific Multicast (SSM)

Kenichi Ishibashi . unresolved

Can we also have tests to cover not connected cases?

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Harald Alvestrand
• Nidhi Jaju
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Tue, 25 Nov 2025 02:39:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice, Harald Alvestrand, Kenichi Ishibashi, Nidhi Jaju and Reilly Grant

Omar Ramadan added 4 comments

Patchset-level comments

File-level comment, Patchset 23:

Omar Ramadan . resolved

thanks @ba...@chromium.org for the review and guidance. first time contributor so apologies for the large number of reviewers tagged

File net/socket/udp_socket_posix.h

Line 199, Patchset 23: // |group_address| is the multicast group address to join.

Kenichi Ishibashi . resolved

nit: We use backquotes for new code even existing code uses bars.
https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#comment-style

Omar Ramadan

Done

File net/socket/udp_socket_posix.cc

Line 1084, Patchset 23: // Validate that both addresses are the same IP version

Kenichi Ishibashi . resolved

nit: Please add period.

Omar Ramadan

Done

File net/socket/udp_socket_unittest.cc

Line 2136, Patchset 23:// Tests for Source-Specific Multicast (SSM)

Kenichi Ishibashi . resolved

Can we also have tests to cover not connected cases?

Omar Ramadan

Done

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Harald Alvestrand
• Kenichi Ishibashi
• Nidhi Jaju
• Reilly Grant

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 24

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 26 Nov 2025 17:04:28 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Kenichi Ishibashi <ba...@chromium.org>

[Kenichi Ishibashi (Gerrit)]

Attention needed from Adam Rice, Harald Alvestrand, Nidhi Jaju, Omar Ramadan and Reilly Grant

Kenichi Ishibashi added 1 comment

Patchset-level comments

File-level comment, Patchset 24 (Latest):

Kenichi Ishibashi . resolved

looking good, running trybots before approval.

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Harald Alvestrand
• Nidhi Jaju
• Omar Ramadan
• Reilly Grant

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 27 Nov 2025 00:21:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice, Harald Alvestrand, Kenichi Ishibashi, Nidhi Jaju and Reilly Grant

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 24 (Latest):

Omar Ramadan . resolved

thanks -- keeping an eye on the test run results

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Harald Alvestrand
• Kenichi Ishibashi
• Nidhi Jaju
• Reilly Grant

Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Harald Alvestrand <h...@chromium.org>

Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Thu, 27 Nov 2025 00:32:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Kenichi Ishibashi (Gerrit)]

Attention needed from Omar Ramadan

Kenichi Ishibashi added 1 comment

Patchset-level comments

File-level comment, Patchset 25 (Latest):

Kenichi Ishibashi . resolved

Can you fix the test failure? Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 25

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Thu, 27 Nov 2025 01:40:21 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Adam Rice (Gerrit)]

Attention needed from Omar Ramadan

Adam Rice added 4 comments

Patchset-level comments

File-level comment, Patchset 45 (Latest):

Adam Rice . resolved

Sorry for the slow review!

Commit Message

Line 32, Patchset 45 (Latest):Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160820

Adam Rice . unresolved

You don't need to add the Reviewed-on field yourself, Gerrit does it automatically when the change is submitted.

File net/socket/udp_socket_unittest.cc

Line 2137, Patchset 45 (Latest):

Adam Rice . unresolved

I suggest you define a constant like
```
#if defined(MCAST_LEAVE_SOURCE_GROUP) && !BUILDFLAG(IS_ANDROID) && \
    !BUILDFLAG(IS_IOS)
constexpr bool kExpectSSMToWork = true;
#else
constexpr bool kExpectSSMToWork = false;
#endif
```
and then use `kExpectSSMToWork` in the tests to ensure that ERR_NOT_IMPLEMENTED is only returned when we expect it to be.

Line 2291, Patchset 45 (Latest): // If either failed, platform doesn't support SSM

Adam Rice . unresolved

They may have failed for some other reason, this test is not reliable.

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 45

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Thu, 08 Jan 2026 09:16:21 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice

Omar Ramadan added 4 comments

Patchset-level comments

File-level comment, Patchset 48 (Latest):

Omar Ramadan . resolved

No worries at all, thank you for the thorough review!

  Changes:

  1. Removed Reviewed-on: field from commit message - Gerrit will add this automatically on submit.
  2. Added kExpectSSMToWork constant for reliable test behavior:
  #if defined(MCAST_JOIN_SOURCE_GROUP) && !BUILDFLAG(IS_ANDROID) && \

      !BUILDFLAG(IS_IOS)
  constexpr bool kExpectSSMToWork = true;
  #else
  constexpr bool kExpectSSMToWork = false;
  #endif

  3. Updated SSM tests to use kExpectSSMToWork:
    - JoinSourceGroupIPv4/JoinSourceGroupIPv6: Assert IsOk() when SSM is expected to work, ERR_NOT_IMPLEMENTED otherwise
    - JoinSourceGroupMultipleSources/JoinSourceGroupMultipleSourcesIPv6: Use GTEST_SKIP() when SSM not supported; assert all operations succeed when it is (removed unreliable "if failed, platform doesn't support SSM" pattern)
    - SSMSourceFilteringMultiNIC: Added kExpectSSMToWork skip check

  Tested locally on Linux/OSX/Windows.

Commit Message

Line 32, Patchset 45:Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160820

Adam Rice . resolved

You don't need to add the Reviewed-on field yourself, Gerrit does it automatically when the change is submitted.

Omar Ramadan

Done

File net/socket/udp_socket_unittest.cc

Line 2137, Patchset 45:

Adam Rice . resolved

I suggest you define a constant like
```
#if defined(MCAST_LEAVE_SOURCE_GROUP) && !BUILDFLAG(IS_ANDROID) && \
    !BUILDFLAG(IS_IOS)
constexpr bool kExpectSSMToWork = true;
#else
constexpr bool kExpectSSMToWork = false;
#endif
```
and then use `kExpectSSMToWork` in the tests to ensure that ERR_NOT_IMPLEMENTED is only returned when we expect it to be.

Omar Ramadan

Done

Line 2291, Patchset 45: // If either failed, platform doesn't support SSM

Adam Rice . resolved

They may have failed for some other reason, this test is not reliable.

Omar Ramadan

Done

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 48

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 14 Jan 2026 08:18:28 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>

[Adam Rice (Gerrit)]

Attention needed from Omar Ramadan

Adam Rice added 8 comments

File net/socket/udp_socket_posix.h

Line 198, Patchset 49 (Latest): // Joins a source-specific multicast group. Returns a net error code.

Adam Rice . unresolved

Why did you remove the extra information from the comment? The implementation details might have been unnecessary, but the description of parameters and reference to the RFC were useful.

File net/socket/udp_socket_posix.cc

Line 90, Patchset 49 (Latest):uint32_t GetInterfaceViaRoute(const IPAddress& source_address) {

Adam Rice . unresolved

"GetInterfaceForDestination()" might be a better name.

Line 92, Patchset 49 (Latest): int sock = socket(family, SOCK_DGRAM, 0);

Adam Rice . unresolved

You should locally create a `net::UDPSocketPosix` object instead of doing OS calls directly.

Line 115, Patchset 49 (Latest): if (getifaddrs(&ifap) != 0) {

Adam Rice . unresolved

Use `net::GetNetworkList(&networks, INCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES)` instead of calling `getifaddrs()` directly.

Line 1100, Patchset 45: // Validate that both addresses are the same IP version.

Adam Rice . unresolved

Why did you remove this comment? I found it useful.

Line 1162, Patchset 49 (Latest):#if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_IOS)

Adam Rice . unresolved

This whole chunk of code seems to be identical to a chunk in LeaveSourceGroup(), with the only difference being whether we pass `MCAST_JOIN_SOURCE_GROUP` or `MCAST_LEAVE_SOURCE_GROUP`. So you can factor it out into a method that takes the option as an argument, and call the new method from both places.

File net/socket/udp_socket_unittest.cc

Line 2359, Patchset 49 (Latest): if (!iface.address.IsLoopback()) {

Adam Rice . unresolved

Loopback is already skipped by GetNetworkList(), so this check is unnecessary. Which means you can avoid the loop and just `return interfaces.size() >= 2`.

File net/socket/udp_socket_win.cc

Line 1406, Patchset 49 (Latest): if (group_address.IsIPv4()) {

Adam Rice . unresolved

You can reduce code duplication here by defining a function
`CreateSourceGroupRequest()` which calls one of `CreateIPv4SourceGroupRequest()` or `CreateIPv6SourceGroupRequest()` depending on the value of `group_address.IsIPv4()`. Then the only difference between the IPv4 case and the IPv6 case is whether you pass `IPPROTO_IP` or `IPPROTO_IPV6` to `setsocketopt()`, which you can just write like `group_address.IsIPv4() ? IPPROTO_IP : IPPROTO_IPV6`.

You can also factor out the common code with LeaveSourceGroup() as I described for the POSIX version of the code.

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 49

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Fri, 16 Jan 2026 12:17:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice

Omar Ramadan added 8 comments

File net/socket/udp_socket_posix.h

Line 198, Patchset 49: // Joins a source-specific multicast group. Returns a net error code.

Adam Rice . resolved

Why did you remove the extra information from the comment? The implementation details might have been unnecessary, but the description of parameters and reference to the RFC were useful.

Omar Ramadan

Done

File net/socket/udp_socket_posix.cc

Line 90, Patchset 49:uint32_t GetInterfaceViaRoute(const IPAddress& source_address) {

Adam Rice . resolved

"GetInterfaceForDestination()" might be a better name.

Omar Ramadan

Done

Line 92, Patchset 49: int sock = socket(family, SOCK_DGRAM, 0);

Adam Rice . resolved

You should locally create a `net::UDPSocketPosix` object instead of doing OS calls directly.

Omar Ramadan

Done

Line 115, Patchset 49: if (getifaddrs(&ifap) != 0) {

Adam Rice . resolved

Use `net::GetNetworkList(&networks, INCLUDE_HOST_SCOPE_VIRTUAL_INTERFACES)` instead of calling `getifaddrs()` directly.

Omar Ramadan

Done

Line 1100, Patchset 45: // Validate that both addresses are the same IP version.

Adam Rice . resolved

Why did you remove this comment? I found it useful.

Omar Ramadan

Done

Line 1162, Patchset 49:#if BUILDFLAG(IS_ANDROID) || BUILDFLAG(IS_IOS)

Adam Rice . resolved

This whole chunk of code seems to be identical to a chunk in LeaveSourceGroup(), with the only difference being whether we pass `MCAST_JOIN_SOURCE_GROUP` or `MCAST_LEAVE_SOURCE_GROUP`. So you can factor it out into a method that takes the option as an argument, and call the new method from both places.

Omar Ramadan

Done

File net/socket/udp_socket_unittest.cc

Line 2359, Patchset 49: if (!iface.address.IsLoopback()) {

Adam Rice . resolved

Loopback is already skipped by GetNetworkList(), so this check is unnecessary. Which means you can avoid the loop and just `return interfaces.size() >= 2`.

Omar Ramadan

Done

File net/socket/udp_socket_win.cc

Line 1406, Patchset 49: if (group_address.IsIPv4()) {

Adam Rice . resolved

You can reduce code duplication here by defining a function
`CreateSourceGroupRequest()` which calls one of `CreateIPv4SourceGroupRequest()` or `CreateIPv6SourceGroupRequest()` depending on the value of `group_address.IsIPv4()`. Then the only difference between the IPv4 case and the IPv6 case is whether you pass `IPPROTO_IP` or `IPPROTO_IPV6` to `setsocketopt()`, which you can just write like `group_address.IsIPv4() ? IPPROTO_IP : IPPROTO_IPV6`.

You can also factor out the common code with LeaveSourceGroup() as I described for the POSIX version of the code.

Omar Ramadan

Done

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 50

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Fri, 16 Jan 2026 21:14:01 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>

[Adam Rice (Gerrit)]

Attention needed from Omar Ramadan

Adam Rice added 2 comments

File net/socket/udp_socket_posix.h

Line 199, Patchset 52 (Latest): // |group_address| must be in the SSM range (232.0.0.0/8 for IPv4 or

Adam Rice . unresolved

Nit: please use backticks rather than pipes for variable names in comments in new code. Also below.

File net/socket/udp_socket_posix.cc

Line 92, Patchset 49: int sock = socket(family, SOCK_DGRAM, 0);

Adam Rice . unresolved

You should locally create a `net::UDPSocketPosix` object instead of doing OS calls directly.

Omar Ramadan

Done

Adam Rice

Please do not reply "Done" when you haven't actually done what was asked for.

If you are going to use `socket()` directly, you should add least use `base::ScopedFD` so that no file descriptor leaks are introduced.

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 52

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Mon, 19 Jan 2026 09:52:48 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Omar Ramadan <om...@blockcast.net>

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice

Omar Ramadan added 2 comments

File net/socket/udp_socket_posix.h

Line 199, Patchset 52: // |group_address| must be in the SSM range (232.0.0.0/8 for IPv4 or

Adam Rice . resolved

Nit: please use backticks rather than pipes for variable names in comments in new code. Also below.

Omar Ramadan

Done

File net/socket/udp_socket_posix.cc

Line 92, Patchset 49: int sock = socket(family, SOCK_DGRAM, 0);

Adam Rice . resolved

You should locally create a `net::UDPSocketPosix` object instead of doing OS calls directly.

Omar Ramadan

Done

Adam Rice

Please do not reply "Done" when you haven't actually done what was asked for.

If you are going to use `socket()` directly, you should add least use `base::ScopedFD` so that no file descriptor leaks are introduced.

Omar Ramadan

Appologies Adam on the oversight. Thanks for the tip for `base::ScopedFD` using `net::UDPSocketPosix` is overkill for routing info we need

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 67

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Tue, 20 Jan 2026 07:35:45 +0000

[Adam Rice (Gerrit)]

Attention needed from Omar Ramadan

Adam Rice voted and added 2 comments

Votes added by Adam Rice

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 67 (Latest):

Adam Rice . resolved

lgtm, thanks.

File net/socket/udp_socket_posix.cc

Line 134, Patchset 67 (Latest): for (const auto& iface : interfaces) {
if ((family == AF_INET && iface.address.IsIPv4()) ||
(family == AF_INET6 && iface.address.IsIPv6())) {
return iface.interface_index;
}
}

Adam Rice . unresolved

Maybe more efficient:
```suggestion
  for (const auto& iface : interfaces) {
    // If the size matches, then the family must match.
    if (destination_address.size() == iface.address.size()) {
      return iface.interface_index;
    }
  }
```

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Wed, 21 Jan 2026 03:52:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice

Omar Ramadan added 1 comment

File net/socket/udp_socket_posix.cc

Line 134, Patchset 67: for (const auto& iface : interfaces) {


if ((family == AF_INET && iface.address.IsIPv4()) ||
(family == AF_INET6 && iface.address.IsIPv6())) {
return iface.interface_index;
}
}

Adam Rice . resolved

Maybe more efficient:
```suggestion
  for (const auto& iface : interfaces) {
    // If the size matches, then the family must match.
    if (destination_address.size() == iface.address.size()) {
      return iface.interface_index;
    }
  }
```

Omar Ramadan

This fallback for macOS testing didn't end up working as kernel returns `ENOMEM` when joining a second source for the same (group, interface) pair with an explicit interface index.

  Sequence with documentation addresses:
  1. `JoinSourceGroup(232.1.1.1, 192.0.2.1)` → `connect()` fails → fallback returns interface 5 → succeeds
  2. `JoinSourceGroup(232.1.1.1, 192.0.2.2)` → `connect()` fails → fallback returns interface 5 → ENOMEM

  With real local addresses (from `GetLocalAddresses()`):
  1. `JoinSourceGroup(232.1.1.1, 10.0.0.50)` → `connect()` succeeds → returns interface via routing → succeeds
  2. `JoinSourceGroup(232.1.1.1, 192.168.1.100)` → `connect()` succeeds → may return same or different interface → succeeds

  The difference seems to be that when macOS can actually route to the source address (even if it's a local address), the kernel handles multiple source subscriptions correctly. With non-routable addresses and an explicit fallback interface, something in the kernel's SSM state management fails. 

While it would work to update the test cases to use an internet routable pair of IPs e.g 8.8.8 and 8.8.4.4, adding a `GetLocalAddresses` helper for MacOS to retrieve available test runner address pairs

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 69

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 21 Jan 2026 10:27:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>

[Adam Rice (Gerrit)]

Attention needed from Omar Ramadan

Adam Rice voted and added 2 comments

Votes added by Adam Rice

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 69 (Latest):

Adam Rice . resolved

lgtm, thanks.

File net/socket/udp_socket_unittest.cc

Line 2297, Patchset 69 (Latest):#if BUILDFLAG(IS_MAC)

Adam Rice . unresolved

Nit: since this code is compilable on other platforms, it is better to do
```
if constexpr (BUILDFLAG(IS_MAC)) {
  ...
} else {
  ...
}
```
This will make it easier for non-macOS developers to update both branches if they need to. The unused branch is checked for correctness but not compiled into the binary.

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Tue, 27 Jan 2026 08:43:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Andrew Rayskiy (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Andrew Rayskiy voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 69

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Tue, 27 Jan 2026 09:19:00 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice and Andrew Rayskiy

Omar Ramadan added 2 comments

Patchset-level comments

File-level comment, Patchset 70 (Latest):

Omar Ramadan . resolved

thanks for the +1. addressing nits and MacOS unroutable address test failures for v6

File net/socket/udp_socket_unittest.cc

Line 2297, Patchset 69:#if BUILDFLAG(IS_MAC)

Adam Rice . resolved

Nit: since this code is compilable on other platforms, it is better to do
```
if constexpr (BUILDFLAG(IS_MAC)) {
  ...
} else {
  ...
}
```
This will make it easier for non-macOS developers to update both branches if they need to. The unused branch is checked for correctness but not compiled into the binary.

Omar Ramadan

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 70

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 28 Jan 2026 06:06:02 +0000

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice and Andrew Rayskiy

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 72 (Latest):

Omar Ramadan . resolved

seems macOS CI machines only have link-local addresses - adding skip if no suitable IPs

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 72

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Wed, 28 Jan 2026 22:59:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice and Andrew Rayskiy

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 74 (Latest):

Omar Ramadan . resolved

any additional feedback here? can i get +1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 74

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 02 Feb 2026 17:23:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Andrew Rayskiy (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Andrew Rayskiy voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 74

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 02 Feb 2026 17:25:05 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Adam Rice (Gerrit)]

Attention needed from Omar Ramadan

Adam Rice voted and added 1 comment

Votes added by Adam Rice

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 74 (Latest):

Adam Rice . resolved

Patchset 74 still lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Gerrit-Comment-Date: Mon, 02 Feb 2026 20:45:12 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Omar Ramadan voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Gerrit-Comment-Date: Mon, 02 Feb 2026 22:36:32 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Adam Rice (Gerrit)]

Attention needed from Omar Ramadan

Adam Rice added 1 comment

Patchset-level comments

File-level comment, Patchset 74 (Latest):

Adam Rice . unresolved

reillyg, if you are okay with this now, I will submit.

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Mon, 16 Feb 2026 14:48:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Reilly Grant (Gerrit)]

Attention needed from Omar Ramadan

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 74 (Latest):

Reilly Grant . resolved

LGTM

Open in Gerrit

Gerrit-Comment-Date: Tue, 17 Feb 2026 18:37:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 74:

Adam Rice . resolved

reillyg, if you are okay with this now, I will submit.

Omar Ramadan

Acknowledged

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 77

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 25 Feb 2026 23:21:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Adam Rice <ri...@chromium.org>

[Omar Ramadan (Gerrit)]

Omar Ramadan voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Wed, 25 Feb 2026 23:27:55 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Reilly Grant (Gerrit)]

Attention needed from Omar Ramadan

Reilly Grant voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 82

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Comment-Date: Fri, 27 Feb 2026 21:24:01 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Reilly Grant (Gerrit)]

Attention needed from Omar Ramadan

Reilly Grant added 1 comment

Patchset-level comments

File-level comment, Patchset 82 (Latest):

Reilly Grant . unresolved

Please fix or disable this feature on Fuchsia.

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Gerrit-Comment-Date: Fri, 27 Feb 2026 22:44:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy and Reilly Grant

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 82:

Reilly Grant . resolved

Please fix or disable this feature on Fuchsia.

Omar Ramadan

Disabled on Fuchsia for now

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Reilly Grant

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 83

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Fri, 27 Feb 2026 23:04:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>

[Reilly Grant (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy and Omar Ramadan

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 83 (Latest):

Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Omar Ramadan

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Fri, 27 Feb 2026 23:34:28 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy and Reilly Grant

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 84 (Latest):

Omar Ramadan . resolved

sorry there was one guard I missed

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Reilly Grant

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 84

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Fri, 27 Feb 2026 23:54:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Reilly Grant (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy and Omar Ramadan

Reilly Grant voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Omar Ramadan

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Sat, 28 Feb 2026 00:07:04 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Omar Ramadan (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy and Reilly Grant

Omar Ramadan added 1 comment

Patchset-level comments

File-level comment, Patchset 84 (Latest):

Omar Ramadan . resolved

the failures are unrelated to this CL.. retry?

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Reilly Grant

Gerrit-Attention: Reilly Grant <rei...@chromium.org>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Sat, 28 Feb 2026 00:50:45 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Reilly Grant (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy and Omar Ramadan

Reilly Grant voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Andrew Rayskiy
• Omar Ramadan

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Andrew Rayskiy <green...@google.com>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Sat, 28 Feb 2026 00:57:02 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Reilly Grant (Gerrit)]

Attention needed from Adam Rice, Andrew Rayskiy and Omar Ramadan

Reilly Grant voted Code-Review+1

Code-Review

+1

Gerrit-Comment-Date: Sat, 28 Feb 2026 02:08:39 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Andrew Rayskiy (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Andrew Rayskiy voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Rice
• Omar Ramadan

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 84

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Omar Ramadan <om...@blockcast.net>

Gerrit-Attention: Adam Rice <ri...@chromium.org>

Gerrit-Comment-Date: Mon, 02 Mar 2026 10:18:46 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Andrew Rayskiy (Gerrit)]

Attention needed from Adam Rice and Omar Ramadan

Andrew Rayskiy voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Mon, 02 Mar 2026 10:19:01 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Adam Rice (Gerrit)]

Attention needed from Omar Ramadan

Adam Rice voted and added 1 comment

Votes added by Adam Rice

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 84 (Latest):

Adam Rice . resolved

PS 84 still lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Omar Ramadan

Gerrit-Comment-Date: Mon, 02 Mar 2026 10:55:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Add Source-Specific Multicast (SSM) support to net/socket layer

https://chromestatus.com/feature/6208452397498368

Intent to prototype: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/692dffe2.050a0220.17ec37.0673.GAE%40google.com

Implement low-level socket operations for Source-Specific Multicast
(SSM) to enable OS-level source filtering when joining multicast groups,
enabling source-specific multicast filtering for improved security,
particularly outside private networks.

Changes:
- Add UDPSocket::JoinSourceGroup() using IP_ADD_SOURCE_MEMBERSHIP (POSIX)
- Add UDPSocket::LeaveSourceGroup() using IP_DROP_SOURCE_MEMBERSHIP (POSIX)
- Add IPv6 SSM support via MCAST_JOIN_SOURCE_GROUP / MCAST_LEAVE_SOURCE_GROUP
- Handle Apple / BSD group_source_req struct variant address length field
- Add comprehensive unit tests for IPv4 and IPv6 SSM operations

Unit Tests:
- Nominal SSM Join + Leave for IPv4 and IPv6
- Nominal SSM Join + Leave for multiple sources
- Error on Leave SSM group not joined
- Error on IP version mismatch between source and group

Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7160820

Reviewed-by: Reilly Grant <rei...@chromium.org>

Reviewed-by: Andrew Rayskiy <green...@google.com>

Commit-Queue: Andrew Rayskiy <green...@google.com>

Reviewed-by: Adam Rice <ri...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1592339}

Files:

• M net/socket/udp_socket_posix.cc
• M net/socket/udp_socket_posix.h
• M net/socket/udp_socket_unittest.cc
• M net/socket/udp_socket_win.cc
• M net/socket/udp_socket_win.h

Change size: L

Delta: 5 files changed, 685 insertions(+), 5 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Reilly Grant, +1 by Andrew Rayskiy, +1 by Adam Rice

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id4f2cb41f7620ba589ff86bc5e6946486dd624c8

Gerrit-Change-Number: 7160820

Gerrit-PatchSet: 85

Gerrit-Owner: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Adam Rice <ri...@chromium.org>

Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Harald Alvestrand <h...@chromium.org>

Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>

Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>

Gerrit-Reviewer: Omar Ramadan <om...@blockcast.net>

Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>

Gerrit-Reviewer: Vlad Krot <vk...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>